Re: [6lo] Secdir last call review of draft-ietf-6lo-plc-05

Robert Sparks <rjsparks@nostrum.com> Fri, 05 March 2021 15:57 UTC

Return-Path: <rjsparks@nostrum.com>
X-Original-To: 6lo@ietfa.amsl.com
Delivered-To: 6lo@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 08F243A2722; Fri, 5 Mar 2021 07:57:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.679
X-Spam-Level:
X-Spam-Status: No, score=-1.679 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, KHOP_HELO_FCRDNS=0.001, NICE_REPLY_A=-0.001, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ReetF_o6-qx2; Fri, 5 Mar 2021 07:57:54 -0800 (PST)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C677C3A2712; Fri, 5 Mar 2021 07:57:54 -0800 (PST)
Received: from unformal.local ([47.186.1.92]) (authenticated bits=0) by nostrum.com (8.16.1/8.16.1) with ESMTPSA id 125Fvb7f000698 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 5 Mar 2021 09:57:38 -0600 (CST) (envelope-from rjsparks@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1614959858; bh=J8GtWsrykqh5KX48LqhwTFAgeAAkipcYOWHmKn7SR3Y=; h=To:Cc:References:From:Subject:Date:In-Reply-To; b=qUlkYrLUobc21HFobG/zC0DKvxq/KGx8KBv+A/OTaDNEVTJp+5eTz16wVO+XP+JNP ND4jYr0rnHKZIS4QUfb0w3LUF98m2fbklswNCVgygIFAhvAZbtjtqVFpxXxPjny7Uc ynk+QTMSkYHimyhoYMvHhejVOB3foc41ieHFFwz4=
X-Authentication-Warning: raven.nostrum.com: Host [47.186.1.92] claimed to be unformal.local
To: "Liubing (Remy)" <remy.liubing@huawei.com>, "secdir@ietf.org" <secdir@ietf.org>
Cc: "6lo@ietf.org" <6lo@ietf.org>, "draft-ietf-6lo-plc.all@ietf.org" <draft-ietf-6lo-plc.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
References: <BB09947B5326FE42BA3918FA28765C2E014F4FC1@DGGEMM506-MBX.china.huawei.com>
From: Robert Sparks <rjsparks@nostrum.com>
Message-ID: <39b86d13-4e48-75bd-e85b-d5231740369a@nostrum.com>
Date: Fri, 05 Mar 2021 09:57:32 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <BB09947B5326FE42BA3918FA28765C2E014F4FC1@DGGEMM506-MBX.china.huawei.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/6lo/8qtXjVug6R2cnzxNkLcpNcws0Yc>
Subject: Re: [6lo] Secdir last call review of draft-ietf-6lo-plc-05
X-BeenThere: 6lo@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Mailing list for the 6lo WG for Internet Area issues in IPv6 over constrained node networks." <6lo.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/6lo>, <mailto:6lo-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/6lo/>
List-Post: <mailto:6lo@ietf.org>
List-Help: <mailto:6lo-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/6lo>, <mailto:6lo-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Mar 2021 15:57:57 -0000

Inline.

On 3/4/21 9:49 PM, Liubing (Remy) wrote:
> Hello Robert,
>
> Thank you very much for your comments. It helps a lot.
>
> Please see our response inline.
>
> Best regards,
> Remy
> -----邮件原件-----
> 发件人: Robert Sparks via Datatracker [mailto:noreply@ietf.org]
> 发送时间: 2021年2月15日 6:50
> 收件人: secdir@ietf.org
> 抄送: 6lo@ietf.org; draft-ietf-6lo-plc.all@ietf.org; last-call@ietf.org
> 主题: Secdir last call review of draft-ietf-6lo-plc-05
>
> Reviewer: Robert Sparks
> Review result: Has Issues
>
> I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors. Document editors and WG chairs should treat these comments just like any other last call comments.
>
> This document has issues that should be addressed before publication as Proposed Standard RFC.
>
> Document reviewed: draft-ietf-6lo-plc-05
>
> This document's primary point is to standardize mappings of ipv6 identifiers for using ipv6 over IEEE 1901.1, 1901.2, and IT-T G.9903 networks.
>
> Those standards are not publicy available, and I have not reviewed how these mappings and the security mechanisms in those protocols interact.
>
> The document has content that is not needed for its purpose. Section 5 in particular might be useful in an informational RFC, but is has no impact on someone implementing what this document is trying to standardize.
> [Remy] Yes, this section is more like informational. We'll ask the WG if we should remove it or not.
>
> The security considerations section speaks primarily to generic considerations for 6lo-like networks. There is no specific discussion of the impact of the identifier mappings with the underlying protocols, in particular the constraints that don't allow using the full number of bits of entropy in the identifiers in those underlying protocols. There is only a passing mention of RFC8065.
> [Remy] We would like to extend the description as follows: RFC8065 discusses the privacy threats when interface identifiers (IID) are generated without sufficient entropy, including correlation of activities over time, location tracking, device-specific vulnerability exploitation, and address scanning. Schemes such as limited lease period in DHCPv6 [RFC3315] Cryptographically Generated Addresses (CGAs) [RFC3972], privacy extensions [RFC4941], Hash-Based Addresses (HBAs) [RFC5535], or semantically opaque addresses [RFC7217] SHOULD be considered to enhance the IID privacy. As per RFC8065, when short addresses are used on PLC links, a shared secret key or version number from the Authoritative Border Router Option [RFC6775] can be used to improve the entropy of the hash input, thus the generated IID can be spread out to the full range of the IID address space while stateless address compression is still allowed.
> Do you think it solves the issue?
It's better, yes, but I hope people with more expertise and experience 
with the recommendations than me look closely at it.
>
> Implementors are advised to "look at" RFC8604 when considering building stable addresses, but this document specifies doing things that RFC8604 recommends against (see the use of RFC2464, for example). More discussion seems warranted.
> [Remy] In the same paragraph we reference RFC8604, we limit the usage of MAC generated IID as per RFC2464 in link-local address configuration.

Well, that's my point - I think RFC8064 (sorry for my original typo 
above) recommends NOT to do the things in 2464 that you are saying to 
do. I could be wrong. But having clearer text noting how what you are 
requiring avoids the issues 8064 brings up would help. Again, I hope 
people with more expertise than me look closely here.

>
> There is a short mention of the possibility of acquiring a network encryption key during onboarding but there's no discussion about what that means for these specific layer-2 protocols.
> [Remy] The acquirement of layer-2 encryption key is specified in the IEEE and ITU-T standards and not related to the authentication process in the same paragraph. Thus this phrase is redundant, and we prefer to remove this phrase.
>
>
> Editorial comments:
>
> At section 4.6, the first paragraph can make its point more clearly. All that's needed to say is that the lower layers handle segmentation and reassembly, but the adaptation layer still needs to be ready to do so in the lower layer cant handle the 1280 octet MTU. At the last paragraph, when you say "referring to"
> do you mean "as specified in"?
> [Remy] That's a good point. We would like to simplify the first paragraph of the section 4.6 as follows: PLC MAC layer provides the function of segmentation and reassembly, however, Fragmentation and reassembly is still required at the adaptation layer, if the MAC layer cannot support the minimum MTU demanded by IPv6, which is 1280 octets.
> Yes, we will change it to "as specified in".
>
> At section 7, "For security consideration, link layer security is guaranteed in every PLC technology." needs clarification. Do you mean the three protocols discussed here provide link layer security? Or do you mean to say that if anyone plans to provide an adaptation layer to some other PLC protocol, that it must provide link layer security? Or do you mean something else?
> [Remy] We meant that link layer security mechanisms are designed in these three PLC technologies. We will rephrase it.
> Nit: Expand LLN on first use.
> [Remy] Will update it.
>