Re: [6lo] Roman Danyliw's No Objection on draft-ietf-6lo-fragment-recovery-12: (with COMMENT)

"Pascal Thubert (pthubert)" <pthubert@cisco.com> Tue, 18 February 2020 15:42 UTC

Return-Path: <pthubert@cisco.com>
X-Original-To: 6lo@ietfa.amsl.com
Delivered-To: 6lo@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C7A331208A7; Tue, 18 Feb 2020 07:42:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=Kch39jVt; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=lR6fvbnl
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id POWWYttbNwHK; Tue, 18 Feb 2020 07:41:59 -0800 (PST)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4D7FE120848; Tue, 18 Feb 2020 07:41:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2424; q=dns/txt; s=iport; t=1582040519; x=1583250119; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=l6s+1+7sXiR8qPaZNVmgaQ39pAQryvVirWGqvluij+8=; b=Kch39jVtsOAf+TAL8btVPbuD6xzZzPuCXDqvStC6N6M2XS4Tl9gNy3sO 75xMb/bzXJzCAeKZv6ttLZvpb14BQ37scHSNCk8tGdRKfeJZFiWrTUwh4 V4D11StqoskRwakipibcurRLsbzu+XT48YjUww/1/thRiJ53qgDocbzDu c=;
IronPort-PHdr: =?us-ascii?q?9a23=3A+EQGRhEiOxrp2HXGxgINo51GYnJ96bzpIg4Y7I?= =?us-ascii?q?YmgLtSc6Oluo7vJ1Hb+e4z1Q3SRYuO7fVChqKWqK3mVWEaqbe5+HEZON0pNV?= =?us-ascii?q?cejNkO2QkpAcqLE0r+eeb2bzEwEd5efFRk5Hq8d0NSHZW2ag=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CQBQBhBUxe/40NJK1mHAEBAQEBBwE?= =?us-ascii?q?BEQEEBAEBgXuBVFAFbFggBAsqhBSDRgOKeppwglIDVAkBAQEMAQEjCgIEAQG?= =?us-ascii?q?EQAIXgWwkOBMCAw0BAQUBAQECAQUEbYU3DIVnAgEDEhERDAEBNwEPAgEGAg4?= =?us-ascii?q?MAiYCAgIwFRACBAENDRqDBYJKAy4BAgyQapBnAoE5iGJ1gTKCfwEBBYEzAoN?= =?us-ascii?q?5GIIMAwaBDiqMJBqBQT+BEUeCTD6CZAICGoFLgw4ygiyNbIJ1j3KOS3AKgju?= =?us-ascii?q?WdYJJjGeHLYRJjm2bPgIEAgQFAg4BAQWBaSKBWHAVgydQGA2OHQkaFYM7hRS?= =?us-ascii?q?FP3SBKY9AAQE?=
X-IronPort-AV: E=Sophos;i="5.70,456,1574121600"; d="scan'208";a="431658589"
Received: from alln-core-8.cisco.com ([173.36.13.141]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 18 Feb 2020 15:41:58 +0000
Received: from XCH-RCD-004.cisco.com (xch-rcd-004.cisco.com [173.37.102.14]) by alln-core-8.cisco.com (8.15.2/8.15.2) with ESMTPS id 01IFfwj5005846 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 18 Feb 2020 15:41:58 GMT
Received: from xhs-aln-001.cisco.com (173.37.135.118) by XCH-RCD-004.cisco.com (173.37.102.14) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 18 Feb 2020 09:41:57 -0600
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 18 Feb 2020 09:41:57 -0600
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 18 Feb 2020 09:41:57 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eu57tWBEZVCswzm4N+YfTK/KYd4zCY2IzbwNkQXLKd/ewIaASSZXvPAkpKp1fsh6Cpwkh+sLWPPsQ8D6Gi4kn0LVZ/SKWjFsclan+uxtbUFdV9zPIBeDixagkf67YabcPzSuAKRcCNFIBvFG1wFxF6fzeVDEcfNZD28vd9vSEmhNk9BeZ7hTViai7/gFucQou5eBGeAciAfLKK6L7NGDkW3KCnptT75djSDhVNZB29gBicM//SOnCfypsUiBfYn+4kk98a7quB6SqW0IaZrdUXX+JRqZIHy0gm5t2B3d/GuCYaATR0qZIESLFuVyquJAX7zt4ledYrB5gzTVEkEYyA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6s+1+7sXiR8qPaZNVmgaQ39pAQryvVirWGqvluij+8=; b=OsZecXzTtaP9u5PHR0TgE+gyAhNM1l46jhUjYNUoxISbXETOINAqXYOZMc0mNbo+fBg/+jGg/vNIgnEsB+K+E6XniDHnhipAcq+hUE17NCd2AlpfsX+g+XyUFgYAsapEkQ0ZkclFg+/2C9ZvXFDEJLjnQ1ZHfVVG0tifz0tY56KQaSPZzsU1wsJRnp9QGq0+D0hb+vSbIqgvAQiwuffAksYZZnXNIQ10WzR7blDKl1unNiKIxL8gieEID3WmwSJsZGbKOvt3wEC/K+DCGYrfgGkwAlrylXYhjd5SW1YirxiA4HVQg+t6okclrpp440mO7FqUD7darPc9GxwUGmyD4w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l6s+1+7sXiR8qPaZNVmgaQ39pAQryvVirWGqvluij+8=; b=lR6fvbnlKUOEY4P3vuBZbjJItkpfP7aWJrZ85hDYyQPKS0xCxM3cRRvHkY82wtExp5In5V/dgSz4aN5va1NZRA4ro65JINAubR866pzY0EKnZ7yu/7tWe4eKWhbZjSTSb7OG0zKNKUY9jmg2VentRjuw5NRmSXVUuQ2T1I3Cr/A=
Received: from MN2PR11MB3565.namprd11.prod.outlook.com (20.178.250.159) by MN2PR11MB4709.namprd11.prod.outlook.com (20.180.245.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.24; Tue, 18 Feb 2020 15:41:56 +0000
Received: from MN2PR11MB3565.namprd11.prod.outlook.com ([fe80::edba:2b0f:7341:2c24]) by MN2PR11MB3565.namprd11.prod.outlook.com ([fe80::edba:2b0f:7341:2c24%6]) with mapi id 15.20.2729.032; Tue, 18 Feb 2020 15:41:56 +0000
From: "Pascal Thubert (pthubert)" <pthubert@cisco.com>
To: Roman Danyliw <rdd@cert.org>, The IESG <iesg@ietf.org>
CC: "draft-ietf-6lo-fragment-recovery@ietf.org" <draft-ietf-6lo-fragment-recovery@ietf.org>, Carles Gomez <carlesgo@entel.upc.edu>, "6lo-chairs@ietf.org" <6lo-chairs@ietf.org>, "6lo@ietf.org" <6lo@ietf.org>
Thread-Topic: Roman Danyliw's No Objection on draft-ietf-6lo-fragment-recovery-12: (with COMMENT)
Thread-Index: AQHV5lyMXTqMo78K+kuvbRVTN38rM6ghEMNA
Date: Tue, 18 Feb 2020 15:41:28 +0000
Deferred-Delivery: Tue, 18 Feb 2020 15:41:28 +0000
Message-ID: <MN2PR11MB3565347BEB6F3A978516A007D8110@MN2PR11MB3565.namprd11.prod.outlook.com>
References: <158203129954.14101.12430232892469230181.idtracker@ietfa.amsl.com>
In-Reply-To: <158203129954.14101.12430232892469230181.idtracker@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=pthubert@cisco.com;
x-originating-ip: [2a01:cb15:256:7500:f943:968e:3be3:a08b]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0de4f641-693c-4dd8-8e94-08d7b48915cd
x-ms-traffictypediagnostic: MN2PR11MB4709:
x-microsoft-antispam-prvs: <MN2PR11MB4709B827DF23742EB2981457D8110@MN2PR11MB4709.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3513;
x-forefront-prvs: 031763BCAF
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(396003)(346002)(39860400002)(376002)(199004)(189003)(7696005)(86362001)(54906003)(110136005)(478600001)(966005)(2906002)(6506007)(64756008)(66446008)(66476007)(66556008)(4326008)(186003)(6666004)(8936002)(8676002)(316002)(81156014)(9686003)(55016002)(5660300002)(52536014)(81166006)(71200400001)(76116006)(66946007)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4709; H:MN2PR11MB3565.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: w7cPve52PW5hSlVNksc0ioXLpJkqg4tW+Gy/jYSf+wJCE3yRTlo+SYlM5ZUn5RTE/vOI3w5N6U4tsnxPdso3+ZDjJVYXRyPZYFurcoCPKa/061dBQmqq+SBsfsJoUat/DYjxmocSO2cgKpsNNqUe+pCsqnDc2z7mUT3xYDQ77/PlLcP2h31mv1hTehNehMSAehFwnbw03onPlQWVfEjf0kfC0FKf/sn3q4uBVTlw9fzjpSZfdGaFI6f/iK9nnxTZcADOGIrjUpA+TNnHxGmhw0CnmIa8exfwChyo2EDasihoNyu3HdPVUMjtxOX4RN6105ui+GvzTc8v6VDB+bvYaCjeRDJpCKJA8oHNbO2w537jrWvYw27Ft0s2zx5LcztrVVFnAvZqquSmtRv2i/+AQgISlLcirvT+FNmP99do13ofiLfBs0iGzX9DbMC/bOvbchEOPVtkEQspqeFeZ2roBYyuS+kGGb7OzpE6Oy4QgaMYpK7ZlaewJtZy0ury0EI/jt76JFhXcXrvLSJfPt1ekA==
x-ms-exchange-antispam-messagedata: DeTYflaRbZ+cChvUko34aLq4naOqZe35TgCcX5uwGs1M3PqDFMrMyE9ghJ6SuVcrfn05egmPA85fXis8EFSI9ns6HzthabIXpwHrLzAPgPdYyDTx3PPuzptBUrGwDWL5ZEdlFV+S/yoH5Y5H5KeeGx1362E2GlVE1B9FFefYWx396a3+4Zm9b6rENNhN2JRmbvnHA0VxuB/K5veNSLesRQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0de4f641-693c-4dd8-8e94-08d7b48915cd
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2020 15:41:56.4027 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UzO2nhCe/eFI1mNuk0ai/VY/O9v60Fq1TFjRku5VLqCVf1D0azAwNRKHxsAtcTnyqkhak08hYiA0apN7ivpBNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4709
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.14, xch-rcd-004.cisco.com
X-Outbound-Node: alln-core-8.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/6lo/oPKbKApam38J4pjoW-Me-fey94s>
Subject: Re: [6lo] Roman Danyliw's No Objection on draft-ietf-6lo-fragment-recovery-12: (with COMMENT)
X-BeenThere: 6lo@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Mailing list for the 6lo WG for Internet Area issues in IPv6 over constrained node networks." <6lo.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/6lo>, <mailto:6lo-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/6lo/>
List-Post: <mailto:6lo@ietf.org>
List-Help: <mailto:6lo-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/6lo>, <mailto:6lo-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Feb 2020 15:42:08 -0000

Many thanks for your review, Roman!

Let's see below 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thank you for this easy to read document.
> 
> ** Section 5.1.  Per “There is no requirement on the receiver to check for
> contiguity of the received fragments, and the sender MUST ensure that when
> all fragments are acknowledged, then the datagram is fully received.”, the
> second clause doesn’t parse for me.  What must the sender ensure when all of
> the fragments are acknowledged?

Yes, awkward.  What about simply:
"
    There is no requirement on the receiver to check for contiguity of the
    received fragments. The sender knows that the datagram is fully received 
    when the acknowledged fragments cover the whole datagram.
"


> 
> ** Section 5.1.  Fragment_Size.  If this is a 10-bit unsigned integer and the unit
> is an octet, shouldn’t fragments up to 1024-1 bytes be possible (not 512)?

Oups fixed


> ** Editorial
> 
> -- Section 5.2.  Editorial.
> s/A NULL bitmap that indicates that the …/ A NULL bitmap indicates that the
> …/ s/A FULL bitmap that indicates that the …/ A FULL bitmap indicates that the
> …/
Done

> -- Section 6.1.  Recommend replacing colloquial language – “It inherits … using
> a timer to clean the VRB when the traffic _dries up_”
Does "clean the VRB once the traffic ceases" work?



> -- Section 10.  Typo. s/ot this/to this/
Done : )

Many thanks again Roman!

I posted v13 with the proposed diffs from your review and that of Peter: https://www.ietf.org/rfcdiff?url2=draft-ietf-6lo-fragment-recovery-13 


Pascal