Re: [6tisch] Yatch's review on draft-ietf-6tisch-msf-08 - Re: MSF review

Yasuyuki Tanaka <yasuyuki.tanaka@inria.fr> Sun, 01 December 2019 13:57 UTC

Return-Path: <yasuyuki.tanaka@inria.fr>
X-Original-To: 6tisch@ietfa.amsl.com
Delivered-To: 6tisch@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61A67120090 for <6tisch@ietfa.amsl.com>; Sun, 1 Dec 2019 05:57:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.9
X-Spam-Level:
X-Spam-Status: No, score=-6.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q4z0aqrG_x2z for <6tisch@ietfa.amsl.com>; Sun, 1 Dec 2019 05:57:16 -0800 (PST)
Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D8B5212008C for <6tisch@ietf.org>; Sun, 1 Dec 2019 05:57:15 -0800 (PST)
X-IronPort-AV: E=Sophos;i="5.69,265,1571695200"; d="scan'208";a="414767763"
Received: from wifi-pro-82-073.paris.inria.fr (HELO [128.93.82.73]) ([128.93.82.73]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 01 Dec 2019 14:57:13 +0100
Cc: 6tisch <6tisch@ietf.org>
To: Tengfei Chang <tengfei.chang@gmail.com>
References: <MN2PR11MB35655660E9DF5365BA4A1AD9D84A0@MN2PR11MB3565.namprd11.prod.outlook.com> <36e424c6-f40e-89b1-4cf1-1a25db501d72@inria.fr> <CAAdgstShO4Hpw5VrgakPnXy29Xpj3N77a8gaQ6y+_HkQDV2gRw@mail.gmail.com>
From: Yasuyuki Tanaka <yasuyuki.tanaka@inria.fr>
Message-ID: <2fdd8200-741c-c7a5-2486-1642c03161a7@inria.fr>
Date: Sun, 1 Dec 2019 14:57:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <CAAdgstShO4Hpw5VrgakPnXy29Xpj3N77a8gaQ6y+_HkQDV2gRw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/6tisch/H6H8YaIb5dNHX1Xc6-Mon3XshIg>
Subject: Re: [6tisch] Yatch's review on draft-ietf-6tisch-msf-08 - Re: MSF review
X-BeenThere: 6tisch@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discuss link layer model for Deterministic IPv6 over the TSCH mode of IEEE 802.15.4e, and impacts on RPL and 6LoWPAN such as resource allocation" <6tisch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/6tisch>, <mailto:6tisch-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/6tisch/>
List-Post: <mailto:6tisch@ietf.org>
List-Help: <mailto:6tisch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/6tisch>, <mailto:6tisch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Dec 2019 13:57:19 -0000

Hi Tengfei,

Related to MAX_NUMCELLS, LIM_NUMCELLSUSED_HIGH and LIM_NUMCELLSUSED_LOW 
need to be revisited.

In Section 5.1., these values are used in the following way:

    The counters are used as follows:

    1.  Both NumCellsElapsed and NumCellsUsed are initialized to 0 when
        the node boots.
    2.  When the value of NumCellsElapsed reaches MAX_NUMCELLS:

        *  If NumCellsUsed > LIM_NUMCELLSUSED_HIGH, trigger 6P to add a
           single cell to the preferred parent
        *  If NumCellsUsed < LIM_NUMCELLSUSED_LOW, trigger 6P to remove a
           single cell to the preferred parent
        *  Reset both NumCellsElapsed and NumCellsUsed to 0 and go to
           step 2.

NumCellUsed should have an integer value which is equal to or greater 
than 0. Then, LIM_NUMCELLSUSED_HIGH and LIM_NUMCELLSUSED_LOW should be 
the same type of value. However, these recommended values are expressed 
in percentage, which cannot be compared directly with NumCellsUsed.

    Figure 2 lists MSF Constants and their RECOMMENDED values.

            +------------------------------+-------------------+
            | Name                         | RECOMMENDED value |
            +------------------------------+-------------------+
            | NUM_CH_OFFSET                |       16          |
            | KA_PERIOD                    |        1 min      |
            | LIM_NUMCELLSUSED_HIGH        |       75 %        |
            | LIM_NUMCELLSUSED_LOW         |       25 %        |

A correction would be either replacing NumCellsUsed in Section 5.1 with 
(NumCellsUsed / NumCellsElapse), or removing '%' in Figure 2 with 
changing the recommended values to something which can work with a 
recommended value of MAX_NUMCELLS.

On 11/27/2019 9:05 PM, Tengfei Chang wrote:
>     By the way, the default or recommended value of MAX_NUMCELLS is 8?
>     MAX_NUMCELLS is not listed in Figure 3.
> 
> 
> TC: 8 is just a value in the example, not recommended. For periodic 
> traffic, or traffic load changes slowly, a larger MAX_NUMCELLS is preferred.
> Some proposal for the recommended value of MAX_NUMCELLS: 64 (power of 
> 2), or 100.

Best,
Yatch