Re: [6tisch] RtgDir review: draft-ietf-6tisch-architecture-21.txt

"Andrew G. Malis" <agmalis@gmail.com> Sat, 22 June 2019 16:17 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: 6tisch@ietfa.amsl.com
Delivered-To: 6tisch@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B571D1200A1; Sat, 22 Jun 2019 09:17:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yJdvvyCko5m9; Sat, 22 Jun 2019 09:17:07 -0700 (PDT)
Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB2A2120089; Sat, 22 Jun 2019 09:17:07 -0700 (PDT)
Received: by mail-qt1-x832.google.com with SMTP id h21so10116165qtn.13; Sat, 22 Jun 2019 09:17:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3aU6c5FJP8x5tDjAcQmyaIWH9Ou+dlxdhcol1/gt47M=; b=OHB6dHF3Dqtt3o13c3kzqx0CrZq31kZJXjmkx2b9VGQQ5p5IKrV9ffGkmZtUHaLe1u C8657rbmw9+I0nW7ST2dy74Al/lMBeJ/DtwaPZF3yS7JQa77+N51CagNoKU5+XSVUwwg 3uR4fUrfZ+v6D5LiA+56zuAl95CDraosE9kEnVJ5v8cWLZ/aeiXT31NPWuxRPkiVYwgo 257AIlm+SkTCnWjXIbmbg8ijKfx2wmaUGLXGbVYVBemGzsUpfNNN29/u6x8rNUks5b/Z 2ElXuIV1saMgUaq30p7L6rqINSI6uT+tfCT6iQ627h3IdwhY3hRed3xvC7GJqfJnmmMB cILg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3aU6c5FJP8x5tDjAcQmyaIWH9Ou+dlxdhcol1/gt47M=; b=B0eHmk2+5PfWj4zMyOyA57MTxV3jf4VUuBIB5gOX3S+cRldtgy/Bc2dzL9nKzoC25S SfPo8ZmKWFLtP57itAl8MqexiZhxIxNavw5zFYpm9kn44UnxiM6Y+GgHfbksJ0gox8SE pURKI7J231Aj6DF6gHp5NDppneZDUaBF85re61w0TXe5/5/e48gBoANSJ45r8FtfMeRu 0Fs4tS4gi+j+1lQy2yKoXAbGerU/Zc2aNfW3LD2yLVLzrIX5Exp7oCuQnxuh3XtNh5w4 YD8vq/wnGq1wDFAU80xIyyCTf4fB6ik+H7KLPCuqyBKM8d8ko+y1Lb/LP2t4BN6cDoPo PDig==
X-Gm-Message-State: APjAAAU5gpJK0zJ5XEZHykjhxTo0wZn5xyCgpCSm89qonJYosN9OrPIS DZWxeCbswPRase1SO2z2PvXqM2GcS+0VWpspQaxlrg==
X-Google-Smtp-Source: APXvYqyhR0xW87WRSgR5EwwJsHKzsuop5Z0CW2ZU+oYfuUA8xEj9PVWwlTsvL0oFitJxOCX2E9Z7vvtkQQQAzw/IHMI=
X-Received: by 2002:aed:21c6:: with SMTP id m6mr60309179qtc.173.1561220226275; Sat, 22 Jun 2019 09:17:06 -0700 (PDT)
MIME-Version: 1.0
References: <CAA=duU12f2eqQZsOAkm_LVR63Y1AXgruokm=eH9MVz-+mPZ_jA@mail.gmail.com>
In-Reply-To: <CAA=duU12f2eqQZsOAkm_LVR63Y1AXgruokm=eH9MVz-+mPZ_jA@mail.gmail.com>
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Sat, 22 Jun 2019 12:16:55 -0400
Message-ID: <CAA=duU16Vz58oMerho4fSF+S=zfqu8W0qPG9e02psy7+a+T=ag@mail.gmail.com>
To: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>, 6tisch-chairs@ietf.org
Cc: rtg-dir@ietf.org, draft-ietf-6tisch-architecture.all@ietf.org, 6tisch@ietf.org
Content-Type: multipart/alternative; boundary="00000000000000de52058bebe90d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/6tisch/OZ5tsQC1FTpJk5JXIGNcdPZO3Gc>
Subject: Re: [6tisch] RtgDir review: draft-ietf-6tisch-architecture-21.txt
X-BeenThere: 6tisch@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discuss link layer model for Deterministic IPv6 over the TSCH mode of IEEE 802.15.4e, and impacts on RPL and 6LoWPAN such as resource allocation" <6tisch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/6tisch>, <mailto:6tisch-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/6tisch/>
List-Post: <mailto:6tisch@ietf.org>
List-Help: <mailto:6tisch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/6tisch>, <mailto:6tisch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Jun 2019 16:17:11 -0000

One quick follow-up to my review - I just noticed that while the draft's
intended status (in the draft) is Informational, the Datatracker lists it
as Proposed Standard. The Datatracker should be updated.

Thanks,
Andy

On Fri, Jun 21, 2019 at 5:28 PM Andrew G. Malis <agmalis@gmail.com> wrote:

> Hello,
>
> I have been selected as the Routing Directorate reviewer for this draft.
> The Routing Directorate seeks to review all routing or routing-related
> drafts as they pass through IETF last call and IESG review, and sometimes
> on special request. The purpose of the review is to provide assistance to
> the Routing ADs. For more information about the Routing Directorate, please
> see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
>
> Although these comments are primarily for the use of the Routing ADs, it
> would be helpful if you could consider them along with any other IETF Last
> Call comments that you receive, and strive to resolve them through
> discussion or by updating the draft.
>
> Document: draft-ietf-6tisch-architecture-21.txt
> Reviewer: Andy Malis
> Review Date: 21 June 2019
> IETF LC End Date: 26 June 2019
> Intended Status: Informational
>
> Summary:
>
> I have significant concerns about this document and recommend that the
> Routing ADs discuss these issues further with the authors.
>
> Overall comments:
>
> For this review, I was asked to "Focus on the impact/implications of the
> architecture on routing/forwarding." I will leave minor details such as
> editorial nits to others.
>
> This is a very long and detailed document, and I have no prior experience
> with IEEE 802.15.4, 6lowpan, 6tisch, RPL, and related technologies. To
> prepare for this review I did some basic background reading, such an online
> introduction to IEEE 802.15.4 and RFC 7554. So in this review, I really
> don't feel competent to comments on some of the more technical aspects
> related to those technologies. However, I do feel competent to comment from
> the viewpoint of a naive reader with a general background in routing. As a
> naive reader, I appreciated the introduction to the technology in sections
> 1-3.
>
> The primary editor of this draft is also active in the DetNet working
> group, and leverages the work being done there to support the work in this
> draft. The draft does reference some DetNet technologies that have not yet
> been completely specified to the point where they can be implemented such
> as PREOF (Packet Replication, Elimination and Ordering Functions), although
> such specifications are an expected deliverable in the DetNet WG. So a full
> implementation of this architecture may have to wait for the completion of
> the related DetNet specification work.
>
> With respect to routing and forwarding, this draft builds upon the work
> already done in the 6lowpan WG, such as RPL for routing and 6lowpan header
> compression. It adds the necessary scheduling and time synchronization
> functions needed to support the TSCH aspects of IEEE 802.15.4, which is the
> point of this work. But other than these new aspects, routing and
> forwarding should continue to work to the extent that they work in the
> 6lowpan specifications. My one concern regarding IPv6 forwarding is the use
> of draft-svshah-tsvwg-lln-diffserv-recommendations in section 4.7.2. See my
> major issues below for more on this concern.
>
> Major issues:
>
> I'm concerned with the number of references to individual drafts (even if
> informational) in a major architecture specification, since the rest of the
> work on this technology, including solution documents, will rest on the
> correctness and completeness of the architecture. If these references are
> essential, then I would recommend that publication of the architecture be
> delayed until it's more clear whether these individual drafts will be
> adopted by a WG, and any abandoned individual drafts be removed. Otherwise,
> how can a published architecture depend on unpublished, abandoned work?
> Speaking of which, I note that one of those referenced drafts,
> draft-svshah-tsvwg-lln-diffserv-recommendations, hasn't been updated in
> over four years, and should either be removed or adopted by the 6tisch WG.
> Another, draft-thubert-bier-replication-elimination, hasn't been updated in
> over a year. Is it still alive? At least the remaining individual drafts
> have fairly recent updates.
>
> A related concern is that this draft specifically depends on work to be
> done elsewhere in and outside of the IETF that is currently unchartered
> (see section A.2). Many of the individual drafts discussed in the previous
> paragraph are referenced in this section. To the extent that 6tisch depends
> on this work for its own eventual success, the WG may wish to evaluate if
> there are alternative ways to have the necessary work completed, such as
> using an alternative solution or rechartering the WG to include necessary
> work that looks unlikely to happen elsewhere.
>
> Minor issue:
>
> To the extent that this architecture makes use of centralized control
> mechanisms such as PCE, the security considerations should mention this
> dependency and perhaps have a short discussion of effects on the network if
> connectivity between the centralized controller and the network nodes is
> lost, either due to an outage or a deliberate attack, and how such effects
> could be mitigated.
>
> Thanks,
> Andy
>
>