[6tisch] Iotdir early review of draft-ietf-6tisch-enrollment-enhanced-beacon-05

Carles Gomez via Datatracker <noreply@ietf.org> Thu, 24 October 2019 16:01 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: 6tisch@ietf.org
Delivered-To: 6tisch@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id CD9AA12089D; Thu, 24 Oct 2019 09:01:27 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Carles Gomez via Datatracker <noreply@ietf.org>
To: <Iot-dir@ietf.org>
Cc: 6tisch@ietf.org, draft-ietf-6tisch-enrollment-enhanced-beacon.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.108.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Carles Gomez <carlesgo@entel.upc.edu>
Message-ID: <157193288761.11358.2170640249540995207@ietfa.amsl.com>
Date: Thu, 24 Oct 2019 09:01:27 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/6tisch/QX2TtlBDuKXP_LyXZwkZ3CN5qEo>
Subject: [6tisch] Iotdir early review of draft-ietf-6tisch-enrollment-enhanced-beacon-05
X-BeenThere: 6tisch@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "Discuss link layer model for Deterministic IPv6 over the TSCH mode of IEEE 802.15.4e, and impacts on RPL and 6LoWPAN such as resource allocation" <6tisch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/6tisch>, <mailto:6tisch-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/6tisch/>
List-Post: <mailto:6tisch@ietf.org>
List-Help: <mailto:6tisch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/6tisch>, <mailto:6tisch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Oct 2019 16:01:28 -0000

Reviewer: Carles Gomez
Review result: Ready with Issues

Thanks to the authors for writing this document.

I did not identify technical problems. (There are comments below that do have a
technical side, but the issues might just be editorial.)

There is a number of suggestions provided below, mostly editorial and about

- "IEEE802.15.4" --> "IEEE 802.15.4"
- "Informational Element" --> "Information Element"
- "6tisch" --> "6TiSCH"

Abstract: I'd suggest adding a comma after "In TSCH mode of IEEE STD 802.15.4".

Section 1.
- "As further details" --> "As further detailed"
- Introduce the acronym "EB" the first time that "Enhanced Beacon" appears.
(Then use "EB" thereafter in the document.)

Subsection 1.2.
- After "synchronization of ASN and Join Metric," perhaps you may insert
"carrying" and reorganize a bit the rest of the sentence. - "existance" -->
"existence" - "There are a limited number...". --> "There is a limited
number..." - "... by each router". Perhaps, to give more context, "by each
router in the network".

Subsection 1.3.
- Title: please add ":" after "synchronization".
- Title: capitalize "solicitations" and "advertisements"
- On the first use of RS, RA, NS and NA, please use the expanded form and
introduce the acronym, and use the acronym thereafter. - "consuming a broadcast
aloha slot with unencrypted traffic" appears to be one of the reasons
mentioned, but it is a bit hidden between parenthesis. You may want to
reorganize the sentence to emphasize that this is actually the crucial point. -
Second bullet in the list: did you mean "RA" instead of "Router Soliciation" -
Third bullet in the list: "If it must listen for a RS as well..." Did you mean
"listen for an RA" ?

- It might be nice to close Section 1 by adding something along the lines of
"This document defines...". However, this would not be specific to subsection
1.3. Therefore, some reorganization of Section 1 might improve the document.

Section 2.
- Even if there is a single figure in the whole document, it might be good to
add a figure number and a caption the format for the new IE subtype. - After
the figure, is there a particular reason why the fields of the format are
presented in a different order from the one in the format? - Please add a ":"
after the name of each field and its definition/description. - "this field
indicates the willingness to act as join proxy". Perhaps "the willingness of
the sender to act..."? - "Lower value indicates willing to act as a Join
Proxy..." Perhaps "Lower value indicates greater willingness to act as..." -
"Values range 0 (most willing)..." --> "Values range 0x00 (most willing)..." -
In the figure, one field is called "Join Proxy lower-64". In the text, it has a
different name... - "if the Proxy Address P-flag is set, then the lower 64-bits
of the Join Proxy’s Link Layer address..." Did you mean "link-local" instead of
"Link Layer? - "the layer-2 address of any IPv6 traffic to the originator". Did
you mean "the destination layer-2 address..." ? - "if the P bit is set, then 64
bits (8 bytes) of address are present." I had trouble understanding this
sentence. Please consider rewriting it. - "this is an variable length field"
--> "this is a variable length field".

Section 5.
- "Registry IETF IE Sub-type ID." Please cite RFC 8137 here as well.