Re: [6tisch] WGLC on draft-ietf-6tisch-msf-09

[Tengfei Chang <[e-mail]>]

Yatch,

>    2.  For example, when MAX_NUMTX is set to 256, from NumTx=255 and
--> "..., when MAX_NUMTX is set to 255, ..."

For the whole sentence,

*"when NumTx reaches MAX_NUMTX, both NumTx and NumTxAck MUST be divided by
2*
*For example, when MAX_NUMTX is set to 256, from NumTx=255 and
NumTxAck=127, the counters become NumTx=128 and NumTxAck=64 if one frame is
sent to the parent with an Acknowledgment received."*

In this case, MAX_NUMTX should be set to 256.

Even NumTx is recommended to use 1 byte later,  when comparing NumTx and
MAX_NUMTX, a casting can be applied and doesn't break 1 byte storage of
NumTx.

Tengfei

On Fri, Dec 13, 2019 at 9:57 AM Tengfei Chang <[e-mail]>
wrote:

> Thanks Yatch!  I will have those comments integrated into next version.
>
>
>
> -------- Original message --------
> From: Yasuyuki Tanaka <[e-mail]>
> Date: Fri, Dec 13, 2019, 12:01 AM
> To: Tengfei Chang <[e-mail]>
> Cc: [e-mail], [e-mail]
> Subject: Re: [6tisch] WGLC on draft-ietf-6tisch-msf-09
>
> Hi Tengfei,
>
> Thank you for the updates. The new version addresses my comments. Here
> are a couple of trivial comments:
>
> > (Section 5.1)
> >    The node MUST maintain the following counters for the selected parent
> >    on both negotiated Tx and Rx cells:
>
> To my understanding, we have separate pairs of NumCellsElapsed and
> NumCellsUsed for the negotiated TX cell and the negotiated RX cell. It
> would be better to modify the sentence a little bit like:
>
> --> "The node MUST maintain the following counters for each of the
> negotiated Tx cells, and the negotiated RX cells, that are scheduled
> with the selected parent."
>
> > (Section 5.3)
> >    2.  For example, when MAX_NUMTX is set to 256, from NumTx=255 and
>
> --> "..., when MAX_NUMTX is set to 255, ..."
>
> Best,
> Yatch
>
>

-- 
——————————————————————————————————————

Dr. Tengfei, Chang
Postdoctoral Research Engineer, Inria

www.tchang.org/
——————————————————————————————————————