Re: [AAA-DOCTORS] [Technical Errata Reported] RFC5090 (5115)

Alan DeKok <aland@deployingradius.com> Fri, 15 September 2017 11:13 UTC

Return-Path: <aland@deployingradius.com>
X-Original-To: aaa-doctors@ietfa.amsl.com
Delivered-To: aaa-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 11223133187 for <aaa-doctors@ietfa.amsl.com>; Fri, 15 Sep 2017 04:13:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h9NEOvxFaHMh for <aaa-doctors@ietfa.amsl.com>; Fri, 15 Sep 2017 04:13:26 -0700 (PDT)
Received: from mail.networkradius.com (mail.networkradius.com [62.210.147.122]) by ietfa.amsl.com (Postfix) with ESMTP id 92DA71330C1 for <aaa-doctors@ietf.org>; Fri, 15 Sep 2017 04:13:26 -0700 (PDT)
Received: from [192.168.120.42] (23-233-24-114.cpe.pppoe.ca [23.233.24.114]) by mail.networkradius.com (Postfix) with ESMTPSA id 83502161; Fri, 15 Sep 2017 11:13:25 +0000 (UTC)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alan DeKok <aland@deployingradius.com>
In-Reply-To: <8f535198-cae9-78b1-1c4e-f0ad0b40cd98@cisco.com>
Date: Fri, 15 Sep 2017 07:13:23 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <58EEE559-D99B-4D53-82FD-8E74272F3E39@deployingradius.com>
References: <20170914200740.335AEB80D6B@rfc-editor.org> <8f535198-cae9-78b1-1c4e-f0ad0b40cd98@cisco.com>
To: Benoit Claise <bclaise@cisco.com>, aaa-doctors@ietf.org
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/aaa-doctors/ExiY0hV_-xy9DywR7Mp-jRWMIso>
Subject: Re: [AAA-DOCTORS] [Technical Errata Reported] RFC5090 (5115)
X-BeenThere: aaa-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: AAA Doctors E-mail List <aaa-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/aaa-doctors>, <mailto:aaa-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/aaa-doctors/>
List-Post: <mailto:aaa-doctors@ietf.org>
List-Help: <mailto:aaa-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/aaa-doctors>, <mailto:aaa-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Sep 2017 11:13:29 -0000

  Looks good to me.  An attribute carrying a string 'true' can't be 3 octets in length.

  If we want to be pedantic, Digest-Stale should be:

	>= 3
	<= 7

  Because it can only contain the strings 'true' and 'false'.

  But we don't make that distinction for other attributes.  e.g. Digest-HA1 which is the output of a hash, and should be fixed length.

  I think it's fine to just use ">= 3" here.

> On Sep 15, 2017, at 3:22 AM, Benoit Claise <bclaise@cisco.com>; wrote:
> 
> Dear AAA doctors,
> 
> Let me know what you think.
> 
> Regards, Benoit
> 
> 
> -------- Forwarded Message --------
> Subject:	[Technical Errata Reported] RFC5090 (5115)
> Date:	Thu, 14 Sep 2017 13:07:40 -0700
> From:	RFC Errata System <rfc-editor@rfc-editor.org>;
> To:	baruch@kayote.com, dscreat@dscreat.com, david@kayote.com, dwilli@cisco.com, beckw@t-systems.com, bclaise@cisco.com, warren@kumari.net, lionel.morand@orange.com, stefan.winter@restena.lu
> CC:	denis@ovsienko.info, radext@ietf.org, rfc-editor@rfc-editor.org
> 
> 
> The following errata report has been submitted for RFC5090,
> "RADIUS Extension for Digest Authentication".
> 
> --------------------------------------
> You may review the report below and at:
> 
> http://www.rfc-editor.org/errata/eid5115
> 
> 
> --------------------------------------
> Type: Technical
> Reported by: Denis Ovsienko 
> <denis@ovsienko.info>;
> 
> 
> Section: 3
> 
> Original Text
> -------------
> 3.17.  Digest-Domain Attribute
> [...]
>    Length
>          3
> [...]
> 
> 3.18.  Digest-Stale Attribute
> [...]
>    Length
>          3
> 
> 
> Corrected Text
> --------------
> 3.17.  Digest-Domain Attribute
> [...]
>    Length
>          >= 3
> [...]
> 
> 3.18.  Digest-Stale Attribute
> [...]
>    Length
>          >= 3
> 
> 
> Notes
> -----
> Those two attributes contain string values. All other such attributes in Section 3 uniformly define Length >= 3.
> 
> Instructions:
> -------------
> This erratum is currently posted as "Reported". If necessary, please
> use "Reply All" to discuss whether it should be verified or
> rejected. When a decision is reached, the verifying party  
> can log in to change the status and edit the report, if necessary. 
> 
> --------------------------------------
> RFC5090 (draft-ietf-radext-rfc4590bis-02)
> --------------------------------------
> Title               : RADIUS Extension for Digest Authentication
> Publication Date    : February 2008
> Author(s)           : B. Sterman, D. Sadolevsky, D. Schwartz, D. Williams, W. Beck
> Category            : PROPOSED STANDARD
> Source              : RADIUS EXTensions
> Area                : Operations and Management
> Stream              : IETF
> Verifying Party     : IESG
> .
> 
> 
> _______________________________________________
> AAA-DOCTORS mailing list
> AAA-DOCTORS@ietf.org
> https://www.ietf.org/mailman/listinfo/aaa-doctors