Re: [abfab] AD review of draft-ietf-abfab-aaa-saml-12

Alejandro Pérez Méndez <alex@um.es> Mon, 23 November 2015 19:43 UTC

Return-Path: <alex@um.es>
X-Original-To: abfab@ietfa.amsl.com
Delivered-To: abfab@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92B691ACDCC for <abfab@ietfa.amsl.com>; Mon, 23 Nov 2015 11:43:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.085
X-Spam-Level:
X-Spam-Status: No, score=-3.085 tagged_above=-999 required=5 tests=[BAYES_05=-0.5, HTML_MESSAGE=0.001, MIME_8BIT_HEADER=0.3, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.585, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qTI-gbC1z57y for <abfab@ietfa.amsl.com>; Mon, 23 Nov 2015 11:43:49 -0800 (PST)
Received: from xenon24.um.es (xenon24.um.es [155.54.212.164]) by ietfa.amsl.com (Postfix) with ESMTP id A3FEF1B32FC for <abfab@ietf.org>; Mon, 23 Nov 2015 11:43:48 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by xenon24.um.es (Postfix) with ESMTP id 8A254B925 for <abfab@ietf.org>; Mon, 23 Nov 2015 20:43:45 +0100 (CET)
X-Virus-Scanned: by antispam in UMU at xenon24.um.es
Received: from xenon24.um.es ([127.0.0.1]) by localhost (xenon24.um.es [127.0.0.1]) (amavisd-new, port 10024) with LMTP id H-nfQRHyh33G for <abfab@ietf.org>; Mon, 23 Nov 2015 20:43:45 +0100 (CET)
Received: from [192.168.1.5] (79.109.150.87.dyn.user.ono.com [79.109.150.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: alex) by xenon24.um.es (Postfix) with ESMTPSA id 53165B8F4 for <abfab@ietf.org>; Mon, 23 Nov 2015 20:43:44 +0100 (CET)
To: abfab@ietf.org
References: <564F5D15.3020602@cs.tcd.ie>
From: =?UTF-8?Q?Alejandro_P=c3=a9rez_M=c3=a9ndez?= <alex@um.es>
Message-ID: <56536C6F.3090505@um.es>
Date: Mon, 23 Nov 2015 20:43:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <564F5D15.3020602@cs.tcd.ie>
Content-Type: multipart/alternative; boundary="------------020600020509010309060506"
Archived-At: <http://mailarchive.ietf.org/arch/msg/abfab/llVTit5NTCZH9GXYJMmT2mjIJtY>
Subject: Re: [abfab] AD review of draft-ietf-abfab-aaa-saml-12
X-BeenThere: abfab@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Application Bridging, Federated Authentication Beyond \(the web\)" <abfab.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/abfab>, <mailto:abfab-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/abfab/>
List-Post: <mailto:abfab@ietf.org>
List-Help: <mailto:abfab-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/abfab>, <mailto:abfab-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Nov 2015 19:43:51 -0000

Hi Stephen,

thanks for the review.

> Hiya,
>
> I did my review and have very little to say, which I'm
> sure you'll agree is good:-) A couple of nits is all
> and those are below.
>
> I've asked for IETF LC to be started. And sorry for
> taking a while to get to this.
>
> Cheers,
> S.
>
> - abstract: last sentence is a bit hard to process - I think
> "permit application" isn't very clear, maybe re-word?

Does

    "The use of the artifacts defined in this document
    is not exclusive to ABFAB. They can be applied in any AAA scenario,
    such as the network access control."


sound better?


>
> - ID nits says: " -- Obsolete informational reference (is this
> intentional?): RFC 3588 (Obsoleted by RFC 6733)"

Right. As Klaas said, that was a non-intentional mistake, that I have 
fixed now.

Regards,
Alejandro

>
> _______________________________________________
> abfab mailing list
> abfab@ietf.org
> https://www.ietf.org/mailman/listinfo/abfab