[Ace] Opsdir last call review of draft-ietf-ace-oscore-profile-11

Linda Dunbar via Datatracker <noreply@ietf.org> Mon, 20 July 2020 03:16 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: ace@ietf.org
Delivered-To: ace@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 7DB843A0DD0; Sun, 19 Jul 2020 20:16:17 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Linda Dunbar via Datatracker <noreply@ietf.org>
To: ops-dir@ietf.org
Cc: draft-ietf-ace-oscore-profile.all@ietf.org, ace@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.9.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <159521497745.9074.17834135527258230957@ietfa.amsl.com>
Reply-To: Linda Dunbar <linda.dunbar@futurewei.com>
Date: Sun, 19 Jul 2020 20:16:17 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ace/3mWD2B4ShOGhM0AcIbcs6Olg5SM>
Subject: [Ace] Opsdir last call review of draft-ietf-ace-oscore-profile-11
X-BeenThere: ace@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "Authentication and Authorization for Constrained Environments \(ace\)" <ace.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ace>, <mailto:ace-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ace/>
List-Post: <mailto:ace@ietf.org>
List-Help: <mailto:ace-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ace>, <mailto:ace-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jul 2020 03:16:18 -0000

Reviewer: Linda Dunbar
Review result: Has Nits

I have reviewed this document as part of the Ops area directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written primarily for the benefit of the Ops area directors.
Document editors and WG chairs should treat these comments just like any other
last call comments.

This document describes how to set specific parameters in using  the
Authentication and Authorization for Constrained Environments (ACE) framework
[I-D.ietf-ace-oauth-authz]. The document is written clear, except some minor
issues:

 Section 4.1.1 states that Nonce Parameter must be sent from the client to RS.
 What would be the problem if the client doesn't include the "NONCE"?

Page 12: It asks RFC editor to validate the numbers listed in Figure 7.  There
is no explanation or comments for those values. It will be very difficult for
RFC editor to validate. It seems to me there are 4 columns but  I can't
understand the meaning of the values under 1st, 2nd, and 3rd columns.

it is kind of difficult to validate the correctness by just reading through the
document.  It would be better to have an implementation report of the proposed
"Profile".

Best Regards,
 Linda Dunbar