Re: [Ace] Shepard comments draft-ietf-ace-coap-est-08

"Panos Kampanakis (pkampana)" <pkampana@cisco.com> Mon, 18 February 2019 17:54 UTC

Return-Path: <pkampana@cisco.com>
X-Original-To: ace@ietfa.amsl.com
Delivered-To: ace@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F14FE130F4A; Mon, 18 Feb 2019 09:54:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4GOjGk-vBLQI; Mon, 18 Feb 2019 09:54:00 -0800 (PST)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6A4CD130F3E; Mon, 18 Feb 2019 09:54:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3484; q=dns/txt; s=iport; t=1550512440; x=1551722040; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/1bN70+elKd32Mqu+VJCeEKZLzF+x7WX1sJbuwXOQWU=; b=m71q5X5oo0gvBKG6zRk2CmruDHzdEPPUnNJxwRkafgAD/upx/o6tDpck wXz3K8Ili0NkdbEWsvJ7nD9xzp39HYRu5/t3wzUbHt0tZTdKRVZ9xO2pX U2kgQsRB53I33g4NQ/O8fJO0IGlTFHu19Qq6iv0IjHS+t1q9CVx30g+c9 Q=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAACd8Gpc/4YNJK1jGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBggNngQMnCowWjXKYF4F7CwEBGAuESQK?= =?us-ascii?q?DcCI0CQ0BAwEBAgEBAm0cDIVKAQEBAQIBAQE4NAsFBwQCAQgOAwQBAR8QJws?= =?us-ascii?q?dCAEBBAENBQiDGYFqCA+tJ4opjEQXgUA/g241gx4BAYFLhXYCkEOSdwkChzq?= =?us-ascii?q?LEiGBb4VUg0CHd4pBkXcCERSBJx84gVZwFTuCbAmLFYU/QTEBjxiBHwEB?=
X-IronPort-AV: E=Sophos;i="5.58,385,1544486400"; d="scan'208";a="238913187"
Received: from alln-core-12.cisco.com ([173.36.13.134]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2019 17:53:59 +0000
Received: from XCH-ALN-007.cisco.com (xch-aln-007.cisco.com [173.36.7.17]) by alln-core-12.cisco.com (8.15.2/8.15.2) with ESMTPS id x1IHrxAi029383 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 18 Feb 2019 17:53:59 GMT
Received: from xch-aln-010.cisco.com (173.36.7.20) by XCH-ALN-007.cisco.com (173.36.7.17) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 18 Feb 2019 11:53:58 -0600
Received: from xch-aln-010.cisco.com ([173.36.7.20]) by XCH-ALN-010.cisco.com ([173.36.7.20]) with mapi id 15.00.1395.000; Mon, 18 Feb 2019 11:53:58 -0600
From: "Panos Kampanakis (pkampana)" <pkampana@cisco.com>
To: Jim Schaad <ietf@augustcellars.com>, "draft-ietf-ace-coap-est@ietf.org" <draft-ietf-ace-coap-est@ietf.org>
CC: "ace@ietf.org" <ace@ietf.org>
Thread-Topic: [Ace] Shepard comments draft-ietf-ace-coap-est-08
Thread-Index: AdTGJxPi/a9kQr/bQs2fK2PzxMM1gABfstUQ
Date: Mon, 18 Feb 2019 17:53:58 +0000
Message-ID: <1d372f1e5d94421290646659b9c5899c@XCH-ALN-010.cisco.com>
References: <00fb01d4c631$94657040$bd3050c0$@augustcellars.com>
In-Reply-To: <00fb01d4c631$94657040$bd3050c0$@augustcellars.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.82.171.45]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.36.7.17, xch-aln-007.cisco.com
X-Outbound-Node: alln-core-12.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/ace/JzyzJ__XWSPB9GdOaemlWfKFuSs>
Subject: Re: [Ace] Shepard comments draft-ietf-ace-coap-est-08
X-BeenThere: ace@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Authentication and Authorization for Constrained Environments \(ace\)" <ace.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ace>, <mailto:ace-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ace/>
List-Post: <mailto:ace@ietf.org>
List-Help: <mailto:ace-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ace>, <mailto:ace-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Feb 2019 17:54:03 -0000

Hi Jim,

About 

> 4.  The query in section 5.1 to a resource directory is not correct.  It would not go to /.well-known/core but to /rd-lookup (or what ever name is used by the RD).   If this is not intended to be an RD query, then the sentence about it above can be omitted.  

> 5.  Please remove the "anchor" target attribute from the response from the RD.  I believe that this is no longer required and it is just adding noise without adding value.  If this is intended to be from well-known then it is sufficient to have the anchor but not to  have the authority section in the href.   </est>;rt="ace.est";anchor="coaps://2001:db8::123]:61617"

The text will now read 
~~~~~~~~~~~
Discoverable port numbers can be returned in the payload An example response payload for non-default CoAPS server port 61617 follows below. Linefeeds were included only for readability.

  REQ: GET /.well-known/core?rt=ace.est*

  RES: 2.05 Content
<coap://[2001:db8:3::123]:61617/est>;rt="ace.est", 
<coap://[2001:db8:3::123]:61617/est/crts>;rt="ace.est.crts"; ct="281 TBD287", 
<coap://[2001:db8:3::123]:61617/est/sen>;rt="ace.est.sen";ct="281 TBD287", 
<coap://[2001:db8:3::123]:61617/est/sren>;rt="ace.est.sren";ct="281 TBD287",
<coap://[2001:db8:3::123]:61617/est/att>;rt="ace.est.att";ct="285",
<coap://[2001:db8:3::123]:61617/est/skg>;rt="ace.est.skg";ct="62 280 284 281 TBD287"
~~~~~~~~~~~

What do you think? Does it address your two comments 4 and 5?

Rgs,
Panos

-----Original Message-----
From: Ace <ace-bounces@ietf.org> On Behalf Of Jim Schaad
Sent: Saturday, February 16, 2019 2:56 PM
To: draft-ietf-ace-coap-est@ietf.org
Cc: ace@ietf.org
Subject: [Ace] Shepard comments draft-ietf-ace-coap-est-08

1.  In section 10.1 the last sentence of the first paragraph and the first sentence of the last paragraph duplicate each other.  This should be cleaned up.

2.  Correct the grammar in the first sentence of section 10.2 -  s/registers a new/registers new/

3.  The correct example DNS name is est-coaps.example.org not
est-coaps.example.ietf.org.   Please correct this.  (See RFC 2606)

4.  The query in section 5.1 to a resource directory is not correct.  It would not go to /.well-known/core but to /rd-lookup (or what ever name is
used by the RD).   If this is not intended to be an RD query, then the
sentence about it above can be omitted.  

5.  Please remove the "anchor" target attribute from the response from the RD.  I believe that this is no longer required and it is just adding noise without adding value.  If this is intended to be from well-known then it is sufficient to have the anchor but not to  have the authority section in the href.  

</est>;rt="ace.est";anchor="coaps://2001:db8::123]:61617"

6.  You have registered 282 and 283 as content types, however you also do not define anything that uses these types.  Either some text about the content types needs to exist or potentially the registrations should be abandoned.

7.  There is an outstanding review from Klaus that needs to be addressed.

8.  There is still an open issue dealing with content types.  I have requested that this be added to the agenda for the next CoRE interim meeting.

Jim



_______________________________________________
Ace mailing list
Ace@ietf.org
https://www.ietf.org/mailman/listinfo/ace