Re: [Ace] [ace] Fwd: New Version Notification for draft-tiloca-ace-revoked-token-notification-01.txt

Carsten Bormann <cabo@tzi.org> Mon, 18 May 2020 11:41 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: ace@ietfa.amsl.com
Delivered-To: ace@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 352C93A0B12 for <ace@ietfa.amsl.com>; Mon, 18 May 2020 04:41:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.001
X-Spam-Level:
X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 tests=[SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xbzkeX1r7IvU for <ace@ietfa.amsl.com>; Mon, 18 May 2020 04:40:58 -0700 (PDT)
Received: from gabriel-vm-2.zfn.uni-bremen.de (gabriel-vm-2.zfn.uni-bremen.de [134.102.50.17]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9A5A03A0B10 for <ace@ietf.org>; Mon, 18 May 2020 04:40:58 -0700 (PDT)
Received: from [192.168.217.119] (p548dc699.dip0.t-ipconnect.de [84.141.198.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gabriel-vm-2.zfn.uni-bremen.de (Postfix) with ESMTPSA id 49QcXS2MBWzyY9; Mon, 18 May 2020 13:40:56 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <2553abc4-aa8d-2c51-f0fe-1e14cd6ac1e9@ri.se>
Date: Mon, 18 May 2020 13:40:55 +0200
Cc: Ace Wg <ace@ietf.org>
X-Mao-Original-Outgoing-Id: 611494855.639276-58539704c5245c3e7f3f245e12107661
Content-Transfer-Encoding: quoted-printable
Message-Id: <C7FAF4B1-3CAB-4532-8890-B359BCD36D59@tzi.org>
References: <158378192037.5591.12867128151701682367@ietfa.amsl.com> <2553abc4-aa8d-2c51-f0fe-1e14cd6ac1e9@ri.se>
To: Marco Tiloca <marco.tiloca@ri.se>
X-Mailer: Apple Mail (2.3608.80.23.2.2)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ace/ZoEJ6DulqJQcaMRrOdGkmbeFwwk>
Subject: Re: [Ace] [ace] Fwd: New Version Notification for draft-tiloca-ace-revoked-token-notification-01.txt
X-BeenThere: ace@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Authentication and Authorization for Constrained Environments \(ace\)" <ace.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ace>, <mailto:ace-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ace/>
List-Post: <mailto:ace@ietf.org>
List-Help: <mailto:ace-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ace>, <mailto:ace-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2020 11:41:01 -0000

> 
> Comments are very welcome.

(1) I can’t parse

          the binary
          representation of the String value of ENCODED_TOKEN, which
          would depend on the used charset.

What charset?  JSON does not have a charset.  (I’m probably misreading this.)
What *is* the “String value of ENCODED_TOKEN”?


(2) query parameters: diff=true and N=I are a bit redundant to each other.  If you have N, you need to have diff=true, which therefore can be omitted.  diff=I  or diff  (no equals sign) would therefore be simpler forms of this.


(3) Re CDDL:  I read this as

token-hash = bytes
trl = [* token-hash]
diff-entry = {removed => trl, added => trl}
diff = [* diff-entry]

removed = 0
added = 1

I would simplify diff-entry as a record instead of a struct ( https://tools.ietf.org/html/rfc8610#section-2 ):

diff-entry = [removed: trl, added: trl]

i.e., leave out the labels and rely on the order in the array.

I didn’t make up CDDL for the registration response, as I don’t know what the “…” is.


(4) Why do we need all that precision what was added and removed when?

(5) On the diff stream, please see also STP: 

https://tools.ietf.org/html/draft-bormann-t2trg-stp-03

Grüße, Carsten