Re: [Ace] Roman Danyliw's No Objection on draft-ietf-ace-coap-est-17: (with COMMENT)

Jim Schaad <ietf@augustcellars.com> Fri, 20 December 2019 01:32 UTC

Return-Path: <ietf@augustcellars.com>
X-Original-To: ace@ietfa.amsl.com
Delivered-To: ace@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C39B812008C; Thu, 19 Dec 2019 17:32:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id urpFX7m8Vm-K; Thu, 19 Dec 2019 17:32:38 -0800 (PST)
Received: from mail2.augustcellars.com (augustcellars.com [50.45.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 17F01120044; Thu, 19 Dec 2019 17:32:38 -0800 (PST)
Received: from Jude (73.180.8.170) by mail2.augustcellars.com (192.168.0.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 19 Dec 2019 17:32:31 -0800
From: Jim Schaad <ietf@augustcellars.com>
To: 'Roman Danyliw' <rdd@cert.org>, 'The IESG' <iesg@ietf.org>
CC: draft-ietf-ace-coap-est@ietf.org, ace-chairs@ietf.org, ace@ietf.org
References: <157653372668.24465.13819182999807823012.idtracker@ietfa.amsl.com>
In-Reply-To: <157653372668.24465.13819182999807823012.idtracker@ietfa.amsl.com>
Date: Thu, 19 Dec 2019 17:32:29 -0800
Message-ID: <019b01d5b6d5$59ada860$0d08f920$@augustcellars.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Content-Language: en-us
Thread-Index: AQL6ES2/zSF2Y3SLlxht7KTHZFYyzqV5hUzw
X-Originating-IP: [73.180.8.170]
Archived-At: <https://mailarchive.ietf.org/arch/msg/ace/uAHsf1K7zqiufPcHMQxTg72MbGM>
Subject: Re: [Ace] Roman Danyliw's No Objection on draft-ietf-ace-coap-est-17: (with COMMENT)
X-BeenThere: ace@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Authentication and Authorization for Constrained Environments \(ace\)" <ace.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ace>, <mailto:ace-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ace/>
List-Post: <mailto:ace@ietf.org>
List-Help: <mailto:ace-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ace>, <mailto:ace-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Dec 2019 01:32:41 -0000

A couple of comments below.  See [JLS]

-----Original Message-----
From: Roman Danyliw via Datatracker <noreply@ietf.org> 
Sent: Monday, December 16, 2019 2:02 PM
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-ace-coap-est@ietf.org; Jim Schaad <ietf@augustcellars.com>; ace-chairs@ietf.org; ietf@augustcellars.com; ace@ietf.org
Subject: Roman Danyliw's No Objection on draft-ietf-ace-coap-est-17: (with COMMENT)

Roman Danyliw has entered the following ballot position for
draft-ietf-ace-coap-est-17: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-ace-coap-est/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

* Section 4.  Per “the DTLS connections SHOULD only be kept alive for EST messages that are relatively close to each other”, I think the text means that some EST messages are more likely to occur one after another.  It would be worth being clearer what these would be.

* Section 5.1. Per “These URIs are shorter than the ones in [RFC7030]”, does Table 1 imply that when using EST-coaps the “longer names” from RFC7030 wouldn’t be valid?
[JLS] This is being addressed via Alexey's discuss I think.

* Section 5.2  Per “The latter ones are deemed to expensive …”, was difficult to parse as the sentence prior has three things (instead of two).  Is this sentence referring to the “not specified functions” only?

* Section 5.3, Per “30% smaller payload for DER-encoded ASN.1”, if you can cite this metric, please do.
[JLS] Do you really need a metric on the difference between the size of raw binary vs base6 encoded binary?  It is just 3 bytes vs 4 bytes (i.e  4/3)

* Section 5.8.  Per “In summary, the symmetrically encrypted key is included in the encryptedKey attribute in a KEKRecipientInfo structure”, if this is done in a server-side key generation scenario, where is the client getting the key to decrypt the server computed key material?  Should the DecryptKeyIdentifier/ AsymmetricDecryptKeyIdentifier attributes be populated in the CSR per Sections
4.4.1.1/4.4.1.2 of RFC7030?
[JLS] That would be the discussion of these attributes in paragraph 3 (about the middle)?  Or are you looking for something more?

* Section 10.1.  Per “When server-side key generation is used, the constrained device depends on the server to generate the private key randomly, but it still needs locally generated random numbers for use in security protocols, as explained in Section 12 of [RFC7925].”, is the “security protocols” referenced here anything beyond DTLS?

* Section 10.1.  Per “In such occasions, checking the certificate revocation status or authorizing the client using another method is important for the server to ensure that the client is to be trusted.”

-- does this text suggest that expired+revoked certificates should not be used?
[JLS] Yes, a revoked certificate would most likely not be used.  However, my personal expectation is that this would map more directly to a database associated with the CA as it is possible that the manufacturer could have gone under and not be doing CRLs in any event.

Jim Schaad

-- to word-smith:
s/for the server to ensure that the client is to be trusted/for the server to raise its confidence that the client can be trusted/

* Section 10.1.  Per “More information about recommendations of TLS and DTLS
are included in   [BCP195]”, thanks for referencing BCP195.  Could you please
clarify with normative language if these recommendations SHOULD/MUST be followed?

* Editorial
- Section 4.  Per “Authenticating and negotiating DTLS keys requires resources on low- end endpoints and consumes valuable bandwidth”, I’m not sure this sentence is needed.  Technically, “authenticating and negotiating DTLS keys requires resources” on any endpoint.

- Section 4.
OLD: Given that after a successful enrollment, it is more likely that a new EST transaction will take place after a significant amount of time, NEW: Given that after a successful enrollment, it is more likely that a new EST transaction will not take place for a significant amount of time,

- Section 5.5. Typo.  s/successfull/successful/

- Section 5.8.  s/Such scenarios could be when it is …/Such scenarios apply when it is …/

- Section 5.8.  s/ client, or when the resources/client, when the resources/

- Section 5.8. s/Then the private key/The private key/