[Acme] Genart last call review of draft-ietf-acme-subdomains-04
Reese Enghardt via Datatracker <noreply@ietf.org> Thu, 17 November 2022 01:23 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: acme@ietf.org
Delivered-To: acme@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id D9A82C14F732; Wed, 16 Nov 2022 17:23:36 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Reese Enghardt via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: acme@ietf.org, draft-ietf-acme-subdomains.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 9.0.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <166864821687.27396.11214608162761711249@ietfa.amsl.com>
Reply-To: Reese Enghardt <ietf@tenghardt.net>
Date: Wed, 16 Nov 2022 17:23:36 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/acme/7GI0_gnthMRqhaJCIHiCn1Y5cqI>
Subject: [Acme] Genart last call review of draft-ietf-acme-subdomains-04
X-BeenThere: acme@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Automated Certificate Management Environment <acme.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/acme>, <mailto:acme-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/acme/>
List-Post: <mailto:acme@ietf.org>
List-Help: <mailto:acme-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/acme>, <mailto:acme-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Nov 2022 01:23:37 -0000
Reviewer: Reese Enghardt Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-acme-subdomains-04 Reviewer: Reese Enghardt Review Date: 2022-11-16 IETF LC End Date: 2022-11-21 IESG Telechat date: Not scheduled for a telechat Summary: The document is well-written, clear, and to the point. I only found a few nits with opportunities for clarification. Major issues: None. Minor issues: Section 2: " Fully-Qualified Domain Name (FQDN): This is often just a clear way of saying the same thing as "domain name of a node", as outlined above. However, the term is ambiguous." These two sentences appear to contradict each other - Is the term clear or ambiguous? I suggest removing the word "clear" to simply state how the term is commonly used, and then point out the ambiguity. Section 3: "6. server replies with an updated order object […]" Is this updated order object similar to the "authorization" objects? When it says "authorizations" in step 2, are these also objects? I suggest defining the term "object", e.g., in Section 2, and then double-checking that this term is applied consistency in the document. Nits/editorial comments: Section 4.3: "If the client is unable to fulfill authorizations against parent domain" -> "If the client is unable to fulfill authorizations against a parent domain"
- [Acme] Genart last call review of draft-ietf-acme… Reese Enghardt via Datatracker
- Re: [Acme] Genart last call review of draft-ietf-… Owen Friel (ofriel)
- Re: [Acme] Genart last call review of draft-ietf-… Reese Enghardt
- Re: [Acme] [Last-Call] Genart last call review of… Lars Eggert