Re: [Acme] Secdir last call review of draft-ietf-acme-star-delegation-06

Yaron Sheffer <yaronf.ietf@gmail.com> Thu, 25 March 2021 14:28 UTC

Return-Path: <yaronf.ietf@gmail.com>
X-Original-To: acme@ietfa.amsl.com
Delivered-To: acme@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A466B3A2401; Thu, 25 Mar 2021 07:28:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.364
X-Spam-Level:
X-Spam-Status: No, score=-0.364 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MALFORMED_FREEMAIL=1.734, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dbz-jvhIUBLP; Thu, 25 Mar 2021 07:28:50 -0700 (PDT)
Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C3AB33A23FF; Thu, 25 Mar 2021 07:28:49 -0700 (PDT)
Received: by mail-wr1-x42f.google.com with SMTP id k8so2509156wrc.3; Thu, 25 Mar 2021 07:28:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :references:in-reply-to:mime-version:content-transfer-encoding; bh=CaIeUQkHQvFcx27+SQL1aMQrYc4jR6MITg4Z0kKs3wk=; b=hroWt7JEqGtONLg7atrly8oVdVeeK5KWBXoc4qWmcb+nMvTRV2JsiIRp//uDxDRd8V EcxxztoTOZInPZfDeqSWQcyuw+FfeThDZaS/kw6EfPUQ1tbyNzphIdLNouHjdtvVWfdm W2f4nInIK83VhgX9nMz1EeSv2zJklW4LsAbyxcUhSwIMOXCPQXZDMkEz2RiuhSahDfM9 K5Te0uZoUmprOIbuq2oxrEHIY1SgYWBwhu1oEx1IDLlOz8y7mDIjOKvaGGneECpd9l7O 5B5wiAFP++N/yqi7lE9n9CW3j/D7oJrysnkODxENDZ5Zv8Q6m7E02uEKTVovPBq9+/wb CtOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:date:subject:from:to:cc:message-id :thread-topic:references:in-reply-to:mime-version :content-transfer-encoding; bh=CaIeUQkHQvFcx27+SQL1aMQrYc4jR6MITg4Z0kKs3wk=; b=EDE1or2eH+saTKDqw5+wUgp1LuPx3p9V5hqCigDCM7gyz/NY/re0tGqkx4nZBp/jpw DDLFBBEa32j4eJ8HMQmdkLZxKF+B9alAj/1QgNQ2XVWGjYT2d3cbn6+DvHoz2mFBu1EM iWcdNuHhQ8fsdqw137Jf9KHPloeJMwoJZ51Z6wAQFs7/AlmKe47v6c4hlY8FOAGsGnK1 OALN8X7HzGOkUAwrtyFhbzyJ1vc625QoRH5BzsKaxl2vCwSTi68V9tD/ZFVGBsBWc6aE MZWEuNbaKJqglbdfDXcVR3TqqTrPx42Qz4pRAk0rZqazYLciKaxv05669GCBE4ga1jDg AX/Q==
X-Gm-Message-State: AOAM5323HIMFU/mAfR7wK/jguq0f0SP5JvZVrCAAl573LOknvZsyHsjZ lEc6nExiYC6Oz2HQ9zqHcB0=
X-Google-Smtp-Source: ABdhPJxr4j3E9AJCHQKASLC7NxyeVWgseSY6PmJ9As+n3USO04nYx/CPDtJGCQunVgFi0LjxmgkAeA==
X-Received: by 2002:a5d:4904:: with SMTP id x4mr9223538wrq.69.1616682527218; Thu, 25 Mar 2021 07:28:47 -0700 (PDT)
Received: from [172.26.49.35] (pub-corp-42-8.intuit.com. [91.102.42.8]) by smtp.gmail.com with ESMTPSA id u3sm7846785wrt.82.2021.03.25.07.28.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Mar 2021 07:28:46 -0700 (PDT)
User-Agent: Microsoft-MacOutlook/16.47.21031401
Date: Thu, 25 Mar 2021 16:28:44 +0200
From: Yaron Sheffer <yaronf.ietf@gmail.com>
To: Russ Housley <housley@vigilsec.com>, Thomas Fossati <Thomas.Fossati@arm.com>
CC: "last-call@ietf.org" <last-call@ietf.org>, IETF ACME <acme@ietf.org>
Message-ID: <E4734052-E56F-4321-A3C3-79C38F8DAC96@gmail.com>
Thread-Topic: [Acme] Secdir last call review of draft-ietf-acme-star-delegation-06
References: <161575930310.2025.16866904323712710819@ietfa.amsl.com> <3DDC13CC-4789-459D-9DA2-E023BC372D8C@arm.com> <2FF4DF9C-2CE4-4E88-8334-D2D953E06BD4@gmail.com> <966179D0-B67B-4CDF-9A4C-CF9F0B1D04E2@vigilsec.com> <51B3FE70-67D4-4F6F-8F5D-43182186F55D@arm.com> <D525861A-5B91-47B5-92A1-7C312C514BDA@vigilsec.com>
In-Reply-To: <D525861A-5B91-47B5-92A1-7C312C514BDA@vigilsec.com>
Mime-version: 1.0
Content-type: text/plain; charset="UTF-8"
Content-transfer-encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/acme/NcTrRzaMovmvjb3a1Szy-pUv5_g>
Subject: Re: [Acme] Secdir last call review of draft-ietf-acme-star-delegation-06
X-BeenThere: acme@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Automated Certificate Management Environment <acme.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/acme>, <mailto:acme-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/acme/>
List-Post: <mailto:acme@ietf.org>
List-Help: <mailto:acme-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/acme>, <mailto:acme-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Mar 2021 14:28:55 -0000

Hi Russ,

Please see the remaining open issues from your review - we have reopened the GitHub issues:

https://github.com/yaronf/I-D/issues/139
https://github.com/yaronf/I-D/issues/145
https://github.com/yaronf/I-D/issues/146
https://github.com/yaronf/I-D/issues/147
https://github.com/yaronf/I-D/issues/148

Thanks,
	Yaron


On 3/23/21, 15:26, "Russ Housley" <housley@vigilsec.com> wrote:

    Thomas:

    Thanks for the diff.  The revised structure looks good to me.  Much more clear.

    Russ

    > On Mar 23, 2021, at 5:58 AM, Thomas Fossati <Thomas.Fossati@arm.com> wrote:
    > 
    > Hi Russ,
    > 
    > A quick follow-up to try and close the issues that you could not confirm
    > had been addressed because of the complexity of navigating the markdown
    > diffs.
    > 
    > I have attached the output of rfcdiff, which should give you a more
    > comfortable view over those changes.
    > 
    > On 22/03/2021, 19:30, "Russ Housley" <housley@vigilsec.com> wrote:
    >>   https://github.com/yaronf/I-D/issues/142
    >> 
    >> The restructuring is quire difficult to review in the markdown.  I
    >> cannot be sure this addresses my comment.  That said, the word
    >> "besides" does not appear in the document, so this has probably been
    >> sorted out.
    > 
    > Please see the attached rfcdiff output.
    > 
    >>   https://github.com/yaronf/I-D/issues/144
    >> 
    >> As with issue 142, it is difficult to review in this form, but I think
    >> the concern has been resolved.
    > 
    > Ditto.
    > 
    > Also:
    > 
    >>   https://github.com/yaronf/I-D/issues/150
    >> 
    >> I cannot check this in markdown format.  Please run IDnits.
    > 
    > Done on my local copy and it looks good:
    > 
    > $ idnits draft-ietf-acme-star-delegation-latest.txt
    > Inspecting file draft-ietf-acme-star-delegation-latest.txt
    > 
    > Comment:
    > 
    >   Found 4 lines with non-ASCII characters.
    > 
    > Found 0 errors, 0 warnings, 1 comment.
    > 
    > cheers, t
    > 
    > 
    > 
    > 
    > 
    > 
    > 
    > 
    > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
    > <draft-ietf-acme-star-delegation-latest-from-06.diff.html>_______________________________________________
    > Acme mailing list
    > Acme@ietf.org
    > https://www.ietf.org/mailman/listinfo/acme