Re: [alto] Reviews on draft-gao-alto-fcs-02

Dennis Yu <dennis.yht@gmail.com> Tue, 27 June 2017 16:24 UTC

Return-Path: <dennis.yht@gmail.com>
X-Original-To: alto@ietfa.amsl.com
Delivered-To: alto@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 418F51271DF for <alto@ietfa.amsl.com>; Tue, 27 Jun 2017 09:24:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JS-aYOTDwC6E for <alto@ietfa.amsl.com>; Tue, 27 Jun 2017 09:24:43 -0700 (PDT)
Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 686D8129B9C for <alto@ietf.org>; Tue, 27 Jun 2017 09:24:43 -0700 (PDT)
Received: by mail-it0-x231.google.com with SMTP id v202so3135648itb.1 for <alto@ietf.org>; Tue, 27 Jun 2017 09:24:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GsUfSKz94XOtAbpfBGKGzKvoGwqgt+wIIMTbqcol5Gk=; b=mFDcVmMqvJLCsd4KG2Fe3hiVeq5mIgYBBdtfvxidSVVjGLo1HNCrKtVXlPT3Wt59IG w37WiJ/Fx5Ts+1BYSuWCos3TQzbCgVSo95uLD9ziqr0eGwQ6C/2zD5Lefi/5YEmuEqGW Y+m78Q7n78ECHH+SmceJbVIbkEithZYn2lwfHziasNKBINl7A5LIvrnxNTsQH97lAta7 JP9sgjVKuzuClHsClpO5zwDhP7FPB1u4XMJuuiYtLVZ/FOFMGzLCeh6hp5vGrT2NXrhw ac0FUEh5icKK3bDUlrfaO/YeqZEyq9OGzfyVTZsOUEgXbuf0eRzN7lCZ6X435lZ3+2Cc gw2w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GsUfSKz94XOtAbpfBGKGzKvoGwqgt+wIIMTbqcol5Gk=; b=sHbXlYYABz0kV0QB96gyZjXHqPrdr9QOgHLrETd2mkIYEX76QiVeIVkSImXjPZVmi5 CGd9n/Yj+a/NO8ZKSTDnUPCznBF2eblOJI463GzTlb/aQ/KLKZtvf0p2zEa99mxzIcHR PleOhaeGHPxXOlP6Jk84UOLoOTXz6vmAJsWQ3506aHaB8uxDkxGIv86YhO4NHq/Ps8am OH137xq04E/F0lSgwEQ6zSkns7XVbJY7j/4G25cdiP5JVB3csvdRyJChS2gXHaeTywC1 6VuMffls9VgRk5wdrax8Rg6iIOQt+BtONBHxlfUm1B9hxuRo0YG+IdTZCVSCmLUVEHZf etOg==
X-Gm-Message-State: AKS2vOx0X9J+0++0oVWJ1ItBjuUwNHI0mV4vwKxzxbzMDx0g/LMCZB5q gZSduEeQ/RNBa3WJ3zfehs20NuxaQfvg
X-Received: by 10.36.23.146 with SMTP id 140mr4025599ith.88.1498580682716; Tue, 27 Jun 2017 09:24:42 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.79.159.132 with HTTP; Tue, 27 Jun 2017 09:24:42 -0700 (PDT)
In-Reply-To: <07e102bd-999a-c6b3-de5c-e5f01bc5b924@mails.tsinghua.edu.cn>
References: <07e102bd-999a-c6b3-de5c-e5f01bc5b924@mails.tsinghua.edu.cn>
From: Dennis Yu <dennis.yht@gmail.com>
Date: Wed, 28 Jun 2017 00:24:42 +0800
Message-ID: <CAN-YqX2=qFJOyHAVKSGgzJJjGpuJpca2Kht6w0+bPKNQi2cW5g@mail.gmail.com>
To: Kai Gao <gaok12@mails.tsinghua.edu.cn>
Cc: IETF ALTO <alto@ietf.org>
Content-Type: multipart/alternative; boundary="001a1143776442be7b0552f3819b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/alto/8deIrpVcGnwytJKZxblZebr4sw0>
Subject: Re: [alto] Reviews on draft-gao-alto-fcs-02
X-BeenThere: alto@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Application-Layer Traffic Optimization \(alto\) WG mailing list" <alto.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/alto>, <mailto:alto-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/alto/>
List-Post: <mailto:alto@ietf.org>
List-Help: <mailto:alto-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/alto>, <mailto:alto-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jun 2017 16:24:46 -0000

Dear authors of draft-gao-alto-fcs-02,

Yet another review of draft-gao-alto-fcs-02 :)
Here are some opinions that maybe have some help,

1.
Some inconsistency with draft-ietf-alto-multi-cost-10,

the definition of ReqFilteredCostMap in "multi-cost" section 4.1.2 is as
follows,
(the comments are appended)

    object {
        [CostType cost-type;]
        [CostType multi-cost-types<1..*>;]
        [CostType testable-cost-types<1..*>;]
        [JSONString constraints<0..*>;]
        [JSONString or-constraints<1..*><1..*>;]
        [PIDFilter pids];   //<---- likely a typo
    } ReqFilteredCostMap;

and the extended definition in "fcs" section 3.1.2 is,

    object {
        [CostType cost-type;]
        [CostType multi-cost-types<1..*>;]
        [CostType testable-cost-types<1..*>;]
        [JSONString constraints<0..*>;]
        [JSONString or-constraints<0..*><0..*>;]  //  1 --> 0
        [PIDFilter  pids;]
        [PIDFilter  pid-flows<1..*>;]
    } ReqFilteredCostMap;

also see the definition of ReqEndpointCostMap. Although the difference
between "1" and "0" is tiny, but I think it's better to agree on one
definition.

2.
the definition of FlowCostResponse in section 4.2.5 is as follows,

    object {
        FlowCostMap     flow-cost-map;
        [FlowCostMap    flow-cost-confidences;]
    } FlowCostResponse : ResponseEntityBase;

    object-map {
        FlowId -> JSONValue;
    } FlowCostMap;

Firstly, I'm not sure the "JSONValue" is well-defined. According to RFC7159
section 3, "A JSON value MUST be an object, array, number, or string, or
one of the following three literal names: false null true"

Secondly, I think the "flow-cost-confidences" could have its clear type
definition, maybe

    object-map {
        FlowId -> JSONValue;
    } FlowCostConfidence

Thirdly, I personally think that the cost confidence should better be
defined as a JSON fractional number between 0 to 1.

3.
A missing comma in the example of page 19 (l3-flow-aggr)
Two redundant commas in the example of page 19 (cost-type) and page 10
(dependent-vtags)

4.
The change log of section 2 can be composed as an appendix.

5.
Section 8.2, "Openflow" and "openflow" -> "OpenFlow"

Sincerely,
Dennis Yu

On Tue, Jun 27, 2017 at 9:09 PM, Kai Gao <gaok12@mails.tsinghua.edu.cn>
wrote:

> Dear authors of draft-gao-alto-fcs,
>
> I have roughly reviewed the latest FCS draft. Please see the comments
> below.
>
>
> Regards,
> Kai
>
> Terminology:
>
> sX: section X
> ppX: page X
> pX: paragraph X
> lX: line X
>
> pp3, s1, p1
> l2: scenario -> scenarios
> l3-4: "... the P2P application ..." -> "... P2P applications ..."
>
> pp3, s1
> p2, l2: central -> centralized
> p2 & p3: I think these two paragraphs can benefit from some restructuring
> to
> make the motivations for flow-based query more explicit and also easier to
> read.
>
> pp3, s1, p5
> l1: consider -> describe
> l3: schema -> schemas
>
>
> pp4, s1, p1
> l2: "... 5-tuples of ..." -> Use the explicit form of the 5-tuple: "...
> 5-tuple <ip-protocol, ...>"
> l6: "SHOULD support" -> "supports"
> l7: "to satisfy" -> "and satisfies"
>
> pp5, s3.1.2, p5
> l4: "appeared" -> "appear"
>
> pp6, s3.2
> title: "Extend" -> "Extended"
> p2, l2: "... to measure the cost" -> "... to specify the request"
> p2, l3: "SHOULD" -> "MUST"
> p2, l4: "be" -> "have"
> p2, l5: "format" -> "formats"
> p4, l2: Extra space after "TypedEndpointAddr"
>
> pp6, s3.2.1, p1
> l1: "contain" -> "can be"
> l4: "specified" -> remove it.
> l5: "be conflict" -> "conflict"
> l6: "is conflict" -> "conflicts"
>
> pp7, s3.2.3, p1: Use "Protocol" instead of "protocol" to make it explicit
> that
> it represents the value contained in the query.
>
> pp8
> s3.3.1, p1, l1: Remove "then"
> s3.3.2, p6, l4: "appeared" -> "appear"
> s3.3.3, p1, l2: "exactly" -> "exactly the same"
> s4, title: Example -> Examples
>
> pp14, s4.2.3, p4, l3: "value types" -> "value type"
>
> pp15, s4.2.5.1, p1, l5: ", the servers" -> ". The servers"
>
> pp16, s4.2.5, p3, l3: "TypedHeadreField" -> "TypedHeaderField"
>
>
> _______________________________________________
> alto mailing list
> alto@ietf.org
> https://www.ietf.org/mailman/listinfo/alto
>