[alto] AD review of draft-ietf-alto-xdom-disc

"Mirja Kuehlewind (IETF)" <ietf@kuehlewind.net> Tue, 30 October 2018 17:33 UTC

Return-Path: <ietf@kuehlewind.net>
X-Original-To: alto@ietfa.amsl.com
Delivered-To: alto@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BD83212F1A5; Tue, 30 Oct 2018 10:33:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O-c_yewFGnhT; Tue, 30 Oct 2018 10:33:36 -0700 (PDT)
Received: from wp513.webpack.hosteurope.de (wp513.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8223::]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3A3A21277C8; Tue, 30 Oct 2018 10:33:32 -0700 (PDT)
Received: from 200116b82c89f4002132be06b7c09b88.dip.versatel-1u1.de ([2001:16b8:2c89:f400:2132:be06:b7c0:9b88]); authenticated by wp513.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1gHXtT-0007wI-9f; Tue, 30 Oct 2018 18:33:31 +0100
From: "Mirja Kuehlewind (IETF)" <ietf@kuehlewind.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Message-Id: <633348C4-D59A-4C84-9140-BFE727A06CBB@kuehlewind.net>
Date: Tue, 30 Oct 2018 18:33:25 +0100
Cc: alto@ietf.org
To: draft-ietf-alto-xdom-disc.all@ietf.org
X-Mailer: Apple Mail (2.3445.9.1)
X-bounce-key: webpack.hosteurope.de;ietf@kuehlewind.net;1540920816;fd8cd719;
X-HE-SMSGID: 1gHXtT-0007wI-9f
Archived-At: <https://mailarchive.ietf.org/arch/msg/alto/SkGu6FXHiJPEUV3G23yoH9Q6DuM>
Subject: [alto] AD review of draft-ietf-alto-xdom-disc
X-BeenThere: alto@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Application-Layer Traffic Optimization \(alto\) WG mailing list" <alto.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/alto>, <mailto:alto-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/alto/>
List-Post: <mailto:alto@ietf.org>
List-Help: <mailto:alto-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/alto>, <mailto:alto-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2018 17:33:39 -0000

Hi authors, hi shepherd,

thanks for the well-written document and write-up! I've reviewed the draft and would be ready to start IETF last call any time. However, I will not be able to join the next telechat on Nov 21 and therefore this doc has to wait for final approval for Dec 6 anyway. That means we have plenty of time to start IETF last call and I would prefer to start it after the meeting week! Let me know if there are any concerns about this time line!

While I think the document is ready, I of course still have a couple comments after my review. See below for my comments which are mostly editorial. Feel free to address them or not and update the doc before or after IETF last call accordingly. Just let me know what your plans are!

Thanks!
Mirja

———————————————
Review Comments:

1) There are a few abbreviations that are not spelled out at first occurrence (but later instead). Can you double-check this…? 
(You can also check with the RFC Editor Abbreviations List: 
https://www.rfc-editor.org/materials/abbrev.expansion.txt )

2) This part seems to be twice in the doc

sec 2: "For the remainder of the document, we use the notation:
   IRD_URIS_X = XDOMDISC(X,"ALTO:https“)“

sec 3: "For the remainder of the document, we use the following notation for
   calling the ALTO Cross-Domain Server Discovery Procedure:

      IRD_URIS_X = XDOMDISC(X,"ALTO:https“)“

I guess you can just remove it in sec 2.

3) sec 3: "These error
   conditions have to be reported to the caller in an appropriate way.“
Would you be able to say more here?

4) sec 3.4: "If no IRD URI could be
   found after looking up all domain names from the 3rd and 4th column,
   the procedure terminates unsuccessfully, without producing a result.“
What does this mean for the caller? Or should an empty result rather be returned?

5) section 4: in 4.3 and 4.4 the step to call the ALTO Cross-Domain Server Discovery Procedure and then query the IRD(s) are listed as explicit step while in section 4.1. and 4.2 the same (?) steps are described in text. The way this is represented is a bit confusing. Also given these two first steps are always the same, is it really necessary to describe them separately in each subsection? To be honest, the way it is currently presented I’m a bit confused where the differences are…

6) Appendix A and B: Thanks for moving this part in the appendix. It is absolutely appropriate to have any such information in the appendix. However, please reconsider before final publication if all of this information actually has an achievable value or if some maybe can be removed before final publication. Also for appendix A please consider renaming it.

7) In appendix maybe replace "sk@labpc12“ with something more neutral e.g. „user1“…