Re: [alto] Review of draft-ietf-alto-cost-calendar-02

"Randriamasy, Sabine (Nokia - FR/Nozay)" <sabine.randriamasy@nokia-bell-labs.com> Thu, 03 August 2017 17:30 UTC

Return-Path: <sabine.randriamasy@nokia-bell-labs.com>
X-Original-To: alto@ietfa.amsl.com
Delivered-To: alto@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 15461131FB7; Thu, 3 Aug 2017 10:30:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.921
X-Spam-Level:
X-Spam-Status: No, score=-1.921 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0-y6g5a0d9Ep; Thu, 3 Aug 2017 10:30:13 -0700 (PDT)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0099.outbound.protection.outlook.com [104.47.2.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9342131EBC; Thu, 3 Aug 2017 10:30:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector2-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=B7m9oiD3x1A/TrcG96LT9YZwJ78TzoMtblVU0O5HldQ=; b=WLnQJ8/SHqqEAX9RCv/flA1TREk9m9OQ5NxANCgsEPEyG+3i7zesXTvgvctRMCBRtHWPIELYMGFDcS6D93IyEelN8ReuMsoOaH0of+bp9jmaxRAgXlShZhXsq2UWkR6+PtwbRxEDomGNYBtMUdeXntg9wp+5nB9RtXuIPBIiFGw=
Received: from DB6PR0701MB2454.eurprd07.prod.outlook.com (10.168.75.147) by DB6PR0701MB2136.eurprd07.prod.outlook.com (10.168.58.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.10; Thu, 3 Aug 2017 17:30:10 +0000
Received: from DB6PR0701MB2454.eurprd07.prod.outlook.com ([fe80::7cf1:3a69:c7af:a01e]) by DB6PR0701MB2454.eurprd07.prod.outlook.com ([fe80::7cf1:3a69:c7af:a01e%18]) with mapi id 15.01.1320.010; Thu, 3 Aug 2017 17:30:10 +0000
From: "Randriamasy, Sabine (Nokia - FR/Nozay)" <sabine.randriamasy@nokia-bell-labs.com>
To: Dawn Chan <dawn_chen_f@hotmail.com>, "draft-ietf-alto-cost-calendar@ietf.org" <draft-ietf-alto-cost-calendar@ietf.org>
CC: "alto@ietf.org" <alto@ietf.org>
Thread-Topic: Review of draft-ietf-alto-cost-calendar-02
Thread-Index: AQHS+uoC6HcZZaTHrEWxQs4PEvw97aJxdDRA
Date: Thu, 3 Aug 2017 17:30:10 +0000
Message-ID: <DB6PR0701MB2454DC554DCF91196199B4EB95B10@DB6PR0701MB2454.eurprd07.prod.outlook.com>
References: <HK2PR0401MB1588529A627653EF6F4A15EFB5AF0@HK2PR0401MB1588.apcprd04.prod.outlook.com>
In-Reply-To: <HK2PR0401MB1588529A627653EF6F4A15EFB5AF0@HK2PR0401MB1588.apcprd04.prod.outlook.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [135.245.212.28]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DB6PR0701MB2136; 6:fIYGdvchJdrvw2KwVMETYx/vIy98TzLFKE5k+0dRcqw2qMBxOl5nEizFFpkK6hBy6DOvePGb9GVfcvFx4vEW8toPYhIeT+rD5kFVu+TgwRq/OgpkrgntHlf8jWoV8IzqLmN5B/wJF+PvLDOitatCoqF6m5FZY/Zd51sOwVLR3uNxuOeN8wztpee9I6q3jvMe9kXZt/y4j7K2AxstYlXTw2vbLwHqbUXP8TXwU+fY110Tgei60tIXqrh3Q3VMh2d/TCJXCKNmgsfLdRBfW2gFs7y+G3BwoEWwb4QLhB0VppvD+UbEt86nNjEM0M0YlRLMYMv3ISy+qsicvJQlMsHadQ==; 5:mEb6yzezyboi80VrY3h3DeFZuAaIeweSRmAXi2IR2y9m1HBxqrDFOJnOnSAezLsW5nYGxzXebrV4QDQ1301YzBkxJpayddzn5Q25mq4EB4ipX+xZ/S1GWyu+GjV8J0kOxi/EoOYOh6SBabF2AdD1Gg==; 24:98mpOVJfstfzJl6ssG8vmQ4nV0luy6fUy1qNqNCAip+GWaB5Xo56MdFUthRGicgaDRJ+iDnuQJbcDnQeIEJnN2ZMWZNMTbdiK4PTF+tPrJs=; 7:dNTWubj6KetBM/sCuJqV32/jXGMA/CNWRpdeOM97LlhasQxiV/2ldrygRnY02/7duIYJ3YOfK54CAOkqOffRTjkqSKqNXDUc4jOdbbxgoZsgLccrxY/l5sUdDannk1A64nr1G2pSbKOGjxGsuskczhdTPNUtD9aEE6CihyPJImaLWMWHjPrj1UQqqTxKyuYzpPbRys1iFnbejyq2hWKAMzxWWNjPsGoovVsMWY4tLeY=
x-ms-office365-filtering-correlation-id: 62b18ebb-9954-48a3-27ee-08d4da954a9f
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR0701MB2136;
x-ms-traffictypediagnostic: DB6PR0701MB2136:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=sabine.randriamasy@nokia-bell-labs.com;
x-exchange-antispam-report-test: UriScan:(158342451672863)(194151415913766)(21748063052155);
x-microsoft-antispam-prvs: <DB6PR0701MB2136537F50486B348E7C75CF95B10@DB6PR0701MB2136.eurprd07.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(201703131423075)(201703031522075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123564025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0701MB2136; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0701MB2136;
x-forefront-prvs: 03883BD916
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39840400002)(39860400002)(39850400002)(39400400002)(39410400002)(39450400003)(199003)(377454003)(189002)(101416001)(189998001)(2900100001)(66066001)(5660300001)(54896002)(33656002)(55016002)(99286003)(6436002)(6306002)(7736002)(9686003)(74316002)(97736004)(3660700001)(2906002)(3280700002)(5250100002)(102836003)(790700001)(6116002)(2501003)(3846002)(45080400002)(229853002)(76176999)(54356999)(478600001)(7696004)(39060400002)(25786009)(105586002)(106356001)(86362001)(38730400002)(6246003)(236005)(606006)(230783001)(53546010)(6506006)(4326008)(14454004)(50986999)(8936002)(81166006)(68736007)(8676002)(81156014)(53936002)(53946003)(2950100002)(90052001); DIR:OUT; SFP:1102; SCL:1; SRVR:DB6PR0701MB2136; H:DB6PR0701MB2454.eurprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:0; MX:1; LANG:en;
received-spf: None (protection.outlook.com: nokia-bell-labs.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_DB6PR0701MB2454DC554DCF91196199B4EB95B10DB6PR0701MB2454_"
MIME-Version: 1.0
X-OriginatorOrg: nokia-bell-labs.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2017 17:30:10.1603 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0701MB2136
Archived-At: <https://mailarchive.ietf.org/arch/msg/alto/ZSH5Z1ujBvh4YjQxZLwjPNocXRM>
Subject: Re: [alto] Review of draft-ietf-alto-cost-calendar-02
X-BeenThere: alto@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Application-Layer Traffic Optimization \(alto\) WG mailing list" <alto.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/alto>, <mailto:alto-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/alto/>
List-Post: <mailto:alto@ietf.org>
List-Help: <mailto:alto-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/alto>, <mailto:alto-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2017 17:30:17 -0000

Hello Dawn,

Thank you so much for your additional proof reading of the draft.
Please find my answers inline and let me know if they address your comments.
A revision is in progress and will integrate your feedback.

Thanks
Sabine


From: Dawn Chan [mailto:dawn_chen_f@hotmail.com]
Sent: Wednesday, July 12, 2017 10:37 AM
To: draft-ietf-alto-cost-calendar@ietf.org<mailto:draft-ietf-alto-cost-calendar@ietf.org>
Cc: alto@ietf.org<mailto:alto@ietf.org>
Subject: Review of draft-ietf-alto-cost-calendar-02

Hi authors of cost calendar and all,
I’ve just reviewed the new version of cost calendar and here are some feedbacks.

1. In Section 1 Introduction, “In case the ALTO Cost value changes are predicable over a certain period of time and …”, here the “predicable” should be “predictable”.
[SR     ] done, thanks

2. In Section 2.2.1 ALTO Cost Calendar for all cost modes, “However,Calendars can also represent any metric considered as time-varying by an ALTO Server”. I think this paragraph is discussing about cost mode rather than cost metric, so it might be better is we change the “metric” into “mode”.
[SR     ] I see your point. How about re-phrasing as follows: “However, ALTO Calendars can also represent metrics in other modes and having time-varying values.”

3. In Section 3.1 Calendar attributes in the IRD resources capabilities, when explaining “cost-type-name”, I think it should be “cost-type-names”, it might be a typo.
[SR     ] yes, thanks
4. In Section 3.3 Example IRD with ALTO Cost Calendars,
"http://custom.alto.example.com/calendar/endpointcost/lookup": an endpoint cost map in which in which calendar capabilities are indicated for cost type names: "num-routingcost", "num-latency","num-pathbandwidth", "string-service-status”.
Here one of the “in which” is a typo and should be deleted.
[SR     ] done, thanks

5. In Section 3.3 Example IRD with ALTO Cost Calendars, in the example of IRD, when specifying capabilities of resource "filtered-cost-map-calendar”, the “calendar-attributes” is the following:

"calendar-attributes" : [

              {"cost-type-names" : [ "num-routingcost", "num-pathbandwidth" ],

               "time-interval-size" : "1 hour”,

               "number-of-intervals" : 24

              },

              {"cost-type-names" : "string-service-status”,

               "time-interval-size" : "30 minute”,

               "number-of-intervals" : 48

        }

] // end calendar-attributes



Here the “cost-type-names”: “string-service-status” should be “cost-type-names”: [“string-service-status”] because “cost-type-names” is a JSONArray object. The same to the “cost-type-names” specified in resource “endpoint-cost-calendar-map” in this example.

[SR     ]  Yes, thanks.



Another problem for resource “endpoint-cost-calendar-map” is that

"endpoint-cost-calendar-map" : {

              "uri" : "http://custom.alto.example.com/calendar/endpointcost/lookup”,

              "media-types" : [ "application/alto-endpointcost+json" ],

              "accepts" : [ "application/alto-endpointcostparams+json" ],

              …

              “uses” : [“my-default-network-map"]

}



Here, the “media-types” and “accepts” are not JSONArray objects, so it should be



"endpoint-cost-calendar-map" : {

              "uri" : "http://custom.alto.example.com/calendar/endpointcost/lookup”,

              "media-types" : "application/alto-endpointcost+json",

              "accepts" : "application/alto-endpointcostparams+json",

              …

}

[SR     ]  Yes, thanks.



And an endpoint cost map do not need the dependent network map.

[SR     ]  Yes, thanks.



6. Here are some inconsistency between the definition and example displayed.



 In Section 4.1.2 Calendar extension in Filtered Cost map responses, it extends the response format with an field

 CalendarResponseAttributes calendar-response-attributes <1..*>;



The definition of CalendarResponseAttributes is:

object{

  JSONString    cost-type-names;

  JSONString    calendar-start-time;

  JSONString    time-interval-size;

  JSONNumber    number-of-intervals;

  [JSONNumber   repeated;]      [OPTIONAL]

} CalendarResponseAttributes;

But in the example in Section 4.1.3 “num-intervals” is used instead of “number-of-intervals”. The same typos happened in Section 4.2.3 and Section 4.2.4 (the examples of endpoint cost maps).

[SR     ]  Yes, thanks.  Will harmonize with number-of-intervals



Another point is that, the "cost-type-names” is NOT optional, but the examples in Section 4.1.3 and 4.2.3 doesn’t provide this information. My suggestion is that “cost-type-names” is an OPTIONAL field, for legacy ALTO requests (request which contains only one cost type),

[SR     ]  a suggestion: if a calendar request is done for only one cost type it is preferable to refer to “single cost” requests, because the specification of a calendar for a single metric goes beyond the RFC7285.

the “cost-type-names” is  not necessary. But for multi-cost ALTO request, the “cost-type-names” MUST be provided.

 [SR     ]  Agree with your  suggestion. Indeed in the examples, “cost-type-names” is only present for multi-cost requests. So let’s make it mandatory for multi-cost requests.

And since “cost-type-names” only contains a single value, maybe the name can be changed to “cost-type-name”.

[SR     ]  “cost-type-names” may contain several names if calendar attributes are the same several cost types.  For instance, on IRD section 3.3, a multi-cost request for filtered cost-map may be placed for the cost-types named “num-routingcost” and “num-pathbandwidth”.

Above are some of my ideas, if there is some misunderstanding, please correct.

Wish to here your reply.

[SR     ]  great thanks Dawn, cheers, Sabine

Best Regards,

Dawn