[alto] Another review for draft-ietf-alto-oam-yang-07

Shenshen Chen <shenshen.chen.tj@gmail.com> Sat, 20 May 2023 10:05 UTC

Return-Path: <shenshen.chen.tj@gmail.com>
X-Original-To: alto@ietfa.amsl.com
Delivered-To: alto@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 455BBC151073; Sat, 20 May 2023 03:05:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o8XKbqvk1mT3; Sat, 20 May 2023 03:05:55 -0700 (PDT)
Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 98ADDC15107F; Sat, 20 May 2023 03:05:55 -0700 (PDT)
Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-561b50c1856so56894597b3.0; Sat, 20 May 2023 03:05:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684577154; x=1687169154; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=vDTzBW2WegUGhODCbfRNxyfE2lNYnIPhisqneiFEHSU=; b=BxPEtxyOrknZfgmS4GUXsckgUs2UjDVkrFfTIFBD5qXR7vwTH9IoyYI32+w220VeHk Dwd6jiIZ9LeYsd4omKDB1WjQqpOyuF44e525gw3DRPNiQJODDg+S74VMNG7PrTCfbSwa 8oJH2DPS9j4ZL9fyYEbLYUk6oiw/XO44tJuSIABPfp5ZJNrt6TR8/2mTqhE1a/D4r8LN QQjveJ9APE5wkT8radEm4PAC7j5D5yyrVs+eW3GYix3rZcrWYLPcYQac746EQSgH6wHX WQh6F1ob7nA5fjKrnP+T6bAjtk8sI6h5KhjftgK9d/kXFd5ycZo4Py++AJO5fiahaER8 QYng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684577154; x=1687169154; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vDTzBW2WegUGhODCbfRNxyfE2lNYnIPhisqneiFEHSU=; b=cAgW4zTUI8ieezGWgXxQjPiG7z+V6YQJ/F9y1xJo+GU75TCJdB29KCM0Ck/Lp9Me2H HGPsqJsFi/mHkjWPtzQ7dE4N15gFFIgD+0BfKbCwEe9Rno0s43qn+sM19xIaoV2cqwj5 sBzhBy9Mb21QyrPDTSql7SOs0Ktgy3jnfI+Wzb6GelNMUHIWU4mz1/Asq0ppwxhzmX0O 63+15U8Z7OIOzgPkC0Mx73+TotMCm71982Jb26+frf8yVhmgm0MEjCkxGH/IX4CCTOR6 QmHKvrdhY/3OTLbNZcT3Kep0mZGfdNZoymcaZYP0Vnu057jStkkWYoKzS0MdadG0K/2M LXUQ==
X-Gm-Message-State: AC+VfDyd6pk0GSno2f3/jthA+yJvBBDKk+80DU9tNqJPoH9vK7zO6J6V YmvSgVjvYqwDML6VimBxJN1ydbQnpDAHMkmjReq80fuexq27mg==
X-Google-Smtp-Source: ACHHUZ6v3kNWNkAlLicpjsAdGQS5SfwlAmfV2xmTCfmS3nII2NJus4h8Ret+zWs8ttmlNx6lMd/6DtmKmeEHfeagkH4=
X-Received: by 2002:a0d:fac5:0:b0:55d:8cee:96e9 with SMTP id k188-20020a0dfac5000000b0055d8cee96e9mr4990759ywf.5.1684577154265; Sat, 20 May 2023 03:05:54 -0700 (PDT)
MIME-Version: 1.0
From: Shenshen Chen <shenshen.chen.tj@gmail.com>
Date: Sat, 20 May 2023 18:05:17 +0800
Message-ID: <CAJzLMpOLrGOSg=8DN0HnK56K01kq7ra=DtA0yCK786O-uwYSTQ@mail.gmail.com>
To: draft-ietf-alto-oam-yang@ietf.org
Cc: IETF ALTO <alto@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000e0770005fc1d2e4c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/alto/bpbNv2HA1trqBaE2hWHjpxdEgVQ>
Subject: [alto] Another review for draft-ietf-alto-oam-yang-07
X-BeenThere: alto@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Application-Layer Traffic Optimization \(alto\) WG mailing list" <alto.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/alto>, <mailto:alto-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/alto/>
List-Post: <mailto:alto@ietf.org>
List-Help: <mailto:alto-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/alto>, <mailto:alto-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 20 May 2023 10:05:56 -0000

Hi, all

I wrote a review for draft-ietf-alto-oam-yang-07, following the call for
volunteers from Jordi.
Since I am not confident with my comments, please feel free to ignore them.
The following comments are started with the related part of the draft.

1. The whole draft
It confuses me if this draft claims "a single data model" or "multiple
models".

    Some sentences take a single model:
    * defines a YANG data model (Introduction)
    * Scope of data model (title of Sec 4.1.)
    * The data model (Table 2)

    Some assume multiple models:
    * YANG Data Models (title of this document)
    * The following items are in the scope of the data models (Sec 4.1.)

I prefer a single model (with multiple modules). By the way, there are some
more
"singular and plural" issues, e.g., titles of A.3. and A.5.

2. Figure 1
The description of Figure 1 seems to be ambiguous - it presents
    * Both the server manager and information resource manager will
      report statistics data to performance monitor and logging and
      fault manager.
But Figure 1 shows that Information Resource Manager only reports to
Logging and Fault Manager, rather than both two Managers.

Also, the 2nd paragraph of the description presents
    * The algorithm plugins will register callbacks to the corresponding
      ALTO information resources upon the configuration; ...
But I cannot find the corresponding components in Figure 1
(I assume the "plugin" shown in Figure 1 refers to the 5th paragraph).

3. Sec 5.4.1.
It presents
    * If poll-interval is zero, the ALTO server will not fetch the data
source.
I wonder whether the poll-interval should be allowed to be zero since it
seems cannot work.
If it should, should we define such a mode differently from
proactive/reactive modes?

5. Some relationships/structures are not clear to me
a) The R3 seems to be overlapped with R6 and R7.
And the 'meta' defined in Sec 5.3.3. seems to be overlapped with Sec 6.2.

b) Sec 5.3. presents "Server-level Operation and Management" and
Sec 5.4. presents "Server Configuration Management".
Does it mean the Management (the "M" in "O&M") consists of
server-level management and configuration management?

Clarifying their relationships explicitly would be helpful to me.

And there are some minor comments:
1. Sec 5.1.
    * The container 'alto-server' contains both configuration and
operational data
Use "configurational" to be consistent with "operational".

2. Figure 4
    * IETF ALTO Server Level Subtree Structure (title)
Use "Server-Level" to be consistent with other parts.

3. Sec 5.3.
    * The ALTO server instance contains a set of data nodes server-level
operation
      and management for ALTO that are shown in Figure 4.
It seems a word (e.g. "for") is missing between "nodes" and "server-level
operation".

4. Sec 5.4.3.
    * They declare the Capabilities of the ALTO information resource ...
Use "Capabilities (Section 9.1.3 of [RFC7285])" to make it clear.

5. Sec 5.3.4.
    * All the related configurations are covered by the server listen stack.
Use "ALTO Server Listen Stack" to make it clear.

6. Sec 5.4.2.
    * Each resource entry provides configurations defining how to create or
update an ALTO information resource.
This topic sentence does not mention "remove". Maybe use expressions like
"One can create, update or remove an ALTO information resource by adding,
updating, or removing a resource entry" or some other expressions.

In the end, here is a random thought: is there any concern about the
shutdown, or just assume the ALTO server would never be deliberately shut
down?

Best Regards,
Shenshen

Shenshen Chen

PhD student

Tongji University

_______________________________________________

Email shenshen.chen.tj@gmail.com