Re: [alto] AD review of draft-ietf-alto-cost-calendar-07

"Randriamasy, Sabine (Nokia - FR/Paris-Saclay)" <sabine.randriamasy@nokia-bell-labs.com> Mon, 06 August 2018 14:44 UTC

Return-Path: <sabine.randriamasy@nokia-bell-labs.com>
X-Original-To: alto@ietfa.amsl.com
Delivered-To: alto@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 93B78130E23; Mon, 6 Aug 2018 07:44:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.911
X-Spam-Level:
X-Spam-Status: No, score=-1.911 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n06_WJVJsx8Z; Mon, 6 Aug 2018 07:44:08 -0700 (PDT)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03on0727.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0a::727]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6D0CA127332; Mon, 6 Aug 2018 07:44:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector2-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ODzAhdC3UR5E0+O8UFZsZe66kOuyh+nvfJpPKYVzEG8=; b=A8RBfH53qEaZmlqjVrtIow7oIlgweVKqnw7WCIz1c6md5npNqJbC0iiPyL5+gJGJDyk3RCl+mToPTDDbKF/Fr9oEHi6a0PIP7I+aNi3fwuhJnUi2EOxc6VklJKAtbnOUdJztt8w2jtpJIX6lcY8sccATsJC0XMdl8ocbyTflWAM=
Received: from AM4PR07MB3236.eurprd07.prod.outlook.com (10.171.189.13) by AM4PR07MB3235.eurprd07.prod.outlook.com (10.171.189.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.10; Mon, 6 Aug 2018 14:44:06 +0000
Received: from AM4PR07MB3236.eurprd07.prod.outlook.com ([fe80::7dc7:51e5:be3e:e74d]) by AM4PR07MB3236.eurprd07.prod.outlook.com ([fe80::7dc7:51e5:be3e:e74d%3]) with mapi id 15.20.1038.013; Mon, 6 Aug 2018 14:44:06 +0000
From: "Randriamasy, Sabine (Nokia - FR/Paris-Saclay)" <sabine.randriamasy@nokia-bell-labs.com>
To: "Mirja Kuehlewind (IETF)" <ietf@kuehlewind.net>, "draft-ietf-alto-cost-calendar.all@ietf.org" <draft-ietf-alto-cost-calendar.all@ietf.org>
CC: "alto@ietf.org" <alto@ietf.org>
Thread-Topic: AD review of draft-ietf-alto-cost-calendar-07
Thread-Index: AQHULY+LTZVPNcrXCEa8DFfrK8ugW6SyzHXA
Date: Mon, 6 Aug 2018 14:44:06 +0000
Message-ID: <AM4PR07MB3236D74C4B4B0795FA0BAE8895200@AM4PR07MB3236.eurprd07.prod.outlook.com>
References: <B70C4789-71FC-436F-85DA-3F79D7508D5E@kuehlewind.net>
In-Reply-To: <B70C4789-71FC-436F-85DA-3F79D7508D5E@kuehlewind.net>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [135.245.212.229]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM4PR07MB3235; 6:dUtJ0W2BfK1W5YK0ZKl7vZw/fc+EIC8E7+hzQRYRR6Om2bTu+4i0oM16r7WRKm24uxcDMhFLNWPlVz5e/xDa4CJtmWt+7Z1n7co+VF0A7gCvc6f7j3BLYc9A6YGAKGqswTIjZiczqgyoSjPZBXS7Z4y0H74LcebYtYFz6otWehquA9w24G97YURMuwBZQfhJ/ilaJ/n+2n6lRcPi1JvbliVqhqj+S1AXI3OXd8EoywEacoHCLMPkJyE9uzfKy7i48nUh4qC+ToJ7WsR8YGOuK6/nnUmJF0NCoQa5Uh9Euh4TczEeG99jwO9Ypn539QvB+DY18QZmmCDhUaJYw5002raJx8+mQ+ofA/ELBNo6JKfR2SoBqurMDi1WVwMBhwZUZn3eKvkSpZe3XjOn2wH740IZhVACgTRAJrONdG1dscJeX1/jkAH2scoKwObqmW8xfEYmbqLqUf8vkK8wpBG+7g==; 5:29t8YEvp/v4kF4gsNxF5nXAZv5Q9Wo/fKpqrvmJAdvALi9ptuA0GFZjOTXLtK/EFQDoYSiYDqDBbR8nLIFJGOPkHsGwidco0Wv1C8vbxzPLxxdMCg1idnRV7pbdpe819agQKyvqHvfP8LPgLZeWYldYyAxP5OC6AW9oIJSV0aTQ=; 7:WsJ7ELO+GnSXddu+VEkr7gdv0Ky9hlbrnJU09eff4nwqtH4cbsUip/pvXUuqzEvDPDmjFVbZai7bOmo+yOdmgPojKqc20K8203cEOLJCEhbi9IdvuZKJU0r6WP2OHKuLQJgQxR9o7X0Ik6WH4+vKej+Xvzy4VA9meLQNcSX2a7kEA6WX19ElmDb+yf0H5FR9T8Y7AKYyJJTNv0WOUyJ2PQGSai80kIuvskFtutDY9zPxkQKUsnQD7cHxAIpBtm84
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 5cc1e387-68ff-4b2f-5a7b-08d5fbab0fa6
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7193020); SRVR:AM4PR07MB3235;
x-ms-traffictypediagnostic: AM4PR07MB3235:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=sabine.randriamasy@nokia-bell-labs.com;
x-microsoft-antispam-prvs: <AM4PR07MB323509675EB289659E0DA96695200@AM4PR07MB3235.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(158342451672863)(278428928389397)(192374486261705)(21532816269658);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(11241501184)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM4PR07MB3235; BCL:0; PCL:0; RULEID:; SRVR:AM4PR07MB3235;
x-forefront-prvs: 07562C22DA
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(136003)(39860400002)(376002)(366004)(346002)(53754006)(199004)(189003)(13464003)(6506007)(8936002)(25786009)(11346002)(97736004)(76176011)(53546011)(2906002)(102836004)(86362001)(2900100001)(99286004)(4326008)(110136005)(7696005)(14444005)(256004)(446003)(186003)(74316002)(6246003)(26005)(478600001)(476003)(486006)(66066001)(6116002)(7736002)(305945005)(2501003)(33656002)(6436002)(106356001)(316002)(3846002)(55016002)(53936002)(9686003)(81156014)(68736007)(5250100002)(105586002)(229853002)(14454004)(8676002)(81166006)(5660300001)(90052001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM4PR07MB3235; H:AM4PR07MB3236.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: nokia-bell-labs.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: Cmren+g8Rgm3zX4Ua9Lbc64yLxEoggC6LJPx+fknVPV494xE0KGoaImuNtGzd/t94rRVk4/VF4xTIh2+5i2Z/Ai8Lp4gvMcLUeDYNTRggIzucsPcBmcZQDWYvM2XTBZtCJ2CHD7rhGA73fqh0pUA8nnoMujezQnkyTDVoHtcWPgc7sg2K3hKufwfg5ftv6MzsLXr38XV/b+467bwNkuhJcYzDnSD6bS1ZWWT+DVu+Rr6LlRMHuFrW3vFugPRu3FVDB/bk84/AqDg2ktqRRTXL474eFyXkmTMwHl6YJmvCtgkNzSWA6xIu4MAGMDP21b/Hu5RiJqdQ4AgjieYOx9I/C2Ge//8htjIDqgTjuYNAGo=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: nokia-bell-labs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cc1e387-68ff-4b2f-5a7b-08d5fbab0fa6
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2018 14:44:06.2707 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR07MB3235
Archived-At: <https://mailarchive.ietf.org/arch/msg/alto/lIVoxLAsccwAUj9s2bt5-mtbqHU>
Subject: Re: [alto] AD review of draft-ietf-alto-cost-calendar-07
X-BeenThere: alto@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: "Application-Layer Traffic Optimization \(alto\) WG mailing list" <alto.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/alto>, <mailto:alto-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/alto/>
List-Post: <mailto:alto@ietf.org>
List-Help: <mailto:alto-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/alto>, <mailto:alto-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Aug 2018 14:44:12 -0000

Hello Mirja,

Thanks a lot for your review. We will address the comments and get back to you asap.
Best regards,
Sabine


-----Original Message-----
From: Mirja Kuehlewind (IETF) [mailto:ietf@kuehlewind.net] 
Sent: Monday, August 06, 2018 4:12 PM
To: draft-ietf-alto-cost-calendar.all@ietf.org
Cc: alto@ietf.org
Subject: AD review of draft-ietf-alto-cost-calendar-07

Hi all,

I reviewed this draft and there are a few minor fixes that we need before we can start IETF last call:

1) Please remove the following sentence, or refer to the respective sections instead:
„IANA considerations and security considerations will be completed in
   further versions."

2) Please fix everywhere in the doc:
"Content-Length: TODO“

3) Also please make all occurrences of RFC7285 an actually reference ("[RFC7285]" instead of only „RFC7285“).

4) Then I also have a question about this example in Sec 4.1.2:
"For example: if the "calendar-start-time" member has value "Mon, 30
   Jun 2014 at 00:00:00 GMT" and if the value of member "repeated" is
   equal to 4, it means that the calendar values are the same values on
   Monday, Tuesday, Wednesday and Thursday.  The ALTO Client thus may
   use the same calendar for the next 4 duration periods following
   "calendar-start-time“.“
I think this example only makes sense if also the duration period based on "time-interval-size“ and "number-of-intervals“ with „1 hour“ and „24“ respectively is given, right? Can you please add this here.

And one minor (technical) comment/question that I would like to discuss before we go into IETF last call:
Why is "time-interval-size“ combining the value and unit in one element, instead of e.g. using "time-interval-unit“ and "time-interval-value“? Would that not make the implementation of the parsing much simpler?  

And finally, you use the cost type names "num-routingcost", "num-latency", "num-pathbandwidth" and "string-quality-status“ as well as metrics "routingcost", "latency" and "bandwidthscore" in the examples and say that "The cost types in this example are either specified in the base ALTO
   protocol or may be specified in other drafts see
   [draft-ietf-alto-performance-metrics] or defined in this draft for
   illustrative purposes.“
However, non of these metrics are actually defined in [draft-ietf-alto-performance-metrics], nor are they „defined“ in this doc. Would it maybe make sense to actually use cost types and metrics from [draft-ietf-alto-performance-metrics] in these examples (or remove the reference and provide some kind of definition)?

Given I reviewed the whole doc, also a couple of editorial comments/proposals below (however, I fully leave it to the authors' judgement to apply these or not).

Thanks!
Mirja


————————————————
Other editorial comments:

1) The abstract is quite long. I think if it could be formulated more crisp, it would be easier to read, e.g. see the text in the shepherd write-up

"This document is an extension to the base ALTO protocol (RFC 7785).  It extends the ALTO cost information service such that applications decide not only 'where' to connect, but also 'when'.  This is useful for applications that need to perform bulk data transfer and would like to schedule these transfers during an off-peak hour, for example.“

2) I know that IRD is on the known abbreviation list, maybe still spell it out at first occurrence for the ease of the reader…?

3) As the alto base spec is already published for a while, maybe:
OLD
"IETF is currently standardizing the ALTO protocol which aims at
   providing guidance to overlay applications…“ NEW "The ALTO protocol provides guidance to overlay applications…“

4) Maybe:
OLD
“...for example by deferring backup to night
   during traffic trough.“
NEW
"for example by deferring backups or other background traffic to off-peak hours.“

5) To be inline with previously used wording, maybe OLD „...we expect to further
   gain on storage and on the wire data exchange…“ NEW "we expect to further save network and storage resources…“

6) sec 2.2 "The protocol extension placeholders for an ALTO Calendar are: the
   IRD, the ALTO requests and responses for Cost calendars.“ Not sure I fully understand the word „placeholder“ here, maybe:
„To realize an ALTO Calendar, this document extends the
   IRD, the ALTO requests and responses for Cost calendars.“ ?

Also further
"Extensions are designed to be light and ensure backwards
   compatibility with base protocol ALTO Clients and with other
   extensions.  It uses section 8.3.7...“ What is „it“ here?
Maybe:
„This extension is designed to be light and ensure backwards
   compatibility with base protocol ALTO Clients and with other
   extensions. As recommended, it relies on section 8.3.7…“ ?

7) Sec 4.1.1:
"A Calendar-aware ALTO client supporting single cost type values, as
   specified in RFC7285, MUST provide an array of 1 element:

                          "calendared" : [true];“ This could be stated more clearly e.g.
"A Calendar-aware ALTO client only supporting single cost type values, as
   specified in RFC7285, that aims to request a Calendar MUST provide 
   an array of 1 element:

                          "calendared" : [true];“

8) 4.2.2
"If the value of member "calendared" is equal to 'false' for a given
   requested Cost Type, the ALTO Server must return, for these Cost
   Types, a single cost value as specified in RFC 7285.“ Probably use normative MUST here instead.

9) Probably RFC5246 does not need to be a normative reference for this doc (as it is already normative for RFC7285).