Re: [Anima-signaling] draft-ietf-anima-grasp-04A

"Liubing (Leo)" <leo.liubing@huawei.com> Fri, 11 March 2016 02:34 UTC

Return-Path: <leo.liubing@huawei.com>
X-Original-To: anima-signaling@ietfa.amsl.com
Delivered-To: anima-signaling@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 01EB912DD2F for <anima-signaling@ietfa.amsl.com>; Thu, 10 Mar 2016 18:34:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.222
X-Spam-Level:
X-Spam-Status: No, score=-4.222 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r1BkH72Rqiyq for <anima-signaling@ietfa.amsl.com>; Thu, 10 Mar 2016 18:33:58 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE33E12DFC7 for <anima-signaling@ietf.org>; Thu, 10 Mar 2016 18:33:49 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml703-cah.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CKG05605; Fri, 11 Mar 2016 02:33:47 +0000 (GMT)
Received: from NKGEML413-HUB.china.huawei.com (10.98.56.74) by lhreml703-cah.china.huawei.com (10.201.5.104) with Microsoft SMTP Server (TLS) id 14.3.235.1; Fri, 11 Mar 2016 02:33:45 +0000
Received: from NKGEML514-MBX.china.huawei.com ([fe80::40a8:f0d:c0f3:2ca5]) by NKGEML413-HUB.china.huawei.com ([10.98.56.74]) with mapi id 14.03.0235.001; Fri, 11 Mar 2016 10:33:35 +0800
From: "Liubing (Leo)" <leo.liubing@huawei.com>
To: Brian E Carpenter <brian.e.carpenter@gmail.com>, Anima signaling DT <anima-signaling@ietf.org>
Thread-Topic: [Anima-signaling] draft-ietf-anima-grasp-04A
Thread-Index: AQHReMPmtQj+y7J9n0y3e3GHaF/Kip9TgGyQ
Date: Fri, 11 Mar 2016 02:33:35 +0000
Message-ID: <8AE0F17B87264D4CAC7DE0AA6C406F45C2D4B25D@nkgeml514-mbx.china.huawei.com>
References: <56DE05D2.1070802@gmail.com>
In-Reply-To: <56DE05D2.1070802@gmail.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.111.98.117]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.56E22E8B.0173, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 6dc5bf670d6a0eb8c409bf0e9ae588ea
Archived-At: <http://mailarchive.ietf.org/arch/msg/anima-signaling/OJe2uFGT5pmcJA6jmIWcezWblJo>
Cc: "Joel M. Halpern" <jmh@joelhalpern.com>
Subject: Re: [Anima-signaling] draft-ietf-anima-grasp-04A
X-BeenThere: anima-signaling@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Mailing list for the signaling design team of the ANIMA WG <anima-signaling.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima-signaling>, <mailto:anima-signaling-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima-signaling/>
List-Post: <mailto:anima-signaling@ietf.org>
List-Help: <mailto:anima-signaling-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima-signaling>, <mailto:anima-signaling-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2016 02:34:01 -0000

Hi Brian,

Thanks for the update. I only have a minor comment.

 " It MUST cache the	
   Session ID value and initiator address of each relayed	
   discovery message until the discovery process has ended or	
   timed out.  To prevent loops, it MUST NOT relay a Discovery	
   message which carries a given cached Session ID and initiator	
   address more than once."

I think it is hard for the relays to judge whether the Discovery process has ended/time out. Even the initiator could only do "time out" count (GRASP_DEF_TIMEOUT), not solid judgment of "Discovery end". 
So maybe we also recommend a value of twice the GRASP_DEF_TIMEOUT, just as the Flood Synchronization case.

Best regards,
Bing


> -----Original Message-----
> From: Anima-signaling [mailto:anima-signaling-bounces@ietf.org] On Behalf
> Of Brian E Carpenter
> Sent: Tuesday, March 08, 2016 6:51 AM
> To: Anima signaling DT
> Cc: Joel M. Halpern
> Subject: [Anima-signaling] draft-ietf-anima-grasp-04A
> 
> Hi Design Team, Joel,
> 
> Attached is proposed update to GRASP that hopefully fixes a serious looping
> issue that Joel noticed in the -03 draft.
> 
> The issue was that in a physical topology with 3 or more LANs connected in a
> loop by 3 or more routers, GRASP multicasts (Discovery and Flood Synch
> messages) would have looped until the loop count reached zero.
> 
> The fix was to revert to the 'initiator' field previously included in the -02 draft,
> but with the logic properly worked out this time ;-).
> 
> I've both observed the problem in the -03 version of the prototype code, and
> shown that the fix works in a new -04 version of the code. (I didn't need to
> build a router loop; when the code is set to listen to its own multicasts, it
> simulates an infinite router loop.)
> 
> Co-authors: any comments or objections? I'd like to post this draft during
> this week, as I will be on vacation next week.
> 
> Txt file and diffs attached. I will post the XML to GitHub.
> 
> Regards
>    Brian