IETF Logo Mail Archive

Re: [Anima] Significant nits in draft-ietf-anima-autonomic-control-plane-24

Brian E Carpenter <brian.e.carpenter@gmail.com> Wed, 24 June 2020 02:48 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: anima@ietfa.amsl.com
Delivered-To: anima@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2D9B53A011B; Tue, 23 Jun 2020 19:48:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d2Dospu6oKiJ; Tue, 23 Jun 2020 19:48:10 -0700 (PDT)
Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 86FED3A0112; Tue, 23 Jun 2020 19:48:10 -0700 (PDT)
Received: by mail-pf1-x433.google.com with SMTP id q17so428624pfu.8; Tue, 23 Jun 2020 19:48:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:organization:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/1gRbkIt0Nziy57Qimckr+aSOGK6hgGwiqeReq5ca4A=; b=HhhLBZHEbCOqqJo3nlqcnbzs9Iy6WhP8wM4WsF0OZG1dBf+WIwVVdZlpzB7FOUQpid xdVCwGyVpM/r7/Aw4A7tD5FRZMW2r9rB6O8NqFRR5uMI4gFEmAdwOtgAeaIXH66BShNO 5v7EG8Wd5u5lb6yYLn7Ita1yU3nL33aPoBnCHW/NNmuda82zOd9g/7t5DfhLWYrG1cTG oZ0ri01De7HE1TtoN9dPWgLSIPAWShFnlhfD7Z8D6KPdFPyVaged+BjI0+gAYR3xD0s0 UicSLrvcP4T4xQqwXSAWoZ4UxQ74dZakH1EfdG2Z3i6bK5FUMWRQLlkalZl9vd55cNww 6PPQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/1gRbkIt0Nziy57Qimckr+aSOGK6hgGwiqeReq5ca4A=; b=Nl/D+ji801xAD5ZCNmWntntdlEDTGibbw8378YCBf49IKKtYpiHdLMG7uy6gMuzHxV nXObpG3fvsGYpopg58c9ETwJs2m4PjHzB5KMxz2ztbRkQ8D36xfsrI0UOfof+RLk8XTi mBqwfKZgoe5IsiPiZ5mfC1D/4p52mBuzJiDl4EncYmHuegni1WZAsZsAm3cDqO1XVgsL h9mU78vM+9vecz84WzP2mvUa2WUfC7ERgQfwUz/+4knW52/obcAV8TfbJnIY/a597HVK gaKTNAvcf0PjznAQWfgrXWtl66FKZ6d0xLFyS+1lmmmSPkMLP8Z9pvOOqd5x74U0BRGh JrSA==
X-Gm-Message-State: AOAM5337mRbb2wRK/PHXKqasBkMF8qC7EsdXtpGemZ7TnsyhAGv1NXoi iOtxVXrh73fB228M0KFRyI635tQ+
X-Google-Smtp-Source: ABdhPJw0AlMrzi7mbcIecY9Pz0raCvTDk7Q+zaToLCrS1Irja+KZHN3Gw2Qlrs54XvWxmxtPyX99eA==
X-Received: by 2002:a62:8096:: with SMTP id j144mr4974937pfd.78.1592966889820; Tue, 23 Jun 2020 19:48:09 -0700 (PDT)
Received: from [192.168.178.30] ([118.149.66.243]) by smtp.gmail.com with ESMTPSA id z1sm17850907pfn.178.2020.06.23.19.48.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jun 2020 19:48:09 -0700 (PDT)
To: Anima WG <anima@ietf.org>, draft-ietf-anima-autonomic-control-plane.all@ietf.org
References: <83115a40-b8fe-bc4a-cce4-43c6291ef0ed@gmail.com>
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Organization: University of Auckland
Message-ID: <ddf0f3c4-a319-7059-4255-2ed3b95ab8a6@gmail.com>
Date: Wed, 24 Jun 2020 14:48:03 +1200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <83115a40-b8fe-bc4a-cce4-43c6291ef0ed@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/anima/BzXy3KwMLEybn260bSQDgcLIRh8>
Subject: Re: [Anima] Significant nits in draft-ietf-anima-autonomic-control-plane-24
X-BeenThere: anima@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Autonomic Networking Integrated Model and Approach <anima.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima>, <mailto:anima-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima/>
List-Post: <mailto:anima@ietf.org>
List-Help: <mailto:anima-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima>, <mailto:anima-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jun 2020 02:48:13 -0000

Certified: both these examples are now correct in the -25 draft.

Thanks
   Brian

On 28-Apr-20 13:44, Brian E Carpenter wrote:
> Hi,
> 
> Thanks to Michael Richardson, we have found some important nits in the GRASP examples in the ACP draft. The CDDL syntax is correct, but the examples need to be corrected as below. The errors are in nesting levels within the flood message, and the naming
> of constants.
> 
> The draft is already in "Revised I-D Needed" so this can easily be fixed in the next draft.
> 
> In Figure 3:
> 
> OLD:
> 
>         [M_FLOOD, 12340815, h'fd89b714f3db0000200000064000001', 210000,
>             ["SRV.est", 4, 255 ],
>             [O_IPv6_LOCATOR,
>                  h'fd89b714f3db0000200000064000001', TCP, 443]
>         ]
> 
> NEW:
> 
>         [M_FLOOD, 12340815, h'fd89b714f3db0000200000064000001', 210000,
>            [["SRV.est", 4, 255 ],
>             [O_IPv6_LOCATOR,
>                  h'fd89b714f3db0000200000064000001', IPPROTO_TCP, 443]]
>         ]
> 
> 
> In Figure 5:
> 
> OLD:
> 
>         [M_FLOOD, 12340815, h'fe80000000000000c0011001feef0000', 210000,
>             ["AN_ACP", 4, 1, "IKEv2" ],
>             [O_IPv6_LOCATOR,
>                  h'fe80000000000000c0011001feef0000', UDP, 15000]
>             ["AN_ACP", 4, 1, "DTLS" ],
>             [O_IPv6_LOCATOR,
>                  h'fe80000000000000c0011001feef0000', UDP, 17000]
>         ]
> 
> NEW:
> 
>         [M_FLOOD, 12340815, h'fe80000000000000c0011001feef0000', 210000,
>            [["AN_ACP", 4, 1, "IKEv2" ],
>             [O_IPv6_LOCATOR,
>                  h'fe80000000000000c0011001feef0000', IPPROTO_UDP, 15000]],
>            [["AN_ACP", 4, 1, "DTLS" ],
>             [O_IPv6_LOCATOR,
>                  h'fe80000000000000c0011001feef0000', IPPROTO_UDP, 17000]]
>         ]
> 
> Regards
>    Brian
>

v2.23.0 | Report a Bug | By Email