Re: [Anima] Éric Vyncke's No Objection on draft-ietf-anima-grasp-api-08: (with COMMENT)

Brian E Carpenter <brian.e.carpenter@gmail.com> Tue, 01 December 2020 19:28 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: anima@ietfa.amsl.com
Delivered-To: anima@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 46A433A1475; Tue, 1 Dec 2020 11:28:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zb_cksoUENND; Tue, 1 Dec 2020 11:28:31 -0800 (PST)
Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 150E03A146E; Tue, 1 Dec 2020 11:28:31 -0800 (PST)
Received: by mail-pl1-x636.google.com with SMTP id s2so1702936plr.9; Tue, 01 Dec 2020 11:28:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=F5aC4E5m4gQDQ85nBS/sBLwCU0qRQAhEEuc4d4f5YLg=; b=BDu6+fQXFZfBzAXi69t5uiFojCHMIBzMCV6TfwnHYhD51ITv05o+/J+Fr1qmjrHT1h HNonfGrp+a8PIKK/3Mqyo4pJG8KCYVJPxAeIZwg29Lv+OQAPzuaxfD28PRiaZ8CHXdJc jIaXiO+TuKvX5wT+4AENewSI4osWJnhagTDDbIIMuYe1F/AiYfeKVOrBuU5POBAL4+/u HZNxiwiOfeYAt9Q8nqd2UaJlxlj6yndnjupAKII9C0geFWqHNpdL5WxYdMbQrlpIVu9L jzfUpuj7fkebgsRM4GX+0ZXwQn2JQze/KHQYSL0Fo2ButzHRkVVw+30ru+6xnlLS/WGi S1tA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F5aC4E5m4gQDQ85nBS/sBLwCU0qRQAhEEuc4d4f5YLg=; b=pqvOEuthcPacmEsSKye75uDwS4PShD1hpXhV0VwTlv9NxkqjQ7x7640fegD1KZXSbh P/y64Cnu9Xow3Wl+WEB6VXl674eQ6sOOBEF4qA+ftlF33oPOUn7fMngpy8IYHw/viMPG bAozlLZv8n1Nxn6LUh17RKSIGdallZGrguGDWLEaQ3kuD3blUDbE/f9qbU6Sj4qdQyE0 eBiXRrFzb3XtxYEOMaPovMl4kmuocydXL/6PoCSzo7vjzz//dR5j3ammMTCkqnFtfqXH Al/OPojwdj1iAc37NJ5KD4pRkPzATIN+a48aiUfWw5dIjbqtIiSm80Vv6NREF8KBZyrf VoUA==
X-Gm-Message-State: AOAM533HmhLuyqp/IZQQrDwahLrDzo+qI25DXW7WMbY5MR5pL0g+KSdP 9nTWR+l0PPJEy01dRngnfGqwyWIovB6unw==
X-Google-Smtp-Source: ABdhPJwAqZhl2cAOrrxT46Gn9kAeXlOi9G9MfwPr7bJBHDGfAuXNQ/5JmFJr7PA2SEgHcDrItnL3OA==
X-Received: by 2002:a17:902:8ec4:b029:d7:eb0d:84c0 with SMTP id x4-20020a1709028ec4b02900d7eb0d84c0mr4035280plo.23.1606850910513; Tue, 01 Dec 2020 11:28:30 -0800 (PST)
Received: from [192.168.178.20] ([151.210.131.28]) by smtp.gmail.com with ESMTPSA id p6sm483280pjt.13.2020.12.01.11.28.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Dec 2020 11:28:29 -0800 (PST)
To: =?UTF-8?Q?=c3=89ric_Vyncke?= <evyncke@cisco.com>, The IESG <iesg@ietf.org>
Cc: draft-ietf-anima-grasp-api@ietf.org, anima-chairs@ietf.org, anima@ietf.org, Sheng Jiang <jiangsheng@huawei.com>
References: <160683220837.26332.5741732795874744093@ietfa.amsl.com>
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Message-ID: <b051a6da-6550-b25d-94e2-c5c7f19e9bdc@gmail.com>
Date: Wed, 2 Dec 2020 08:28:26 +1300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <160683220837.26332.5741732795874744093@ietfa.amsl.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/anima/ICK08XlEbU0U-Kjw46WfYDln6Lw>
Subject: Re: [Anima] =?utf-8?q?=C3=89ric_Vyncke=27s_No_Objection_on_draft-iet?= =?utf-8?q?f-anima-grasp-api-08=3A_=28with_COMMENT=29?=
X-BeenThere: anima@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Autonomic Networking Integrated Model and Approach <anima.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima>, <mailto:anima-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima/>
List-Post: <mailto:anima@ietf.org>
List-Help: <mailto:anima-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima>, <mailto:anima-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2020 19:28:32 -0000

On 02-Dec-20 03:16, Éric Vyncke via Datatracker wrote:
...
 
> Please find below one some non-blocking COMMENT points, and one nits. I have
> also request IoT directorate and INT directorate reviews, so, you may expect
> more reviews.

Some of the reviews requested at Last Call never showed up, which is mildly annoying if they're going to show up late.

All your comments are easy to fix, assuming "new ID needed".

Thanks
    Brian

> 
> I hope that this helps to improve the document,
> 
> Regards,
> 
> -éric
> 
> == COMMENTS ==
> 
> -- Section 1 --
> In figure 1, is the "GRASP API Library" identical to the "basic GRASP library"
> mentioned later in the text?
> 
> -- Section 2.1 --
> May I assume that the bulleted list is not exhaustive? Probably worth stating
> "For example, ..." if this is the case.
> 
> -- Section 2.2.1 --
> This whole section looks more like a tutorial than something useful in an IETF
> document ;-) but no problem to leave it. Same applies for section 2.2.2 and
> even to 2.2.3.
> 
> -- Section 2.3.2.2 --
> Should it be specified that the timeout is an *unsigned* integer? Same applies
> for "loop_count" in section 2.3.2.3
> 
> -- Section 2.3 --
> Several occurrences of "returned parameters"... should it better be "returned
> values" ?
> 
> -- Section 2.3.3 --
> "All ASAs must use this call." should it be followed by "before issuing any
> other API calls" ?
> 
> "automatically if an ASA crashes" but what about "graceful termination" ?
> 
> == NITS ==
> 
> -- Section 1 --
> Suggestion move figure 1 earlier in the text to improve readability.
> 
> 
> 
>