Re: [Anima] GRASP M_FLOOD captured from Reggie.py -- could it be wrong?

Brian E Carpenter <brian.e.carpenter@gmail.com> Sun, 13 December 2020 20:31 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: anima@ietfa.amsl.com
Delivered-To: anima@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3CB413A08B0 for <anima@ietfa.amsl.com>; Sun, 13 Dec 2020 12:31:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.199
X-Spam-Level:
X-Spam-Status: No, score=-0.199 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Igbaj6GzwXOD for <anima@ietfa.amsl.com>; Sun, 13 Dec 2020 12:31:56 -0800 (PST)
Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BD06C3A08AE for <anima@ietf.org>; Sun, 13 Dec 2020 12:31:56 -0800 (PST)
Received: by mail-pl1-x634.google.com with SMTP id q4so1794460plr.7 for <anima@ietf.org>; Sun, 13 Dec 2020 12:31:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=obeFY7Qy9tHF/vAUeeBu11UJmV1slb8KdhpxRVK+8ro=; b=c/kwtmaTQExEziM6sl+SBdthYBnsfBiuha3dFyerKIFISyGCaqHSiYJB1AhRVJnz9k aO7HqAwZY7dCoLrReRG7zgniBV0Iobs00DEkXsN9M6pQZN1yUwJEkEKNXudaq9i60p4f /kKYro1t+ZKJBquRhnDJk2uB36UmcsElFSEzEafEveeRk7b3Qdrbdibgv5m5EThZ8Jpc hX/MxtFPj2i96yiTQ63EjTG0E02K4b7/JERj6QXQo+HqypF5lKE4doLI9VuSmtfJpPhY nVAUOhN5h2QBrl1JMDT/KJi4rq+SwZreBMdZW3xP303tf+jAvWiLoQ/htJ/dG0xb9cVB f1sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=obeFY7Qy9tHF/vAUeeBu11UJmV1slb8KdhpxRVK+8ro=; b=ekw3vHvzr5DhGQiG3CjnB2X/jeYVqPaYh02ptOqiXnThnK15c1TubwgF1rcojMJkTW ky703Gkz4CQuv5TUTZdugCiztE9sFv5vQ3tArfs/QDQXEQJGJWuBqfaXcY7ScxGnW8Vh IV8c1gQpY6qlvfCZ8PANR9JAYhGKiNqozUoHCNJGkWbv4UHs8WvufTwg8AGRYIV39uI+ XAup3iQfzEKuHcp9ZDBgSEHVuiE2C/NXtBqpix3LDCt94EvP6tfiJM2Rhe1p6GHnc/33 7WN80mbYTYOw4CI0qug3IOPDxrA9/doBFnQa/52hHJYAzg4EZ/ABwAo6OS/iUQZlQNv5 4r3w==
X-Gm-Message-State: AOAM531E2kiO5qwC4T6lwrlmONcNHR6aQSkVuQVLtFkjIA+Xk1rKHYdq pqmLJWEcuVGqJw7HAeubPnivZa0/3c25Zg==
X-Google-Smtp-Source: ABdhPJwxlxOmBpQfWcXjENc9djyh+jpCCcZFOJcq4MUhkZblRh3d6hi0xfVy7DtT0CrX2x9kIIrLZQ==
X-Received: by 2002:a17:902:c517:b029:d6:e179:2097 with SMTP id o23-20020a170902c517b02900d6e1792097mr19555747plx.70.1607891515622; Sun, 13 Dec 2020 12:31:55 -0800 (PST)
Received: from [172.20.15.112] ([202.134.35.146]) by smtp.gmail.com with ESMTPSA id h8sm17208037pfk.71.2020.12.13.12.31.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Dec 2020 12:31:54 -0800 (PST)
To: Michael Richardson <mcr+ietf@sandelman.ca>, anima@ietf.org
References: <28780.1607888637@localhost>
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Message-ID: <20a41277-59b8-dcae-c1e6-ebe440111840@gmail.com>
Date: Mon, 14 Dec 2020 09:31:49 +1300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <28780.1607888637@localhost>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/anima/MLbkRgfmwdxWeiNNS20F_HyjIA4>
Subject: Re: [Anima] GRASP M_FLOOD captured from Reggie.py -- could it be wrong?
X-BeenThere: anima@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Autonomic Networking Integrated Model and Approach <anima.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima>, <mailto:anima-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima/>
List-Post: <mailto:anima@ietf.org>
List-Help: <mailto:anima-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima>, <mailto:anima-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Dec 2020 20:31:58 -0000

Sorry I'm still on vacation and this takes a bit more care to check than
I can do until I'm home. You could well be right, it's a long time since 
I checked that code against the draft so I could have got it wrong or never
updated it. I think we went round the loop on the CDDL more than once.

We're flying back to Auckland tomorrow, I should be able to check
this on Wed NZ time.

Regards
   Brian

On 14-Dec-20 08:43, Michael Richardson wrote:
> 
> I captured this from Reggie.py (diag output below) a few days ago:
> 
> [9, 3591865773, h'2607F0B0000F000200000000000005F7', 120000,
>     [
>       ["AN_join_registrar", 5, 1, "EST-TLS"],
>       [103, h'2607F0B0000F000200000000000005F7', 6, 80]
>     ]
> ]
> 
> (formatting is mine)
> 
> I'm confused by this.
>     Objective-Name: "AN_join_registrar",
>     objective-flags: 5,
>     loop-count: 1,
>     objective-value: "EST-TLS"
> 
> and then the locator-option starts with 103...?
> 
> I guess I'm still confused by why this is:
>   [ [objective1],[locator2-option], [objective2],[locator2-option],...]
> 
> and not:
>   [ [objective1, locator2-option], [objective2, locator2-option],...]
> 
> or maybe:
>   [ [[objective1], [locator2-option]], [[objective2], [locator2-option]],...]
> 
> 
> given that it says:
> flood-message = [M_FLOOD, session-id, initiator, ttl,
>                 +[objective, (locator-option / [])]]
> 
> so I reviewed RFC8610 so under +[], which is section:
> section 3.2 (Ocurrence). + => "one or more",
> section 3.4 (Array).
> 
> I conclude that I think that Reggie.py is wrong.
> I think that this is the same mistake that we made in BRSKI.
> 
> I am using the code at:
>     commit cf716f69e74041081c3eb93131deefe43baea8bb (HEAD -> master, origin/master, origin/HEAD)
>     Author: Brian E Carpenter <brian.e.carpenter@gmail.com>
>     Date:   Tue Nov 17 12:28:14 2020 +1300
> 
>     Dummy AN-overview for redirect
> 
> 
> The entire packet is captured as test data at:
>   https://github.com/AnimaGUS-minerva/connect/blob/main/src/graspsamples.rs
> 
> what I saw:
> 85                                      # array(5)
>    09                                   # unsigned(9)
>    1A D61785AD                          # unsigned(3591865773)
>    50                                   # bytes(16)
>       2607F0B0000F000200000000000005F7  # "&\a\xF0\xB0\x00\x0F\x00\x02\x00\x00\x00\x00\x00\x00\x05\xF7"
>    1A 0001D4C0                          # unsigned(120000)
>    82                                   # array(2)
>       84                                # array(4)
>          71                             # text(17)
>             414E5F6A6F696E5F726567697374726172 # "AN_join_registrar"
>          05                             # unsigned(5)
>          01                             # unsigned(1)
>          67                             # text(7)
>             4553542D544C53              # "EST-TLS"
>       84                                # array(4)
>          18 67                          # unsigned(103)
>          50                             # bytes(16)
>             2607F0B0000F000200000000000005F7 # "&\a\xF0\xB0\x00\x0F\x00\x02\x00\x00\x00\x00\x00\x00\x05\xF7"
>          06                             # unsigned(6)
>          18 50                          # unsigned(80)
> 
> 
> What I think I should have seen:
> 
> [9, 3591865773, h'2607F0B0000F000200000000000005F7', 120000, [[["AN_join_registrar", 5, 1, "EST-TLS"], [103, h'2607F0B0000F000200000000000005F7', 6, 80]]]]
> 
> 85                                      # array(5)
>    09                                   # unsigned(9)
>    1A D61785AD                          # unsigned(3591865773)
>    50                                   # bytes(16)
>       2607F0B0000F000200000000000005F7  # "&\a\xF0\xB0\x00\x0F\x00\x02\x00\x00\x00\x00\x00\x00\x05\xF7"
>    1A 0001D4C0                          # unsigned(120000)
>    81                                   # array(1)
>       82                                # array(2)
>          84                             # array(4)
>             71                          # text(17)
>                414E5F6A6F696E5F726567697374726172 # "AN_join_registrar"
>             05                          # unsigned(5)
>             01                          # unsigned(1)
>             67                          # text(7)
>                4553542D544C53           # "EST-TLS"
>          84                             # array(4)
>             18 67                       # unsigned(103)
>             50                          # bytes(16)
>                2607F0B0000F000200000000000005F7 # "&\a\xF0\xB0\x00\x0F\x00\x02\x00\x00\x00\x00\x00\x00\x05\xF7"
>             06                          # unsigned(6)
>             18 50                       # unsigned(80)
> 
> 
> 
> --
> Michael Richardson <mcr+IETF@sandelman.ca>   . o O ( IPv6 IøT consulting )
>            Sandelman Software Works Inc, Ottawa and Worldwide
> 
> 
> 
>