IETF Logo Mail Archive

[Anima] Significant nits in draft-ietf-anima-autonomic-control-plane-24

Brian E Carpenter <brian.e.carpenter@gmail.com> Tue, 28 April 2020 01:44 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: anima@ietfa.amsl.com
Delivered-To: anima@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD1FD3A0B59; Mon, 27 Apr 2020 18:44:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3lFMNL8U1pkT; Mon, 27 Apr 2020 18:44:22 -0700 (PDT)
Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 385413A0B52; Mon, 27 Apr 2020 18:44:22 -0700 (PDT)
Received: by mail-pf1-x444.google.com with SMTP id v63so9901310pfb.10; Mon, 27 Apr 2020 18:44:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:organization:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=Fm+5yZIsjwJeBqT4k6VxQ+8a2t1QJaS7L1SkVYNTCqc=; b=jFZCC3Eh1zet28rY5S8toqpAIOheoVXviw7Iaq21AVmxa9Q5ahSyaHRKyptchufq0V 0BC4NhCW6yg+aRn0OqiJLTX57K4tq5807jsP1VGSJdc6DAt/V71eGiJ51hSjIZ5pRvDu ibXiMtWUhGNX4WUOMusbGRjYwVsrnE9HnXYBHr4Ld3yE6k+PSSWLHl/neeuQDAtRcIjS NDVSbu90NvxTAtX1DVe69SVjS2cTV3U/zUeZjTdx8JsflIlD9Tjf5xGYIvpx3fiBiQ83 EA9HT4fIuOv6me31atQRGnPL5hvrfsKY87VrterPgfSSLKbo1ztuhyc6A1QTLPjbSMYU B67w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:organization:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=Fm+5yZIsjwJeBqT4k6VxQ+8a2t1QJaS7L1SkVYNTCqc=; b=RhL2RKeqqxxmuhRlpmdA/BbZJw1vhpBn4qoKKTqfyIlnDlE75A3dgxMl8nHkUDicOf 2CAPHkdXNZfpJg9M57dKlUGWQOZhvAyMSucbmSVnA4rOMk4TicCz9byC6bf7WccegLVh LkbHnzuufM6s7y64VDgyTzSVQwF7LhBwmLMmA6PvTsX1Exc6bgv/TmqarjqNkypUAQwc EXll4wifwRYqxzURRS+dWFzS8t0ocIuhnsDBjfUvTcjlwC/vk+rAJKkovw8h1FRhf/ZA d0dey1zeME+g5dN2//SBE16qx1xQe218FBrvkBM6WA8RbJw+wsMV9fiKt14yidscXElb JnJg==
X-Gm-Message-State: AGi0Puby847zEwPQnhbMk6QaIJA4+R1oIjbDpE0vBOltdCkOQaHFge3C 5lAGFA7tVKztsSZmiA/so08Skz8qy9Q=
X-Google-Smtp-Source: APiQypKzsUPj/Zh+5Kb85tt5uTp/nCGj25X7/JNMpckRB9XyXMiIB1Ti+0Oz9tgmip7nulbfXYcthg==
X-Received: by 2002:a63:1a1e:: with SMTP id a30mr24989846pga.368.1588038261423; Mon, 27 Apr 2020 18:44:21 -0700 (PDT)
Received: from [192.168.178.30] ([165.84.25.143]) by smtp.gmail.com with ESMTPSA id a17sm12994471pfr.24.2020.04.27.18.44.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2020 18:44:20 -0700 (PDT)
To: Anima WG <anima@ietf.org>, draft-ietf-anima-autonomic-control-plane.all@ietf.org
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Organization: University of Auckland
Message-ID: <83115a40-b8fe-bc4a-cce4-43c6291ef0ed@gmail.com>
Date: Tue, 28 Apr 2020 13:44:17 +1200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/anima/ePoLR-OF7hSMxj-NGDpfwJJ_fPk>
Subject: [Anima] Significant nits in draft-ietf-anima-autonomic-control-plane-24
X-BeenThere: anima@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Autonomic Networking Integrated Model and Approach <anima.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima>, <mailto:anima-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima/>
List-Post: <mailto:anima@ietf.org>
List-Help: <mailto:anima-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima>, <mailto:anima-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 01:44:24 -0000

Hi,

Thanks to Michael Richardson, we have found some important nits in the GRASP examples in the ACP draft. The CDDL syntax is correct, but the examples need to be corrected as below. The errors are in nesting levels within the flood message, and the naming
of constants.

The draft is already in "Revised I-D Needed" so this can easily be fixed in the next draft.

In Figure 3:

OLD:

        [M_FLOOD, 12340815, h'fd89b714f3db0000200000064000001', 210000,
            ["SRV.est", 4, 255 ],
            [O_IPv6_LOCATOR,
                 h'fd89b714f3db0000200000064000001', TCP, 443]
        ]

NEW:

        [M_FLOOD, 12340815, h'fd89b714f3db0000200000064000001', 210000,
           [["SRV.est", 4, 255 ],
            [O_IPv6_LOCATOR,
                 h'fd89b714f3db0000200000064000001', IPPROTO_TCP, 443]]
        ]


In Figure 5:

OLD:

        [M_FLOOD, 12340815, h'fe80000000000000c0011001feef0000', 210000,
            ["AN_ACP", 4, 1, "IKEv2" ],
            [O_IPv6_LOCATOR,
                 h'fe80000000000000c0011001feef0000', UDP, 15000]
            ["AN_ACP", 4, 1, "DTLS" ],
            [O_IPv6_LOCATOR,
                 h'fe80000000000000c0011001feef0000', UDP, 17000]
        ]

NEW:

        [M_FLOOD, 12340815, h'fe80000000000000c0011001feef0000', 210000,
           [["AN_ACP", 4, 1, "IKEv2" ],
            [O_IPv6_LOCATOR,
                 h'fe80000000000000c0011001feef0000', IPPROTO_UDP, 15000]],
           [["AN_ACP", 4, 1, "DTLS" ],
            [O_IPv6_LOCATOR,
                 h'fe80000000000000c0011001feef0000', IPPROTO_UDP, 17000]]
        ]

Regards
   Brian

v2.23.0 | Report a Bug | By Email