[Anima] Éric Vyncke's No Objection on draft-ietf-anima-grasp-api-08: (with COMMENT)

Éric Vyncke via Datatracker <noreply@ietf.org> Tue, 01 December 2020 14:16 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: anima@ietf.org
Delivered-To: anima@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 636D43A129D; Tue, 1 Dec 2020 06:16:48 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: =?utf-8?q?=C3=89ric_Vyncke_via_Datatracker?= <noreply@ietf.org>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-anima-grasp-api@ietf.org, anima-chairs@ietf.org, anima@ietf.org, Sheng Jiang <jiangsheng@huawei.com>, jiangsheng@huawei.com
X-Test-IDTracker: no
X-IETF-IDTracker: 7.23.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: =?utf-8?q?=C3=89ric_Vyncke?= <evyncke@cisco.com>
Message-ID: <160683220837.26332.5741732795874744093@ietfa.amsl.com>
Date: Tue, 01 Dec 2020 06:16:48 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/anima/os0p_-JWCzUzJudR7ySsLHU0Nk4>
Subject: [Anima] =?utf-8?q?=C3=89ric_Vyncke=27s_No_Objection_on_draft-iet?= =?utf-8?q?f-anima-grasp-api-08=3A_=28with_COMMENT=29?=
X-BeenThere: anima@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Autonomic Networking Integrated Model and Approach <anima.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima>, <mailto:anima-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima/>
List-Post: <mailto:anima@ietf.org>
List-Help: <mailto:anima-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima>, <mailto:anima-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2020 14:16:48 -0000

Éric Vyncke has entered the following ballot position for
draft-ietf-anima-grasp-api-08: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-anima-grasp-api/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thank you for the work put into this document.

Please find below one some non-blocking COMMENT points, and one nits. I have
also request IoT directorate and INT directorate reviews, so, you may expect
more reviews.

I hope that this helps to improve the document,

Regards,

-éric

== COMMENTS ==

-- Section 1 --
In figure 1, is the "GRASP API Library" identical to the "basic GRASP library"
mentioned later in the text?

-- Section 2.1 --
May I assume that the bulleted list is not exhaustive? Probably worth stating
"For example, ..." if this is the case.

-- Section 2.2.1 --
This whole section looks more like a tutorial than something useful in an IETF
document ;-) but no problem to leave it. Same applies for section 2.2.2 and
even to 2.2.3.

-- Section 2.3.2.2 --
Should it be specified that the timeout is an *unsigned* integer? Same applies
for "loop_count" in section 2.3.2.3

-- Section 2.3 --
Several occurrences of "returned parameters"... should it better be "returned
values" ?

-- Section 2.3.3 --
"All ASAs must use this call." should it be followed by "before issuing any
other API calls" ?

"automatically if an ASA crashes" but what about "graceful termination" ?

== NITS ==

-- Section 1 --
Suggestion move figure 1 earlier in the text to improve readability.