[Apn] Comments on draft-li-apn-ipv6-encap-01

Donald Eastlake <d3e3e3@gmail.com> Tue, 29 March 2022 19:51 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: apn@ietfa.amsl.com
Delivered-To: apn@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 724593A1BAB for <apn@ietfa.amsl.com>; Tue, 29 Mar 2022 12:51:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.858
X-Spam-Level:
X-Spam-Status: No, score=-1.858 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o_l2GxvEysHA for <apn@ietfa.amsl.com>; Tue, 29 Mar 2022 12:51:55 -0700 (PDT)
Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B9DB3A1BA7 for <apn@ietf.org>; Tue, 29 Mar 2022 12:51:55 -0700 (PDT)
Received: by mail-lj1-x232.google.com with SMTP id bn33so24873439ljb.6 for <apn@ietf.org>; Tue, 29 Mar 2022 12:51:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=nFtqxojxMHdVLGK3LGXbHmwOVXhmYT0607elt+q8A5E=; b=Lqg1WMb/BH6MTpdXn5STqn+yBJ7M/qbZQbJhuF8MkrASDtL84wmnTpM/eQUs0kPxpR gPklsULeLx/LYTzuLziu9ou2ib9n0knZkDIQbG00p7r25VqxyHoWe6JMtO3VFie8H+pQ lubtC3hN10zYLHZHGgIoUee8y6cbnIJcDPtU9TmwGi2rjMY2OVskiWYfxxb5x5KcaP4Z q6t6OlDHiRcXUrvAJ6u4jFSDnS5r2A5cpGsKveaLj5DfLT24F5914EEY7q6KpIMYUOsc +QFu1Symp/uOPsOOAExRFMr/oLq9x498lMKjU4z5C+dTRHqniRfWGvHfb8BDUf3om+sM Rs1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=nFtqxojxMHdVLGK3LGXbHmwOVXhmYT0607elt+q8A5E=; b=a8pR6Qu2GjUKjn53Uw3wLMYd4srykxFHKkqfzw77J9EHM4HD6KgmNPlU5QWE9UbF5D /cjKhK2ezpNuRvyIl+H2l3nCx7TswY+E7KuO0UkLR14cT/Z7fCOTa/3wZmXLE8ozjz1e Y7lhEHKS9mj6ybTAcX+znKKbdz6dId2lZ6sslTG5xvcmewLn1OD7QVnVPOerN2IVTHby wJQ1F2Zht7UXtodesYRQcXqlSprQtYkhVFjgSloRhwTK4Ca128wVqITkCgUOk1ILjhqi 0GHRCsYdA6l5XNoJZl9nqrgBMVRQSLeHJ7yTrTA3zFLYbCi7eYE6WlyKBZViifze3nAu LC+A==
X-Gm-Message-State: AOAM533PEpubtUaoql0JFuj7ixQUb+XnHxnDtn7TqkPQik8lBWVUajq8 dJ/NoqxUIlGoh9FcvcGcRSoT3mzMLNAOP4RXUGZOSymvSvk=
X-Google-Smtp-Source: ABdhPJxNOFD2UdQdiHpXeXAaWeAoAOlYbVN56XnCSvR472D6oI8uQfzIfGeVV8j3a5Crv7qSALiTxxtSf7guC1VqZ74=
X-Received: by 2002:a05:651c:2110:b0:249:8564:d10a with SMTP id a16-20020a05651c211000b002498564d10amr4305290ljq.142.1648583512425; Tue, 29 Mar 2022 12:51:52 -0700 (PDT)
MIME-Version: 1.0
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Tue, 29 Mar 2022 15:51:41 -0400
Message-ID: <CAF4+nEGh6PB0+npSs59+LNv0qwAM+uSEbOCHXhys50gDbdVb=w@mail.gmail.com>
To: apn@ietf.org
Content-Type: multipart/alternative; boundary="000000000000a4083505db60c2d6"
Archived-At: <https://mailarchive.ietf.org/arch/msg/apn/CcGe9W2pZUN8S-_XBAFGKFScW7c>
Subject: [Apn] Comments on draft-li-apn-ipv6-encap-01
X-BeenThere: apn@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Application-aware Networking <apn.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apn>, <mailto:apn-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/apn/>
List-Post: <mailto:apn@ietf.org>
List-Help: <mailto:apn-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apn>, <mailto:apn-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2022 19:51:58 -0000

I have reviewed this draft and have some comments that I believe would
improve it, mostly by clarifying it:

The Requirement Language section should be updated to the current required
wording referencing RFC 8174 as well as RFC 2119.

Section 2: Add SRH to the list of acronyms with a reference to RFC 8754.

Section 3:

In the first sentence "one option" -> "one IPv6 Header option [RFC8200]"

In Figure 1, the "Opt Type" field should probably be something like "Opt
Type=TBD2"

In the list of fields after Figure 1, it currently lists "Option Data" but
that should be changed to "APN Header" which is what it says in the figure.

Section 4.1: "Hop-by-Hop Options" -> "IPv6 Hop-by-Hop Options"

Section 4.2: Suggest inserting "but would not normally be seen by other
nodes" in the last sentence between "destination node" and "along".

Section 5:

Similar to the change in Figure 1, in Figure 2 the "Type" field should say
something like "Type=TBD1".

In the list of fields after Figure 2, for Type is should just say "TBD1"
instead of "to be assigned by IANA", for RESERVED add "and ignored on
receipt", and for APN Header, it should reference [I.D.li-apn-header].

Section 6, IANA Considerations: In my opinion, this section needs a
more-or-less complete replacement. Also, for the IPv6 Header Option, it
needs to specify the bits that indicate whether the option can change in
flight (I'm guessing it can't) and what to do if the option is not known
(my guess is ignore it). So I suggest replacing this section with something
like the following:

*6. IANA Considerations*


*   IANA is requested to assign two code points as below.*



*6.1 IPv6 Header Option*



*   IANA is requested to assign an IPv6 Header Option as follows:*



*   Hex      Binary Value*

*   Value    act chg rest    Description                   Reference*

*   -----    --- --- -----  ----------------------------  ---------------*

*    TBD1     00   0 xxxxx  Application-aware Networking  [this document]*



*   RFC Editor / IANA Note: To be removed when RFC is published. xxxxx is
the binary for the bottom 5 bits of RBD1. *



*6.2 SRH TLV Type*



*   IANA is requested to assign an SRH TLV Type as follows:*



*   Value    Description                    Reference*

*   -----   ----------------------------   -----------------*

*    TBD2   Application-aware Networking    [this document]*


References: I think that RFCs 8174 and 8200 should be added to the
normative references.

There were also some additional minor editorial suggestions that I sent
directly to the authors.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 2386 Panoramic Circle, Apopka, FL 32703 USA
 d3e3e3@gmail.com