Re: [apps-discuss] Appsdir review of XML schema in https://tools.ietf.org/html/draft-ietf-clue-data-model-schema-14

Eliot Lear <lear@cisco.com> Wed, 11 May 2016 18:35 UTC

Return-Path: <lear@cisco.com>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA19B12D738; Wed, 11 May 2016 11:35:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.517
X-Spam-Level:
X-Spam-Status: No, score=-15.517 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.996, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CI8E2L5WBtRY; Wed, 11 May 2016 11:35:42 -0700 (PDT)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 77DCF12D513; Wed, 11 May 2016 11:35:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4659; q=dns/txt; s=iport; t=1462991742; x=1464201342; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to; bh=apO3JYwypaabvjtyoVXgTXldyjlECUPo+cdUbDg0ymA=; b=Y/sesWN7HGrYkvbHOlKDpSGZ29tD3mWp0IZN55ANvIr5ckFViH5iqVYW 73U6lub/BlerxP1hzUsOgAj037fxosumQdmY1qarM/uFzN7+z7fdTueET HiXArlIhqlMDqPKagOaVJ87aZlXTHOZyKmMHtVxulNd/UF0Nyb1i/Nz73 4=;
X-Files: signature.asc : 481
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CrBACaejNX/xbLJq1eDoN/fbs0JIVwA?= =?us-ascii?q?oIJAQEBAQEBZieEQwEBBCNWEAsUBAkaBwICDwJGBgEMCAEBBYgmDgOpeZBpAQE?= =?us-ascii?q?BAQEBAQEBAQEBAQEBAQEBAQEOCIpshF+CYIJZBZgngymBaG2IIIFpToQBgwcjh?= =?us-ascii?q?TePQWKCBRsWej06MgEBh0wlgRcBAQE?=
X-IronPort-AV: E=Sophos;i="5.24,608,1454976000"; d="asc'?scan'208";a="635599596"
Received: from aer-iport-nat.cisco.com (HELO aer-core-3.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 May 2016 18:35:39 +0000
Received: from [10.61.97.31] (dhcp-10-61-97-31.cisco.com [10.61.97.31]) by aer-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id u4BIZcM0032016; Wed, 11 May 2016 18:35:38 GMT
To: "Henry S. Thompson" <ht@inf.ed.ac.uk>, apps-discuss@ietf.org, draft-ietf-clue-data-model-schema.all@ietf.org
References: <f5bwpn0egdz.fsf@troutbeck.inf.ed.ac.uk>
From: Eliot Lear <lear@cisco.com>
Message-ID: <57337B7A.70501@cisco.com>
Date: Wed, 11 May 2016 20:35:38 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <f5bwpn0egdz.fsf@troutbeck.inf.ed.ac.uk>
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mmShDGXIkDL1SKtsQJ7ow2eLERfxRicig"
Archived-At: <http://mailarchive.ietf.org/arch/msg/apps-discuss/RX1MEiX2blLxvaQArsuW6hUROnI>
Cc: iesg@ietf.org
Subject: Re: [apps-discuss] Appsdir review of XML schema in https://tools.ietf.org/html/draft-ietf-clue-data-model-schema-14
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/apps-discuss/>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 May 2016 18:35:50 -0000

Thank you for doing this prompt review, Henry.

Eliot


On 5/11/16 5:58 PM, Henry S. Thompson wrote:
> [Argh, fumble-finger -- resending with correct address lines]
>
> Document: draft-ietf-clue-data-model-schema
> Title: An XML Schema for the CLUE data model
> Reviewer: Henry S. Thompson
> Review Date: 2016-05-11
> IETF Last Call Date: 2016-05-23
> ESG Telechat Date: 2016-06-02
>
> I have been selected as the Applications Area Directorate reviewer for
> this draft (for background on appsdir, please see
> http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate).
>
> Please resolve these comments along with any other Last Call comments
> you may receive. Please wait for direction from your document shepherd
> or AD before posting a new version of the draft.
>
> Summary: The XML Schema itself which is included in this draft is
> conformant to the XML Schema 1.0 spec, and is good to go, subject to a
> minor correction.  There is a minor glitch in one of the XML examples,
> also easily corrected.
>
> Comments:
>
> I tested the XML Schema document included as section 4 and it passes as
> valid against the schema for schemas.  The example document in section
> 17 is schema-valid according to the corresponding schema.  See 'Nits'
> below for a minor problem with the example document in section 18.
>
> I briefly reviewed the schema document and it seems straightforward and
> fit for its intended purpose.
>
> Minor Issues:
>
> Section 4, lines 13--14:
>
>  <xs:import namespace="urn:ietf:params:xml:ns:vcard-4.0"
>  schemaLocation="xcard.xsd"/>
>
> As this stands, it's not actually usable for validation purposes,
> because no xcard.xsd file is supplied.  Furthermore, there is no
> Appendix A, which is alleged to provide it (see 11.29.1.2).
>
> I note further that the xCard RFC (6351) doesn't contain an XSD-format
> schema document either.  The IANA XML Registry [1] schema entry for the
> urn:ietf:params:xml:ns:vcard-4.0 URN namespace _does_ however link to
> such a schema document [2].  I suggest you either
>   a) Edit the draft so the above lines read
>
>  <xs:import namespace="urn:ietf:params:xml:ns:vcard-4.0"
>  schemaLocation="http://www.iana.org/assignments/xml-registry/schema/vcard-4.0.xsd"/>
>
>   (this is what I did to do the validity checks I did);
>
> or
>
>  b) Delete the schemaLocation attribute and add a comment identifying
>     possible sources of a schema document for the vcard-4.0 namespace,
>     e.g. the above iana.org URI or the contents of Appendix A (if you
>     fill it in).
>
> Nits:
>
> Section 18, the XML example has a (copy-paste?) error, which renders
> that example invalid against the schema.  The line
>
>              <encGroupIDREF>EG0</encGroupIDREF>
>
> appears twice inside mediaCapture VC7, once on line 204 and once on line
> 237.  The first occurrence should be deleted.
>
> [1] http://www.iana.org/assignments/xml-registry/xml-registry.xhtml#schema
> [2] http://www.iana.org/assignments/xml-registry/schema/vcard-4.0.xsd