[apps-discuss] APPSDIR review of draft-ietf-straw-b2bua-dtls-srtp-08.txt
"Vijay K. Gurbani" <vkg@bell-labs.com> Mon, 16 November 2015 21:31 UTC
Return-Path: <vkg@bell-labs.com>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EAF931B31D7; Mon, 16 Nov 2015 13:31:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_50=0.8, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EkPPo-B6TUt4; Mon, 16 Nov 2015 13:31:25 -0800 (PST)
Received: from smtp-fr.alcatel-lucent.com (fr-hpida-esg-02.alcatel-lucent.com [135.245.210.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DA1F61B31AB; Mon, 16 Nov 2015 13:31:24 -0800 (PST)
Received: from us70uusmtp3.zam.alcatel-lucent.com (unknown [135.5.2.65]) by Websense Email Security Gateway with ESMTPS id CDCEC7D7907E9; Mon, 16 Nov 2015 21:31:17 +0000 (GMT)
Received: from umail.lucent.com (umail.ndc.lucent.com [135.3.40.61]) by us70uusmtp3.zam.alcatel-lucent.com (GMO) with ESMTP id tAGLVISN021894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 16 Nov 2015 21:31:21 GMT
Received: from [135.185.238.169] (shoonya.ih.lucent.com [135.185.238.169]) by umail.lucent.com (8.13.8/TPES) with ESMTP id tAGLVIgj003389; Mon, 16 Nov 2015 15:31:18 -0600 (CST)
To: draft-ietf-straw-b2bua-dtls-srtp.all@tools.ietf.org
From: "Vijay K. Gurbani" <vkg@bell-labs.com>
Message-ID: <564A4B26.4020108@bell-labs.com>
Date: Mon, 16 Nov 2015 15:31:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/apps-discuss/ShDV0teY3_830StD5rI4A6_1BAk>
Cc: iesg@ietf.org, apps-discuss@ietf.org
Subject: [apps-discuss] APPSDIR review of draft-ietf-straw-b2bua-dtls-srtp-08.txt
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/apps-discuss/>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Nov 2015 21:31:27 -0000
I have been selected as the Applications Area Directorate early reviewer for this draft (for background on appsdir, please see http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate). Please resolve these comments along with any other Last Call comments you may receive. Please wait for direction from your document shepherd or AD before posting a new version of the draft. Document: draft-ietf-straw-b2bua-dtls-srtp-08.txt Title: DTLS-SRTP Handling in Session Initiation Protocol (SIP) Back-to-Back User Agents (B2BUAs) Reviewer: Vijay K. Gurbani Review Date: 2015-11-16 IETF Last Call Date: 2015-11-17 IESG Telechat Date: 2015-12-03 Summary: This draft has minor issues, and is ready for publication as a Proposed Standard once these issues are resolved. I will also (strongly) suggest that the editors go over the draft for grammatical touches to eliminate the sort of issues present in the Nits section. This will make the draft more readable and provide it the gravity it needs for a standards track document. Major: 0 Minor: 3 Nits: Many Minor: - S3.1.1, second to last paragraph (beginning with "[RFC4474] provides ... the signature."): Isn't this only true if the originating UAC used rfc4474 and inserted the appropriate headers. Or is the assumption that rfc4474 is always used, and therefore, a media relay B2BUA must be careful and not modify the fingerprints? - S3.1.2, first paragraph: "The identity integrity protection procedures described in Security Considerations section..." Described in the Security Consideration section of which document? The document under review or some other one (rfc7092)? - S3.1.2.2: I am not sure what your takeaway is at the end of this section. You seem to be making the case that a B2BUA cannot modify the RTP headers and RTCP packets. But then you go on and say that this can be mitigated by using different keys, and that with "such an approach" (aside: define "such an approach"), the B2BUA is not aware of the keys used to decrypt the media payload. Well, the B2BUA is never aware of such keys, since they are negotiated end-to-end (over the B2BUA), so I am at a loss to see what is the point of this section. Nits: - Abstract: s/media plane, rather than/media plane rather than - Abstract: s/This document describes the behavior such B2BUAs can adhere to/This document describes the behaviour of such B2BUAs/ - S1.1: s/The fingerprint, identifies/The fingerprint identifies - S3.1.2: s/There are two types of media-aware relay/There are two types of media-aware relays/ - S3.1.2.1: (For readability) s/This kind of media aware relay/A RTP/RTCP aware media relay/ - S4: s/B2BUA replaces the Bob's/B2BUA replaces Bob's/ (If you want to retain "the", perhaps you may consider renaming Bob to Donald! Sorry, bad joke, I know.) Thanks, - vijay -- Vijay K. Gurbani, Bell Laboratories, Alcatel-Lucent 1960 Lucent Lane, Rm. 9C-533, Naperville, Illinois 60563 (USA) Email: vkg@{bell-labs.com,acm.org} / vijay.gurbani@alcatel-lucent.com Web: http://ect.bell-labs.com/who/vkg/ | Calendar: http://goo.gl/x3Ogq
- [apps-discuss] APPSDIR review of draft-ietf-straw… Vijay K. Gurbani
- Re: [apps-discuss] APPSDIR review of draft-ietf-s… Ram Mohan R (rmohanr)