Re: [apps-discuss] Appsdir review of XML schema in https://tools.ietf.org/html/draft-ietf-clue-data-model-schema-14

"Roni Even" <ron.even.tlv@gmail.com> Thu, 12 May 2016 15:36 UTC

Return-Path: <ron.even.tlv@gmail.com>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9681212D17C; Thu, 12 May 2016 08:36:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lNCYaGHRQoHp; Thu, 12 May 2016 08:36:25 -0700 (PDT)
Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D4B7C12D09F; Thu, 12 May 2016 08:36:24 -0700 (PDT)
Received: by mail-wm0-x230.google.com with SMTP id n129so264609444wmn.1; Thu, 12 May 2016 08:36:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=RzVyV3FRxl1GoVWYKwcrne7Zi4hBD3br2V8eVCUy/aQ=; b=lA1kv3K6LdfzSH2JZMeHOA9PlCFYrtvQ9DxVUoW+2hdVQcOzcIxcGO4Y32vvdjGKqU dipuEqDk/fHdzmHjbvgEDQDA9hlQHYhqR1v3yDsFiak/0Aw8k40WY1qBYaIqhkiOZTYd 05LVCuIVoSRpdn15Np9jky3zhjX7/M3s7Riar2PtaHe3XJI5CD2PEg8gXO+b9O9Zxnt2 c+1D4NVkEhHglsxhuKFj6eBPaLX53oufqN7H+hTnXbGYmDekRT6TIkQtmGKh/TDCqAm0 +nf5iXK9Wai9/m40mADla3ziCwqeJiaAC4ZE2yEiZcLt8c1RHO8zAQYYVUfD6Etn1TEv VjIQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:thread-index :content-language; bh=RzVyV3FRxl1GoVWYKwcrne7Zi4hBD3br2V8eVCUy/aQ=; b=ls4ihkCNzdYjqPsv5BnN4vLq2Eqp4jFMN1H8ihgkAubbMBy0vlybJj/PGYPQsaBPJv VoLO7WpP9C9kPwp2YTD3k/HySIg51nurqppKCI4/XQjCIIhz5LTA0sBHcefx6B+OhhiB TSIbtKCKo8V0EQ0P0YH5lUV8mJobjjwPgE0+urtCzJe8OOQghlLG3nI7l1zrL9x/goZD 5gwHZrXy6kC1h/Naj6XG3AJHK2mSGSuZsp6iybUWjcHSkt5QO8oHD7fL1K2ofllZxEw4 8TctxD7BamxdxS3eeiJ//UqcxIN9ZSfiVKHwnEzDuiRZyeVbpsRbat2MzZCxoFkW8oLa ZBlQ==
X-Gm-Message-State: AOPr4FUHDMVBHrWmVuQE64a+UhwLF4eM0fb8sp8F36cUGa51Z536rFZTHALTXNry1QgXwg==
X-Received: by 10.28.232.212 with SMTP id f81mr7417776wmi.27.1463067383398; Thu, 12 May 2016 08:36:23 -0700 (PDT)
Received: from RoniPC (bzq-79-178-104-140.red.bezeqint.net. [79.178.104.140]) by smtp.gmail.com with ESMTPSA id a200sm41920671wme.8.2016.05.12.08.36.21 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 May 2016 08:36:22 -0700 (PDT)
From: "Roni Even" <ron.even.tlv@gmail.com>
To: "'Henry S. Thompson'" <ht@inf.ed.ac.uk>, <apps-discuss@ietf.org>, <draft-ietf-clue-data-model-schema.all@ietf.org>
References: <f5bwpn0egdz.fsf@troutbeck.inf.ed.ac.uk>
In-Reply-To: <f5bwpn0egdz.fsf@troutbeck.inf.ed.ac.uk>
Date: Thu, 12 May 2016 18:36:07 +0300
Message-ID: <089d01d1ac64$01e77c70$05b67550$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQFyRqhATyze6PpciVH2FXJ9BrlVHKB0OnUA
Content-Language: he
Archived-At: <http://mailarchive.ietf.org/arch/msg/apps-discuss/zOmCFTp-nGsLeRSFDBujiQgxNUw>
Cc: iesg@ietf.org
Subject: Re: [apps-discuss] Appsdir review of XML schema in https://tools.ietf.org/html/draft-ietf-clue-data-model-schema-14
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/apps-discuss/>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 May 2016 15:36:27 -0000

Thanks for the review,
I forwarded it also to the CLUE WG mailing list
Roni Even
CLUE WG co-chair

> -----Original Message-----
> From: Henry S. Thompson [mailto:ht@inf.ed.ac.uk]
> Sent: Wednesday, May 11, 2016 6:58 PM
> To: apps-discuss@ietf.org; draft-ietf-clue-data-model-schema.all@ietf.org
> Cc: iesg@ietf.org
> Subject: Appsdir review of XML schema in
https://tools.ietf.org/html/draft-
> ietf-clue-data-model-schema-14
> 
> [Argh, fumble-finger -- resending with correct address lines]
> 
> Document: draft-ietf-clue-data-model-schema
> Title: An XML Schema for the CLUE data model
> Reviewer: Henry S. Thompson
> Review Date: 2016-05-11
> IETF Last Call Date: 2016-05-23
> ESG Telechat Date: 2016-06-02
> 
> I have been selected as the Applications Area Directorate reviewer for
this
> draft (for background on appsdir, please see
>
http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate).
> 
> Please resolve these comments along with any other Last Call comments you
> may receive. Please wait for direction from your document shepherd or AD
> before posting a new version of the draft.
> 
> Summary: The XML Schema itself which is included in this draft is
conformant
> to the XML Schema 1.0 spec, and is good to go, subject to a minor
> correction.  There is a minor glitch in one of the XML examples, also
easily
> corrected.
> 
> Comments:
> 
> I tested the XML Schema document included as section 4 and it passes as
> valid against the schema for schemas.  The example document in section
> 17 is schema-valid according to the corresponding schema.  See 'Nits'
> below for a minor problem with the example document in section 18.
> 
> I briefly reviewed the schema document and it seems straightforward and
fit
> for its intended purpose.
> 
> Minor Issues:
> 
> Section 4, lines 13--14:
> 
>  <xs:import namespace="urn:ietf:params:xml:ns:vcard-4.0"
>  schemaLocation="xcard.xsd"/>
> 
> As this stands, it's not actually usable for validation purposes, because
no
> xcard.xsd file is supplied.  Furthermore, there is no Appendix A, which is
> alleged to provide it (see 11.29.1.2).
> 
> I note further that the xCard RFC (6351) doesn't contain an XSD-format
> schema document either.  The IANA XML Registry [1] schema entry for the
> urn:ietf:params:xml:ns:vcard-4.0 URN namespace _does_ however link to
> such a schema document [2].  I suggest you either
>   a) Edit the draft so the above lines read
> 
>  <xs:import namespace="urn:ietf:params:xml:ns:vcard-4.0"
>  schemaLocation="http://www.iana.org/assignments/xml-
> registry/schema/vcard-4.0.xsd"/>
> 
>   (this is what I did to do the validity checks I did);
> 
> or
> 
>  b) Delete the schemaLocation attribute and add a comment identifying
>     possible sources of a schema document for the vcard-4.0 namespace,
>     e.g. the above iana.org URI or the contents of Appendix A (if you
>     fill it in).
> 
> Nits:
> 
> Section 18, the XML example has a (copy-paste?) error, which renders that
> example invalid against the schema.  The line
> 
>              <encGroupIDREF>EG0</encGroupIDREF>
> 
> appears twice inside mediaCapture VC7, once on line 204 and once on line
> 237.  The first occurrence should be deleted.
> 
> [1] http://www.iana.org/assignments/xml-registry/xml-
> registry.xhtml#schema
> [2] http://www.iana.org/assignments/xml-registry/schema/vcard-4.0.xsd
> --
>        Henry S. Thompson, School of Informatics, University of Edinburgh
>       10 Crichton Street, Edinburgh EH8 9AB, SCOTLAND -- (44) 131 650-4440
>                 Fax: (44) 131 650-4587, e-mail: ht@inf.ed.ac.uk
>                        URL: http://www.ltg.ed.ac.uk/~ht/  [mail from me
_always_ has
> a .sig like this -- mail without it is forged spam]