Re: [aqm] adoption of draft-white-aqm-docsis-pie-01

Greg White <g.white@CableLabs.com> Mon, 30 March 2015 14:55 UTC

Return-Path: <g.white@CableLabs.com>
X-Original-To: aqm@ietfa.amsl.com
Delivered-To: aqm@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E557A1AC3EA for <aqm@ietfa.amsl.com>; Mon, 30 Mar 2015 07:55:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 2.125
X-Spam-Level: **
X-Spam-Status: No, score=2.125 tagged_above=-999 required=5 tests=[BAYES_20=-0.001, HELO_EQ_MODEMCABLE=0.768, HOST_EQ_MODEMCABLE=1.368, T_RP_MATCHES_RCVD=-0.01] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qx-gipJwzyiJ for <aqm@ietfa.amsl.com>; Mon, 30 Mar 2015 07:55:14 -0700 (PDT)
Received: from ondar.cablelabs.com (ondar.cablelabs.com [192.160.73.61]) by ietfa.amsl.com (Postfix) with ESMTP id CAF411AC3DF for <aqm@ietf.org>; Mon, 30 Mar 2015 07:55:14 -0700 (PDT)
Received: from kyzyl.cablelabs.com (kyzyl [10.253.0.7]) by ondar.cablelabs.com (8.14.7/8.14.7) with ESMTP id t2UEtB02003328; Mon, 30 Mar 2015 08:55:11 -0600
Received: from exchange.cablelabs.com (10.5.0.19) by kyzyl.cablelabs.com (F-Secure/fsigk_smtp/407/kyzyl.cablelabs.com); Mon, 30 Mar 2015 08:55:11 -0600 (MDT)
X-Virus-Status: clean(F-Secure/fsigk_smtp/407/kyzyl.cablelabs.com)
Received: from EXCHANGE.cablelabs.com ([::1]) by EXCHANGE.cablelabs.com ([::1]) with mapi id 14.03.0224.002; Mon, 30 Mar 2015 08:55:09 -0600
From: Greg White <g.white@CableLabs.com>
To: Mikael Abrahamsson <swmike@swm.pp.se>, Szilveszter Nadas <Szilveszter.Nadas@ericsson.com>
Thread-Topic: [aqm] adoption of draft-white-aqm-docsis-pie-01
Thread-Index: AdBR0qmLD+JlLAXWSZym1tRD+kojwQXBCieAADEmzbAAVIyLgAAC+4mA
Date: Mon, 30 Mar 2015 14:55:09 +0000
Message-ID: <D13EBE0D.4730C%g.white@cablelabs.com>
References: <96cffe6791f54a67ae6b6359de6a3d6e@hioexcmbx05-prd.hq.netapp.com> <e9e3d9dc0435474283180936c371e0db@hioexcmbx05-prd.hq.netapp.com> <EA4C43BE752A194597B002779DF69BAE23CC4533@ESESSMB303.ericsson.se> <alpine.DEB.2.02.1503300847120.20507@uplift.swm.pp.se>
In-Reply-To: <alpine.DEB.2.02.1503300847120.20507@uplift.swm.pp.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.4.7.141117
x-originating-ip: [10.4.11.35]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5C534303113AE047ACF8AE0596C4135E@cablelabs.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/aqm/286sE7Ky3DLsn1rx5LaCA5ytc2A>
Cc: "Scheffenegger, Richard" <rs@netapp.com>, "aqm-chairs@tools.ietf.org" <aqm-chairs@tools.ietf.org>, Dave Dolson <ddolson@sandvine.com>, "'aqm@ietf.org'" <aqm@ietf.org>
Subject: Re: [aqm] adoption of draft-white-aqm-docsis-pie-01
X-BeenThere: aqm@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Discussion list for active queue management and flow isolation." <aqm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/aqm>, <mailto:aqm-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/aqm/>
List-Post: <mailto:aqm@ietf.org>
List-Help: <mailto:aqm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/aqm>, <mailto:aqm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Mar 2015 14:55:19 -0000

Mikael,

Thanks for the review and suggestions.  I will take them into account in
the next revision.

-Greg




On 3/30/15, 1:30 AM, "Mikael Abrahamsson" <swmike@swm.pp.se> wrote:

>On Sun, 29 Mar 2015, Szilveszter Nadas wrote:
>
>> Hi,
>>
>> You have an interesting process to encourage mic comments. ;)
>>
>> Reviewed version: "draft-ietf-aqm-docsis-pie-00".
>
>Me too.
>
>Some suggestions and comments:
>
>Abstract:
>
>...
>    "They are commonly positioned at the
>    head of the bottleneck link for traffic in the upstream direction
>    (from the customer),"
>
>I find this sentence hard to read. I would suggest changes to the
>abstract 
>along these lines (I will include _ around the changed parts)
>
>"DOCSIS cable modems provide broadband Internet access to over one
>hundred 
>million users worldwide.  They are commonly positioned _so that they
>handle the lowering speed adaptation in the upstream direction_ (from the
>customer) towards the Internet, and as a result, the impact of buffering
>and bufferbloat in the cable modem can have a significant effect on user
>experience.  The CableLabs DOCSIS specification _(introduced in)_ 3.1
>includes requirements for cable modems to support an Active Queue
>Management (AQM) algorithm that is intended to alleviate the impact that
>buffering has on latency sensitive traffic, while preserving bulk
>throughput performance.  In addition, the CableLabs DOCSIS 3.0
>specifications have also been amended to contain similar requirements."
>
>I just feel that this makes it easier for a non-expert read by changing
>the second sentence to not talk about "head", and clarify that later that
>the AQM sections were introduced in 3.1 specification.
>
>Section 1.
>
>Here it says "CableLabs'" and in abstract it says "CableLabs" (without
>'). 
>Is that correct?
>I would recommend to add "upstream from the customer" in the second
>paragraph.
>
>Section 3.
>
>The list in 3 doesn't match the 3.1-3.4 headers, so my suggestion would
>be 
>to get rid of the list in 3 and just keep the 3.1-3.4 headers.
>
>Conclusion:
>
>Then I read A, and that seems mostly to list changes to PIE for the
>DOCSIS-PIE implementation?
>
>What is the aim of this document? To describe in an IETF environment what
>the DOCSIS-PIE implementation does? This is not stated in the abstract or
>introduction. I think it would be worthwhile to put in a few lines in
>either place to describe exactly what the aim of the document is, and
>potentially, what it isn't. Perhaps bump the overview from section 1 to 2
>and insert an introduction there?
>
>It's my opinion that this is a document that is valuable to publish as an
>informational draft in IETF-AQM.
>
>
>-- 
>Mikael Abrahamsson    email: swmike@swm.pp.se