Re: [aqm] [Gen-art] Review of draft-ietf-aqm-codel-07

Alissa Cooper <alissa@cooperw.in> Tue, 11 April 2017 19:36 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: aqm@ietfa.amsl.com
Delivered-To: aqm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B2F4512EBCA; Tue, 11 Apr 2017 12:36:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.72
X-Spam-Level:
X-Spam-Status: No, score=-2.72 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=ZL9C24YL; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=df91o2Kf
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PT7vH-8f8Gt5; Tue, 11 Apr 2017 12:36:10 -0700 (PDT)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D6A9A12EC9C; Tue, 11 Apr 2017 12:36:09 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 51626209F7; Tue, 11 Apr 2017 15:36:09 -0400 (EDT)
Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Tue, 11 Apr 2017 15:36:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=c+9A1/5kCSeNQVpPt4 45e42nb5ogewT5IVEZkGKpD2g=; b=ZL9C24YLV35njbdTM6cJ6mgzqtVs0d4S9P 4M3mtYp4U/Q8ecBAvm1ZtyD178l1/f75itJz9j2OrBTk64thZqtly6atCfjvQ8uL LFS8r5vRsaivzchnXvHLpKqQTEZx8ZgkEXPmPfXiiYZ3S1oswtgdijJ+e1Zegl/Q M+YCcvAORsj7Tp4h/1F7AwKOiY0iPWNJTNdW/XPSefwRhPuPptVJ8gDK8g2OzTnY YRBOwxT/+ll7YY0wGZwQRrhs+7caey01+I4MkEn6PoJa/ZuBt1likG9LfAECy9mN uuHQL2eT2NmUuPsfss1U6osmqVxGlWDLOvhXmQJ7BjmPzPicvuSw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=c+9A1/5kCSeNQVpPt445e42nb5ogewT5IVEZkGKpD2g=; b=df91o2Kf hvPzm3Lmrig5mUJ/ZU90X02UynNYAXouGhE+p05+qWuXAQJyO42ah8EytUrOkllK /T2swGjoDDVfKA9d/fLIMX49LRxGx2eUGyD2DehwtZ9XX9RuaZxrOEPsgZUT1GZE 1uFtO6O8yWN+6hobVlI30ScYNq28ftmjGJAoQrGciOph40j1gtMoHV7uTQGYyUfP F16J5Q5zsLdZX+0kKC+lqNJkNVFZCdQSjp8NnFt+fxNOetEYGof88Hs5yZI5F17U UmuHSGg3A1jPmoLyDR7dHKJb32mVyEzhAXwKcPL+UsMO8z7z/qm3VjzqWeIkoX1i +MMUjMsCJeF+fA==
X-ME-Sender: <xms:KTDtWB-pnxyY5bj5inJ1wGmZllLMZn0suaxGyzZEsJpoZvtnjpIIQg>
X-Sasl-enc: xFnKCn1b5YHytEQW9ozbT8jVwKtWu3CvWr4Vo7fnuTw1 1491939368
Received: from sjc-alcoop-8817.cisco.com (unknown [128.107.241.178]) by mail.messagingengine.com (Postfix) with ESMTPA id 53F7324526; Tue, 11 Apr 2017 15:36:08 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <149049732959.11830.18161576308900341179@ietfa.amsl.com>
Date: Tue, 11 Apr 2017 15:36:06 -0400
Cc: gen-art@ietf.org, draft-ietf-aqm-codel.all@ietf.org, aqm@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <6708251A-546F-49F7-B8DE-86B2C704A63E@cooperw.in>
References: <149049732959.11830.18161576308900341179@ietfa.amsl.com>
To: Fernando Gont <fgont@si6networks.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/aqm/RB33BfgypVN6jZWXHtMGnP-nrrg>
Subject: Re: [aqm] [Gen-art] Review of draft-ietf-aqm-codel-07
X-BeenThere: aqm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Discussion list for active queue management and flow isolation." <aqm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/aqm>, <mailto:aqm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/aqm/>
List-Post: <mailto:aqm@ietf.org>
List-Help: <mailto:aqm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/aqm>, <mailto:aqm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Apr 2017 19:36:13 -0000

Fernando, thanks for your review. Will leave it the authors/WG to consider your comments. On your major point, personally I don’t find it problematic for the diagrams to be archived elsewhere, given our current limitations of ASCII art and the clear presentation in the referenced doc/session in TSVAREA.

Alissa

> On Mar 25, 2017, at 11:02 PM, Fernando Gont <fgont@si6networks.com> wrote:
> 
> Reviewer: Fernando Gont
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-aqm-codel-07
> Reviewer: Fernando Gont
> Review Date: 2017-03-25
> IETF LC End Date: 2017-03-27
> IESG Telechat date: 2017-04-13
> 
> Summary:
> The document is well written. However, there seem to be too many
> details that are left out in other associated documents. Whereas such
> details (including figures) are needed to understand this document,
> they should be included here. Either provide full explanations or
> summarize the outcome without details (there's text that somehow
> relies on the reading finding such figures elsewhere).
> 
> 
> Major issues:
> * Section 5.1, page 16:
>>   A more detailed explanation with many pictures can be found in
>>   http://www.ietf.org/proceedings/84/slides/slides-84-tsvarea-4.pdf
> .
> 
> Unless I'm missing something, if this document is specifying CoDel,
> then all such details should be here.
> 
> 
> Minor issues:
> * General:
> The document would benefit from a terminology section. For example,
> only well into the I-D one finds definitions of terms such as "sojourn
> times" or "target setpoint". Not sure if those terms are supposed to
> be trivial/obvious to most people reading this document, but their
> non-definition left me trying to figure out what the terms were about
> before I was ale to better understand what you were describing.
> 
> 
> 
> Page 3, Section 1:
>>   o  simple and efficient implementation (can easily span the
> spectrum
>>      from low-end, linux-based access points and home routers up
> to
>>      high-end commercial router silicon)
> 
> There seems to be an unnecesary implicit "judgement" here, associating
> linux-based with low-end, and commercial with high end. I suggest you
> modify the text.
> 
> 
> Page 10:
>>           count_ = (delta > 1 && now - drop_next_ < 16*interval_)?
> 
> For clarity, I'd use additional parenthesis here.
> 
> 
> Nits/editorial comments: 
> * Page 17:
>> The power vs. f curve for any AIMD TCP is monotone decreasing. 
> 
> Please expand the acronym.
> 
> 
> * Page 17:
>>   simulation that this result holds for Reno, Cubic, and
>>   Westwood[TSV84].
> 
> Missing space.
> 
> Thanks!
> Fernando
> 
> 
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art