Re: [aqm] FQ-PIE kernel module implementation

Polina Goltsman <uucpf@student.kit.edu> Fri, 03 July 2015 09:45 UTC

Return-Path: <polina.goltsman@student.kit.edu>
X-Original-To: aqm@ietfa.amsl.com
Delivered-To: aqm@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 11B731B2B71 for <aqm@ietfa.amsl.com>; Fri, 3 Jul 2015 02:45:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.61
X-Spam-Level:
X-Spam-Status: No, score=-1.61 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, MIME_8BIT_HEADER=0.3, T_RP_MATCHES_RCVD=-0.01] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WMp1HFvuJSH0 for <aqm@ietfa.amsl.com>; Fri, 3 Jul 2015 02:45:21 -0700 (PDT)
Received: from scc-mailout-kit-02.scc.kit.edu (scc-mailout-kit-02.scc.kit.edu [IPv6:2a00:1398:9:f712::810d:e752]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 582DD1B2B70 for <aqm@ietf.org>; Fri, 3 Jul 2015 02:45:19 -0700 (PDT)
Received: from kit-msx-03.kit.edu ([129.13.50.103]) by scc-mailout-kit-02.scc.kit.edu with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:128) (envelope-from <polina.goltsman@student.kit.edu>) id 1ZAxWy-0001V6-Ow; Fri, 03 Jul 2015 11:45:13 +0200
Received: from [141.3.228.239] (141.3.228.239) by smtp.kit.edu (129.13.50.106) with Microsoft SMTP Server (TLS) id 8.3.389.2; Fri, 3 Jul 2015 11:45:11 +0200
Message-ID: <559659A8.9030104@student.kit.edu>
Date: Fri, 03 Jul 2015 11:45:12 +0200
From: Polina Goltsman <uucpf@student.kit.edu>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: "Fred Baker (fred)" <fred@cisco.com>, Toke Høiland-Jø rgensen <toke@toke.dk>
References: <D1961A16.1087%hokano@cisco.com> <5577FBD3.5000804@student.kit.edu> <97EDD2D8-CC0A-4AFA-9A74-3F2C282CF5C2@cisco.com> <87mvzem9i9.fsf@alrua-karlstad.karlstad.toke.dk> <7E6C797B-EE6F-4390-BC8F-606FDD8D5195@cisco.com>
In-Reply-To: <7E6C797B-EE6F-4390-BC8F-606FDD8D5195@cisco.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/aqm/SUfPr1VPCOfumvmKjjAIXdBBFjE>
X-Mailman-Approved-At: Fri, 03 Jul 2015 06:23:57 -0700
Cc: "draft-ietf-aqm-pie@tools.ietf.org" <draft-ietf-aqm-pie@tools.ietf.org>, "Hironori Okano -X (hokano - AAP3 INC at Cisco)" <hokano@cisco.com>, AQM IETF list <aqm@ietf.org>
Subject: Re: [aqm] FQ-PIE kernel module implementation
X-BeenThere: aqm@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Discussion list for active queue management and flow isolation." <aqm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/aqm>, <mailto:aqm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/aqm/>
List-Post: <mailto:aqm@ietf.org>
List-Help: <mailto:aqm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/aqm>, <mailto:aqm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jul 2015 09:45:23 -0000


On 07/03/2015 01:30 AM, Fred Baker (fred) wrote:
>> On Jul 2, 2015, at 4:21 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>
>> This is, as far as I can tell from your explanation, different than what
>> fq_pie does.
> OK, apologies for the misinformation.
>
> In any event, the matter is not fundamental to fair queuing.
According to the code and Toke in FQ-Codel there are separate state 
variables for each queue,
whereas in FQ-PIE there is a single instance of state (see line 72-75 in 
sch_fq_pie.c
  <https://github.com/hironoriokano/fq-pie/blob/master/sch_fq_pie.c>). 
This is [should be] equivalent to a PIE queue
which uses FQ instead of FIFO as a child queue.

As I understand the FQ-Codel draft, it seems to be fundamental to 
FQ-Codel that each queue has separate state variables.
So my question is: is it indeed fundamental ?

P.S. comment on line sch_fq_pie.c  should probably be updated