[aqm] Warren Kumari's Yes on draft-ietf-aqm-codel-07: (with COMMENT)

Warren Kumari <warren@kumari.net> Fri, 07 April 2017 17:44 UTC

Return-Path: <warren@kumari.net>
X-Original-To: aqm@ietf.org
Delivered-To: aqm@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id A04CF1200C5; Fri, 7 Apr 2017 10:44:09 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Warren Kumari <warren@kumari.net>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-aqm-codel@ietf.org, aqm-chairs@ietf.org, wes@mti-systems.com, aqm@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.49.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <149158704960.11211.6016773961643040981.idtracker@ietfa.amsl.com>
Date: Fri, 07 Apr 2017 10:44:09 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/aqm/ldPAYDS7kwP1eWyoOD9w_NossH0>
Subject: [aqm] Warren Kumari's Yes on draft-ietf-aqm-codel-07: (with COMMENT)
X-BeenThere: aqm@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "Discussion list for active queue management and flow isolation." <aqm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/aqm>, <mailto:aqm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/aqm/>
List-Post: <mailto:aqm@ietf.org>
List-Help: <mailto:aqm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/aqm>, <mailto:aqm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Apr 2017 17:44:10 -0000

Warren Kumari has entered the following ballot position for
draft-ietf-aqm-codel-07: Yes

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-aqm-codel/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

I think that this is a useful document - I also think that it would make
a good introductory document to describe queuing for e.g a collage class.


I do have some readability suggestions to make it even better; these do
not need any action, but if the authors happen to edit the document for
any other reason, they may want to address them.

1: I found the overall structure of the document a little odd -- I'm
assuming that this is an artifact of its history, or merging multiple
documents into one, or similar. It starts off with a nice description of
queuing and CoDel. It then gets all technical with the pseudo-code (which
was really helpful). Where it feels a little odd is that it then suddenly
goes back to being much more introductory feeling (Section 5 - ), and
feels like it repeats some of the earlier material. Reformatting it all
to address this seems like overkill, but perhaps a readers note to
suggest people who want more background should skip ahead then come
back.

2: Section 1.  Introduction
- "determined set point derived from maximizing the network power metric"
-- I'd suggest referencing Section 5.2 where power is explained (or, if
we assume readers understand this, section 5.2 can be dropped).

3: Section 3.  Overview of the Codel AQM
Sojourn time is a really important concept in this document, but it isn't
really defined - Section 5.1 is closest to defining it, but still not
great.

4: Section 3.1
"The MTU size can be set adaptively to the largest packet seen so far or
can be read from the driver."
It was unclear what driver -- perhaps "interface driver" or simply
"interface"?

5: Section 3.2 has an opening parens but no closing one ("known or
measure (though ...").
This is a tiny nit, but set off my OCD tendencies :-)

6: Section 5.1
"We use this insight in the  pseudo-code for CoDel later in the draft.)
 - earlier in the draft...

Section 5.2: 
AIMD TCP could use a reference.