Re: [aqm] CoDel: After much ado ...

Jana Iyengar <jri@google.com> Sat, 30 September 2017 01:01 UTC

Return-Path: <jri@google.com>
X-Original-To: aqm@ietfa.amsl.com
Delivered-To: aqm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3C515134318 for <aqm@ietfa.amsl.com>; Fri, 29 Sep 2017 18:01:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TKSEdiu-AoXQ for <aqm@ietfa.amsl.com>; Fri, 29 Sep 2017 18:01:50 -0700 (PDT)
Received: from mail-yw0-x229.google.com (mail-yw0-x229.google.com [IPv6:2607:f8b0:4002:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 107211320D9 for <aqm@ietf.org>; Fri, 29 Sep 2017 18:01:49 -0700 (PDT)
Received: by mail-yw0-x229.google.com with SMTP id x131so820786ywa.10 for <aqm@ietf.org>; Fri, 29 Sep 2017 18:01:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LZo3ZMYPtV0nOAbLWeS0U4X3WWHkbq5JIEXHrU9ylU8=; b=Nbxm5K796BudXVhHkebLr3Y969bQxPjGbi/IsElP3QKPrxLN5enJeBp445dcGdW9vm Aksu5GH1ogc2D2eNlmzFqv+Lf5A9rVghomkk3gyIYypFzAjtY6v6WRmlsQfidnOi6k2W q2VcAiysfIIfL53VMXAKwVo/PnMrXcdAhLEpKsfwM/J2GguSy1hkGRA8Dn/uLkQe8blc P6u8BK2dBvqKqhHYCVpG5kU36MiD9s6a66DuPj5tlvna5WC2FTXLSJroKWsDk2Cay7mi E85xA/IkAAetxYeoedhl4uC7uA9tP8+yBKIRkmM2dzJn1vLvCd2ngr+K28/adrfVoTAK z4sw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LZo3ZMYPtV0nOAbLWeS0U4X3WWHkbq5JIEXHrU9ylU8=; b=q9cDphAFWVrtlzDcjWYKPPdw6Q/eQ2BCrVSGKDh3rbRbPbPumZrX+DVFdDXIpQxaUn WPRqHxDSwasnh6pwn/lsJ/oIuLtHuFJCUWO9648sqqbckdjMdxSurpZgdqd0vScAZzqb wdCEAZJworDr5lyO7NLrbF2itZClz+JxQA9ex78ZIG3XK7uj8AlrjZ1n2K+A3OWxapHj EclTYjoQw5zS6C0rmphbAcAurwkcBOXI8LFsKiczhLmXgrKKiFPx8BYsJG3mhyM1dhGD to6AT2adjgCA4vODZVKc6yPsn+qdPEA6LBAqdE43u0g4pz4ncGkapSKGytfgqlheIcfC jjGQ==
X-Gm-Message-State: AHPjjUgCzezEamXIgvFP7XbWYeevWWLEXFnSmekLoyGOs7DliMZ7OgY1 uLuPHsNFo9u3qXfpX1K8NQnnH+gmd8vEU8Of4t+sHQ==
X-Google-Smtp-Source: AOwi7QCUe4qEp60ndS7y2/tIdI++DTNa1DZOGVZ4xoAM0ubzvZEl9/SY4xxA37ayOPP9XjuSJfB1rchTKVWKuQGnoRM=
X-Received: by 10.37.132.73 with SMTP id r9mr7511063ybm.165.1506733305720; Fri, 29 Sep 2017 18:01:45 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.37.2.141 with HTTP; Fri, 29 Sep 2017 18:01:44 -0700 (PDT)
In-Reply-To: <E65E22D6-4264-4BB9-B0DC-26030AF54425@kuehlewind.net>
References: <CAGD1bZYxeFggM6HqrKgh07chGuj1ccGBTuxvAZ=gSVw_4murZg@mail.gmail.com> <E65E22D6-4264-4BB9-B0DC-26030AF54425@kuehlewind.net>
From: Jana Iyengar <jri@google.com>
Date: Fri, 29 Sep 2017 18:01:44 -0700
Message-ID: <CAGD1bZZ+NwOyp6mrAV1cXSsTvjVZoB0115kSSoo-avuxohRDbA@mail.gmail.com>
To: "Mirja Kuehlewind (IETF)" <ietf@kuehlewind.net>
Cc: aqm@ietf.org, "aqm-chairs@ietf.org" <aqm-chairs@ietf.org>, Van Jacobson <vanj@google.com>, Andrew McGregor <andrewmcgr@google.com>, Kathleen Nichols <nichols@pollere.net>
Content-Type: multipart/related; boundary="089e0826fee47adbdd055a5daf6e"
Archived-At: <https://mailarchive.ietf.org/arch/msg/aqm/vdY7AAH498lynxvmZ1ow2UyU6LM>
Subject: Re: [aqm] CoDel: After much ado ...
X-BeenThere: aqm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Discussion list for active queue management and flow isolation." <aqm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/aqm>, <mailto:aqm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/aqm/>
List-Post: <mailto:aqm@ietf.org>
List-Help: <mailto:aqm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/aqm>, <mailto:aqm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Sep 2017 01:01:54 -0000

Mirja,

Thanks for you review -- apologies for not addressing everything. I had
left a few things out as not necessary to change the draft, but we've now
made the following changes in draft-ietf-aqm-codel-09
<https://tools.ietf.org/html/draft-ietf-aqm-codel-09>;.

1) Did you also check the sec-art and gen-art review. Both, as well as some
> ADs, suggested to (better) define such terms as Sojourn time, estimator, or
> Interval. Would it make sense to add something to the terminology section,
> or did you decide this is not needed?
>

We've added these definitons now in Section 2.


> 2) Did you see Alia’s comments on mircoflows? I think it is true that in
> some cases you may also want to use additional information like the flow
> label or DSCP and not just the 5-tuple, while the text explicitly talks
> about 5-tuples. Do you want to add something here, or did you on purpose
> decide to only restrict to 5-tuples? I thinks this may be an unnecessary
> restriction and probably was not meant to be one.
>

We fixed the draft to remove mentions of 5-tuples. (This was already done
in -08.)


> 3) Did you see this comment from Ekr:
> "Following up on the above point, you must be able to
>   drop packets when the queue is entirely full, but S
>   4.4 doesn't seem to contemplate this. What is the impact
>   of this? You just drop and ignore?“
> Can you explain how this was addressed? Maybe I just missed that but it
> seems important.
>

There's nothing to be done if a packet arrives at a full buffer besides
dropping it... we've added a sentence now that says "Packets arriving at a
full buffer SHOULD be dropped." Hopefully that should clarify things.

Hope this covers everything that's pending -- let me know if I've missed
anything.

(I received jim-jam biscuits/cookies from Jim Gettys which helped with this
round -- thanks Jim :-))



- jana

Thanks!
> Mirja
>
>
>
>
> > Am 12.09.2017 um 02:27 schrieb Jana Iyengar <jri@google.com>;:
> >
> > ... draft-ietf-aqm-codel-08 is finally posted. This new version
> addresses all IESG comments during IESG review, in addition to review
> comments by Patrick Timmons and Yoav Nir. We thank everyone for their help
> with reviews.
> >
> > Most importantly, I want to personally thank the fq_codel authors for
> sending me Yerba Mate, Dave Taht for sending me delicious freshly-baked
> cookies, and Paul McKenney for sending me a ton of organic green tea to
> help me move on the document. I will say that you all managed to do
> something nobody has managed so far: you successfully shamed me into
> getting this work done.
> >
> > I also received bungee cords from the fq_codel authors to tie myself to
> my chair with, which I put to good use: I would like to share here evidence
> of my atonement. (Cookies are not in the picture, because they were
> delicious. Thanks, Dave!)
> >
> > - jana
> >
> > (P.S.: I now look forward to receiving thank you gifts. Oh, and I'm
> caffeine-free and vegetarian, just in case.)
> >
>
>