[art] Artart last call review of draft-ietf-httpbis-origin-h3-03

Henry Thompson via Datatracker <noreply@ietf.org> Tue, 28 February 2023 16:38 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: art@ietf.org
Delivered-To: art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B56DBC15257C; Tue, 28 Feb 2023 08:38:53 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Henry Thompson via Datatracker <noreply@ietf.org>
To: art@ietf.org
Cc: draft-ietf-httpbis-origin-h3.all@ietf.org, ietf-http-wg@w3.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 9.12.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <167760233373.37748.2541961884518801633@ietfa.amsl.com>
Reply-To: Henry Thompson <ht@inf.ed.ac.uk>
Date: Tue, 28 Feb 2023 08:38:53 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/art/qkgDv-VRaZng6Qf13fT6Y-RT7t8>
Subject: [art] Artart last call review of draft-ietf-httpbis-origin-h3-03
X-BeenThere: art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Applications and Real-Time Area Discussion <art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/art>, <mailto:art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/art/>
List-Post: <mailto:art@ietf.org>
List-Help: <mailto:art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/art>, <mailto:art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Feb 2023 16:38:53 -0000

Reviewer: Henry Thompson
Review result: Ready with Nits

I'm the designated ArtArt last call reviewer for this draft.

This is essentially a _pro forma_ update of the corresponding HTTP/2 document. 
It's substantially ready to go.

Three nits:

1) The readability of the main paragraph of section 2 could, I think, be
improved.

Instead of

   "Where [ORIGIN] indicates that the ORIGIN frame should be sent on Stream 0,
    this should be interpreted to mean the HTTP/3 control stream.
    The ORIGIN frame is sent from servers to clients on the server's control
    stream."

this should (unless I misunderstand it), be a new paragraph, something a bit
more explicit, e.g.:

   Where [ORIGIN] indicates that the ORIGIN frame should be sent on Stream 0,
   this should be interpreted to mean the appropriate HTTP/3 control stream:
   that is, the ORIGIN frame is sent from servers to clients on the server's
   (unidirectional) control stream.

2) To match the HTTP/2 and IANA registry entries, the table in section 4 should
read

    ORIGIN      0x0c    Section 2

3) Again in section 4, it took me rather a long time to chase down the actually
relevant bit of the '[IANA] "HTTP/3 Frame Type" registry [HTTP3]', which is not
in the referenced document at all.  Wouldn't a reference to the think itself,
https://www.iana.org/assignments/http2-parameters/http2-parameters.xhtml#frame-type,
be better here?

ht