From paul.wouters@aiven.io  Sun Dec 10 19:22:13 2023
Return-Path: <paul.wouters@aiven.io>
X-Original-To: auth48archive@ietfa.amsl.com
Delivered-To: auth48archive@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 74BE1C14F61D
 for <auth48archive@ietfa.amsl.com>; Sun, 10 Dec 2023 19:22:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level: 
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_QP_LONG_LINE=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01,
 URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001,
 URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=aiven.io
Received: from mail.ietf.org ([50.223.129.194])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 8eNfFJiJTzCT for <auth48archive@ietfa.amsl.com>;
 Sun, 10 Dec 2023 19:22:09 -0800 (PST)
Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com
 [IPv6:2a00:1450:4864:20::641])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 08A4CC14F601
 for <auth48archive@rfc-editor.org>; Sun, 10 Dec 2023 19:22:08 -0800 (PST)
Received: by mail-ej1-x641.google.com with SMTP id
 a640c23a62f3a-9e1021dbd28so530802566b.3
 for <auth48archive@rfc-editor.org>; Sun, 10 Dec 2023 19:22:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=aiven.io; s=google; t=1702264927; x=1702869727; darn=rfc-editor.org;
 h=to:in-reply-to:cc:references:message-id:date:subject:mime-version
 :from:content-transfer-encoding:from:to:cc:subject:date:message-id
 :reply-to; bh=9pKOzvGx3/PzSmCi0JnZGCA19xOn1nrhQh3ky2lyA+0=;
 b=U7GRKyt++embyKPGfvB5Mb8Hi3dLkUPoVRgNRYonwVUErUc7Z8rx3cx0WckJjr836g
 GtkdnE1stW32po4m2/ALQdwcW4MbOa3HtAjpDFn6w9xWxbj6FGpcs178g4zOzWxvMCSJ
 BG73hdnTJrSsegX328kOkkEpRyPoJj0hOQx34=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1702264927; x=1702869727;
 h=to:in-reply-to:cc:references:message-id:date:subject:mime-version
 :from:content-transfer-encoding:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=9pKOzvGx3/PzSmCi0JnZGCA19xOn1nrhQh3ky2lyA+0=;
 b=sUWjx7uh/Fh+brLcbDhLnF0AwOqWxhU1If6uvrot5/FWTh0Sf69rhZX0NB+Tp3sZPy
 E6YFXObn4AqFNWpjmvWYcWy8lypUKdYIbL3+KB1YEt/QFvmz9v/0F4Qe2yNqs5Mu460p
 Tdmf4EzEn7cIwxjWClCJL2c+1wWi6W0dF3c0Ji3dBgBFHqnK7d/WPDDBxg7qwSzI+6bW
 kZnSkeywfbZ/l8Q2muwgwYOQsdSeBNu9BBq5x/aWmbbLQSyGlfm7K53ui4AZCCf+7WzR
 E6XZUGYGZv1Ah5r1e0ieqjipMpdhqni7WDyYjtvEY6oIjZBR+oBQvSDSi4pmeJG324Wk
 2R7g==
X-Gm-Message-State: AOJu0YxN2kq2p6FmqrGsUHRGzGUK6Kb/EtjZGf+x3RGmnlP0mL+2N4p3
 5QBI2M29EM1vogiiHl5DcAmgiQ==
X-Google-Smtp-Source: AGHT+IGX9DqOVOzwKuXi4hzvq3te4h6CrTENtCdKs9PofGXXqP16aBX0I/eT+JtTfD16TDygrySklA==
X-Received: by 2002:a17:906:a8b:b0:9bd:9bfe:e40b with SMTP id
 y11-20020a1709060a8b00b009bd9bfee40bmr2313805ejf.75.1702264926990; 
 Sun, 10 Dec 2023 19:22:06 -0800 (PST)
Received: from smtpclient.apple ([74.122.52.94])
 by smtp.gmail.com with ESMTPSA id
 uv6-20020a170907cf4600b00a1f699e5217sm3910077ejc.135.2023.12.10.19.22.06
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 10 Dec 2023 19:22:06 -0800 (PST)
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Paul Wouters <paul.wouters@aiven.io>
Mime-Version: 1.0 (1.0)
Date: Sun, 10 Dec 2023 22:21:54 -0500
Message-Id: <421C3F18-9A85-457C-9889-596C26F4BEE7@aiven.io>
References: <00B8978E-2D81-42B6-9B1D-C6AD04B3BC06@amsl.com>
Cc: Martin Thomson <mt@lowentropy.net>,
 Shivan Kaul Sahib <shivankaulsahib@gmail.com>,
 auth48archive <auth48archive@rfc-editor.org>, ohai-ads@ietf.org,
 ohai-chairs@ietf.org, "Murray S. Kucherawy" <superuser@gmail.com>,
 Christopher Wood <caw@heapingbits.net>,
 Francesca Palombini <francesca.palombini@ericsson.com>,
 RFC Editor <rfc-editor@rfc-editor.org>
In-Reply-To: <00B8978E-2D81-42B6-9B1D-C6AD04B3BC06@amsl.com>
To: Sandy Ginoza <sginoza@amsl.com>
X-Mailer: iPhone Mail (21B101)
Archived-At: <https://mailarchive.ietf.org/arch/msg/auth48archive/E4erriQXzRdMAlPeNgNXgQQIYdM>
Subject: Re: [auth48] AUTH48: RFC-to-be 9458 <draft-ietf-ohai-ohttp-10> for
 your review
X-BeenThere: auth48archive@rfc-editor.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Archiving AUTH48 exchanges between the RFC Production Center,
 the authors, and other related parties" <auth48archive.rfc-editor.org>
List-Unsubscribe: <https://mailman.rfc-editor.org/mailman/options/auth48archive>, 
 <mailto:auth48archive-request@rfc-editor.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/auth48archive/>
List-Post: <mailto:auth48archive@rfc-editor.org>
List-Help: <mailto:auth48archive-request@rfc-editor.org?subject=help>
List-Subscribe: <https://mailman.rfc-editor.org/mailman/listinfo/auth48archive>, 
 <mailto:auth48archive-request@rfc-editor.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Dec 2023 03:22:13 -0000

It=E2=80=99s much better, but I do still see some issues.
Section 6 to 8 with all subsections are full of links to =E2=80=9CClients=E2=
=80=9D, which see seems too generic a term to provide a link for and, especi=
ally like 40+ times.


Sent using a virtual keyboard on a phone

> On Dec 8, 2023, at 12:54, Sandy Ginoza <sginoza@amsl.com> wrote:
>=20
> =EF=BB=BFHi Martin, Chris, ADs,
>=20
> We created a sample of what we hope is a reasonable compromise for your co=
nsideration.  Please review the following aspects in the sample file (https:=
//www.rfc-editor.org/authors/rfc9458-link-test.html):
>=20
> a) restored link color
> b) curated linking through Section 3. (Specifically, a term links to its d=
efinition upon first use in a section and when the definition might be usefu=
l.  For example, terms are intentionally linked again following Figure 1
> c) index entries (more details below)
>=20
> We propose index entries be formatted as in the example below for ease of t=
he reader.   In the updated document, you can see subentries under key confi=
guration for encoding and media type. =20
>=20
> key configuration   Section 3
> encoding   Section 3.1
> example of   Appendix A
> forward secrecy   Section 6.6
> integrity protection of   Section 6.1
> media type   Section 3.2, Section 6.9, Section 9.1
> policy application   Section 6.1
> privacy considerations   Section 7
> problems with   Section 5.3, Section 9.4, Section 9.5
> request encapsulation   Section 4.3
>=20
>=20
> Note that we are happy to create the index for this document.  For future d=
ocuments, we understand and sympathize with the desire to autogenerate an in=
dex.  We intend to provide guidance about index usefulness that can be added=
 to the Style Guide, and we will take autogeneration into consideration in c=
rafting that guidance.  In addition, Jean reviewed the index functionality a=
vailable in kramdown and will request some updates to the documentation.
>=20
> Please review and let us know if you agree with this path forward.
>=20
> Thanks,
> Sandy
>=20
>=20
>=20
>=20
>=20
>=20
>> On Nov 17, 2023, at 1:17 PM, Sandy Ginoza <sginoza@amsl.com> wrote:
>>=20
>> Hi Martin,
>>=20
>> Thanks for your review.  I restored the DOI for ODOH-PETS (thanks for cat=
ching that) and I posted the files with our usual naming conventions:
>>=20
>>  https://www.rfc-editor.org/authors/rfc9458.xml
>>  https://www.rfc-editor.org/authors/rfc9458.txt
>>  https://www.rfc-editor.org/authors/rfc9458.pdf
>>  https://www.rfc-editor.org/authors/rfc9458.html
>>=20
>> Diffs highlighting the most recent updates only:
>>  https://www.rfc-editor.org/authors/rfc9458-lastdiff.html
>>  https://www.rfc-editor.org/authors/rfc9458-lastrfcdiff.html
>>=20
>>=20
>> Diff between the author-submitted XML and the current XML:
>>  https://www.rfc-editor.org/authors/rfc9458-authors-17nov-rfcdiff.html
>>=20
>>=20
>> AUTH48 diff:
>>  https://www.rfc-editor.org/authors/rfc9458-auth48diff.html
>>=20
>> Comprehensive diffs:
>>  https://www.rfc-editor.org/authors/rfc9458-diff.html
>>  https://www.rfc-editor.org/authors/rfc9458-rfcdiff.html
>>=20
>>=20
>> I have not marked your approval on the AUTH48 page, as we await the follo=
wing:
>> - a response from RSAB regarding the links and index.  FYI: They have req=
uested some additional information which we are gathering.
>> - a new release of xml2rfc that includes =E2=80=9Cdeduplicate index entri=
es=E2=80=9D <https://github.com/ietf-tools/xml2rfc/pull/1050>.
>>=20
>>=20
>> Thanks,
>> Sandy
>>=20
>>=20
>>>> On Nov 16, 2023, at 7:08 PM, Martin Thomson <mt@lowentropy.net> wrote:
>>>=20
>>> Hi Sandy,
>>>=20
>>> Thanks for doing this.  I realize that this is a lot of work.
>>>=20
>>> I see a few tweaks to make on my end to reduce the drift further, but th=
is is a very clean diff and it matches what we produced fairly closely.
>>>=20
>>> I see only one possible error, but I can approve of this either way:
>>> * The ODOH-PETS paper reference lost a DOI: 10.2478/popets-2021-0085
>>>=20
>>> Cheers,
>>> Martin
>>>=20
>>> On Fri, Nov 17, 2023, at 10:56, Sandy Ginoza wrote:
>>>> Hi Martin,
>>>>=20
>>>> I think the following XML file resolves most of the formatting issues
>>>> that were causing such hard-to-review diffs:
>>>>=20
>>>> https://www.rfc-editor.org/authors/rfc9458-sg.xml
>>>>=20
>>>> This diff highlights the differences between the XML you provided and
>>>> the file mentioned above:
>>>> https://www.rfc-editor.org/authors/rfc9458-mt-sg-rfcdiff.html
>>>>=20
>>>> The outputs are available here:
>>>> https://www.rfc-editor.org/authors/rfc9458-sg.html
>>>> https://www.rfc-editor.org/authors/rfc9458-sg.pdf
>>>> https://www.rfc-editor.org/authors/rfc9458-sg.txt
>>>>=20
>>>> FYI: I left the references as you updated them (rather than us
>>>> xi:include), but I added anchors.  We also restored the full name
>>>> attribute (but included the surname and initial attributes also) and
>>>> refcontent element. =20
>>>>=20
>>>> We made some additional updates that may have been lost in the sea of
>>>> diffs.  Please review and let us know if you have any concerns.
>>>>=20
>>>> Thanks,
>>>> Sandy
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>>> On Nov 2, 2023, at 1:54 PM, Sandy Ginoza <sginoza@amsl.com> wrote:
>>>>>=20
>>>>> Hi Martin,
>>>>>=20
>>>>>> On Oct 23, 2023, at 2:58 AM, Martin Thomson <mt@lowentropy.net> wrote=
:
>>>>>>=20
>>>>>> I checked the XML.  The changes to line wrapping make it very hard fo=
r me to be certain that the changes are correct.
>>>>>>=20
>>>>>> Some observations:
>>>>>>=20
>>>>>> 1. There are quite a few tab characters inserted in the document.  Th=
is is probably the result of reformatting.  It's inconsistent though.
>>>>>=20
>>>>> We see what you=E2=80=99re saying; we=E2=80=99ll fix the file.  We=E2=80=
=99re looking into how the tabs were inserted. =20
>>>>>=20
>>>>>=20
>>>>>> 2. In the second-level of the IANA media type registrations, the "Mac=
intosh file type code(s)" item has an extra <t> around the text (i.e., "<dd>=
<t>N/A</t></dd>").  This seems unnecessary.
>>>>>=20
>>>>> Ack - we=E2=80=99ll remove them.
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>> 3. There is some weird whitespace preservation thing going on with so=
me of the attributes.  It's probably reformatting-related, but I see `<iref i=
tem=3D"Target         Resource"/><`  with nine spaces and a number of simila=
r problems.  The file I submitted doesn't have this problem, so it suggests t=
wo lots of reformatting.
>>>>>=20
>>>>> We believe this is related to item 1 - we=E2=80=99re working on it.
>>>>>=20
>>>>>=20
>>>>>>=20
>>>>>> 4. Our copy supplies fullname attributes for authors in references.  T=
hese have been turned into initials+surname, which is unnecessary and remove=
s information that we might use to fix references in future.
>>>>>=20
>>>>> Agree - we=E2=80=99ll restore the fullname attribute.
>>>>>=20
>>>>> We=E2=80=99ll let you know when an updated file is available. =20
>>>>>=20
>>>>> Thanks,
>>>>> Sandy
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>> Otherwise, I don't see any problems.  Though not seeing doesn't mean t=
hat they aren't there, given the level of obfuscation.
>>>>>>=20
>>>>>> On Thu, Oct 19, 2023, at 03:39, Sarah Tarrant wrote:
>>>>>>> Hello Martin,
>>>>>>>=20
>>>>>>> Thank you for your reply. We have updated our files with the changes=

>>>>>>> you provided. We have one followup comment.
>>>>>>>=20
>>>>>>> 1) Regarding this comment:
>>>>>>>=20
>>>>>>>> I have an author for [OHTTP-ANALYSIS], but as a git repository, per=
haps your policy is to avoid attribution in general (I'd prefer to include t=
he name if possible).
>>>>>>>=20
>>>>>>> We updated per =E2=80=9CReferencing Web-Based Public Code Repositori=
es (e.g.,
>>>>>>> GitHub)=E2=80=9D in the "Web Portion of the Style Guide=E2=80=9D
>>>>>>> (https://www.rfc-editor.org/styleguide/part2/#ref_repo).
>>>>>>>=20
>>>>>>>=20
>>>>>>> Updated XML file:
>>>>>>> http://www.rfc-editor.org/authors/rfc9458.xml
>>>>>>>=20
>>>>>>> Updated output files:
>>>>>>> https://www.rfc-editor.org/authors/rfc9458.html
>>>>>>> https://www.rfc-editor.org/authors/rfc9458.txt
>>>>>>> https://www.rfc-editor.org/authors/rfc9458.pdf
>>>>>>>=20
>>>>>>> Diff file showing all changes made during AUTH48:
>>>>>>> https://www.rfc-editor.org/authors/rfc9458-auth48diff.html
>>>>>>> https://www.rfc-editor.org/authors/rfc9458-auth48-rfcdiff.html
>>>>>>> (side-by-side diff)
>>>>>>>=20
>>>>>>> Comprehensive Diffs:
>>>>>>> https://www.rfc-editor.org/authors/rfc9458-diff.html
>>>>>>> https://www.rfc-editor.org/authors/rfc9458-rfcdiff.html (side-by-sid=
e diff)
>>>>>>>=20
>>>>>>> Note that it may be necessary for you to refresh your browser to vie=
w
>>>>>>> the most recent version.
>>>>>>>=20
>>>>>>> For the AUTH48 status of this document, please see:
>>>>>>> https://www.rfc-editor.org/auth48/rfc9458
>>>>>>>=20
>>>>>>> Thank you,
>>>>>>> RFC Editor/st
>>>>>>>=20
>>>>>>>> On Oct 16, 2023, at 9:39 PM, Martin Thomson <mt@lowentropy.net> wro=
te:
>>>>>>>>=20
>>>>>>>> Bullet 5 in S 4.3
>>>>>>>>=20
>>>>>>>> -       Encrypted Request (enc_request).
>>>>>>>> +       Encapsulated Request (enc_request).
>>>>>>>>=20
>>>>>>>> S 4.4 uses inconstent comma/paren groupings:
>>>>>>>>=20
>>>>>>>> -   context, rctxt, as the HPKE context (context) as follows:
>>>>>>>> +   context (rctxt) as the HPKE context (context) as follows:
>>>>>>>>=20
>>>>>>>> S 6.2.3 missed a capitalization:
>>>>>>>>=20
>>>>>>>> -   The time at which Encapsulated Request or response messages are=
 sent
>>>>>>>> +   The time at which Encapsulated Request or Response messages are=
 sent
>>>>>>>>=20
>>>>>>>> I have an author for [OHTTP-ANALYSIS], but as a git repository, per=
haps your policy is to avoid attribution in general (I'd prefer to include t=
he name if possible).
>>>>>>>>=20
>>>>>>>> [ODOH-PETS] is marked "Volume 2021, Issue 4, pp. 575-592", but I th=
ink that it should be "PoPETS Volume ..." instead.
>>>>>>>>=20
>>>>>>>> [UWT] should be "W3C TAG Finding" rather than just "W3C TAG".
>>>>>>>>=20
>>>>>>>> Reviewing the XML of this document is essentially impossible.  A wh=
ole bunch of line folding was introduced.  I'll need some more time for that=
.
>>>>>>>>=20
>>>>>>>> On Tue, Oct 17, 2023, at 07:54, Sarah Tarrant wrote:
>>>>>>>>> Hello Martin and Murray*,
>>>>>>>>>=20
>>>>>>>>> Murray* - please review the last sentence of paragraph 2 in Sectio=
n 7
>>>>>>>>> and let us know if you approve. This change is best viewed in this=
 diff
>>>>>>>>> file: https://www.rfc-editor.org/authors/rfc9458-auth48diff.html
>>>>>>>>>=20
>>>>>>>>> Martin, thank you for your reply. We have updated our xml file wit=
h the
>>>>>>>>> changes you provided. All of our questions have been addressed.
>>>>>>>>>=20
>>>>>>>>> Regarding this comment:
>>>>>>>>>=20
>>>>>>>>>> I don't know how to ensure that links are formatted correctly.  T=
his is an XML-level change that I'm deferring, but I wanted to point out tha=
t we're using anchors (https://www.iana.org/assignments/hpke/hpke.xhtml#hpke=
-aead-ids) where you changed to bare URLs (https://www.iana.org/assignments/=
hpke in the same place).  I wanted to confirm whether this was deliberate.
>>>>>>>>>=20
>>>>>>>>> Yes, this change was deliberate. IANA has asked us to use the bare=
 URLs
>>>>>>>>> (without anchors) as they are more stable. We use the bare IANA UR=
Ls in
>>>>>>>>> running text and in IANA reference entries. See =E2=80=9CReferenci=
ng IANA
>>>>>>>>> Registries=E2=80=9D in the =E2=80=9CWeb Portion of the Style Guide=
=E2=80=9D
>>>>>>>>> (https://www.rfc-editor.org/styleguide/part2/#ref_iana_reg).
>>>>>>>>>=20
>>>>>>>>> Updated XML file:
>>>>>>>>> http://www.rfc-editor.org/authors/rfc9458.xml
>>>>>>>>>=20
>>>>>>>>> Updated output files:
>>>>>>>>> https://www.rfc-editor.org/authors/rfc9458.html
>>>>>>>>> https://www.rfc-editor.org/authors/rfc9458.txt
>>>>>>>>> https://www.rfc-editor.org/authors/rfc9458.pdf
>>>>>>>>>=20
>>>>>>>>> Diff file showing all changes made during AUTH48:
>>>>>>>>> https://www.rfc-editor.org/authors/rfc9458-auth48diff.html
>>>>>>>>>=20
>>>>>>>>> Comprehensive Diffs:
>>>>>>>>> https://www.rfc-editor.org/authors/rfc9458-diff.html
>>>>>>>>> https://www.rfc-editor.org/authors/rfc9458-rfcdiff.html (side-by-s=
ide diff)
>>>>>>>>>=20
>>>>>>>>> Note that it may be necessary for you to refresh your browser to v=
iew
>>>>>>>>> the most recent version.
>>>>>>>>>=20
>>>>>>>>> For the AUTH48 status of this document, please see:
>>>>>>>>> https://www.rfc-editor.org/auth48/rfc9458
>>>>>>>>>=20
>>>>>>>>> Thank you,
>>>>>>>>> RFC Editor/st
>>>>>>>>>=20
>>>>>>>>>=20
>>>>>>>>>> On Oct 15, 2023, at 5:56 PM, Martin Thomson <mt@lowentropy.net> w=
rote:
>>>>>>>>>>=20
>>>>>>>>>> Hi Sandy,
>>>>>>>>>>=20
>>>>>>>>>> These links should not be displayed with any decoration.  They do=
n't appear to be as far as I can see, in any of the styles we presently use.=
  Is there a version of this document that I'm unaware of and that is being s=
tyled differently?
>>>>>>>>>>=20
>>>>>>>>>> The fact that xml2rfc generates multiple index entries is a bug: h=
ttps://github.com/ietf-tools/xml2rfc/issues/988
>>>>>>>>>>=20
>>>>>>>>>> The use of cref is automated in our authoring tools and would be d=
ifficult to apply selectively.
>>>>>>>>>>=20
>>>>>>>>>> Cheers,
>>>>>>>>>> Martin
>>>>>>>>>>=20
>>>>>>>>>> On Sat, Oct 14, 2023, at 04:39, Sandy Ginoza wrote:
>>>>>>>>>>> Authors,
>>>>>>>>>>>=20
>>>>>>>>>>> The goal of links and an index in a document is to help the read=
er
>>>>>>>>>>> navigate that document. This document includes links that are no=
t
>>>>>>>>>>> visually differentiable from the surrounding text (except upon h=
over),
>>>>>>>>>>> so it is difficult for the reader to discover them.
>>>>>>>>>>>=20
>>>>>>>>>>> However, once the links are shown with color, their current
>>>>>>>>>>> overabundance can be distracting and confusing to the reader. In=

>>>>>>>>>>> addition, the large number of index entries makes it difficult f=
or the
>>>>>>>>>>> reader to determine where they should look for information. For
>>>>>>>>>>> example, there are 91 entries for Oblivious Gateway Resource, an=
d many
>>>>>>>>>>> instances appear within the same paragraph and subsequent paragr=
aphs
>>>>>>>>>>> (e.g., "Section 6, Paragraph 8; Section 6, Paragraph 8; Section 6=
.2,
>>>>>>>>>>> Paragraph 1; Section 6.2, Paragraph 1"). Similarly, there are 15=
0
>>>>>>>>>>> entries for Client and 52 more for Clients. For some of the term=
s, they
>>>>>>>>>>> are linked in close proximity, and some are even linked within t=
heir
>>>>>>>>>>> own definitions. We recommend trimming both links and index entr=
ies
>>>>>>>>>>> down to instances that aid the reader. In addition to having a m=
ore
>>>>>>>>>>> useful index, link color will no longer be distracting.
>>>>>>>>>>>=20
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Sandy
>>>>>>>>>>>=20
>>>>>>>>>>>=20
>>>>>>>>>>>> On Oct 9, 2023, at 6:37 PM, Martin Thomson <mt@lowentropy.net> w=
rote:
>>>>>>>>>>>>=20
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>=20
>>>>>>>>>>>> Thanks for sending this over.
>>>>>>>>>>>>=20
>>>>>>>>>>>> https://github.com/ietf-wg-ohai/oblivious-http/pull/289 is wher=
e we're tracking changes for our own review.  I've started to port your chan=
ges over there and have attached an updated XML file that should match yours=
 (mostly).
>>>>>>>>>>>>=20
>>>>>>>>>>>> I have only reviewed the text diff at this stage, so things lik=
e references will be very different in this version of the XML.  I plan to g=
o over XML changes once this round of edits is sorted out.
>>>>>>>>>>>>=20
>>>>>>>>>>>> Responses inline below, but first I have a few things to point o=
ut.
>>>>>>>>>>>>=20
>>>>>>>>>>>> I don't know how to ensure that links are formatted correctly. =
 This is an XML-level change that I'm deferring, but I wanted to point out t=
hat we're using anchors (https://www.iana.org/assignments/hpke/hpke.xhtml#hp=
ke-aead-ids) where you changed to bare URLs (https://www.iana.org/assignment=
s/hpke in the same place).  I wanted to confirm whether this was deliberate.=

>>>>>>>>>>>>=20
>>>>>>>>>>>> Chris and I have rejected some changes:
>>>>>>>>>>>>=20
>>>>>>>>>>>> S5:
>>>>>>>>>>>> -   request, which the Client makes to the Target Resource, div=
erges from
>>>>>>>>>>>> +   request, which the Clients make to the Target Resource, div=
erges from
>>>>>>>>>>>>=20
>>>>>>>>>>>> (There is only one capital-C Oblivious HTTP Client as the subje=
ct of this statement.  This might have been confused as the preceding statem=
ent talked about that Client being an HTTP client in two separate contexts.)=

>>>>>>>>>>>>=20
>>>>>>>>>>>> S5.1:
>>>>>>>>>>>> -   This encapsulation does not permit progressive processing o=
f
>>>>>>>>>>>> +   This encapsulation does not permit the progressive processi=
ng of
>>>>>>>>>>>>=20
>>>>>>>>>>>> In IANA considerations, the media type registrations are extrem=
ely long if a compact list is not used.  I've made tweaks to layout based on=
 your changes that should improve things like line wrapping, but I think tha=
t this is better left in a compact form.
>>>>>>>>>>>>=20
>>>>>>>>>>>> There are also a few other minor edits for consistency, as note=
d below.  These relate to capitalization (client->Client in particular) and m=
ore use of parentheses in algorithms.
>>>>>>>>>>>>=20
>>>>>>>>>>>> Cheers,
>>>>>>>>>>>> Martin
>>>>>>>>>>>>=20
>>>>>>>>>>>> On Sat, Oct 7, 2023, at 09:06, rfc-editor@rfc-editor.org wrote:=

>>>>>>>>>>>>> 1) <!--[rfced] Note that the updates that were approved by the=
 AD in
>>>>>>>>>>>>> versions -09 and -10 have been incorporated. Please review and=

>>>>>>>>>>>>> let us know if any further updates are needed.
>>>>>>>>>>>>=20
>>>>>>>>>>>> I can confirm that the changes are in place.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 2) <!-- [rfced] Please insert any keywords (beyond those that a=
ppear in the
>>>>>>>>>>>>> title) for use on https://www.rfc-editor.org/search.
>>>>>>>>>>>>> -->
>>>>>>>>>>>>=20
>>>>>>>>>>>> Added privacy, proxy, partitioning, tunnel
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 3) <!-- [rfced] The SVG figures in Sections 2 and 6.5.2 have w=
idth or height
>>>>>>>>>>>>> specified, which will make the artwork not scale.
>>>>>>>>>>>>=20
>>>>>>>>>>>> Yes, this is fine.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 4) <!-- [rfced] Please review the following questions related t=
o the use
>>>>>>>>>>>>> of "<tt>".
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> a) In the html and pdf outputs, the text enclosed in <tt> is
>>>>>>>>>>>>> output in fixed-width font. In the txt output, there are no
>>>>>>>>>>>>> changes to the font, and the quotation marks have been
>>>>>>>>>>>>> removed. Please review carefully and let us know if the output=
 is
>>>>>>>>>>>>> acceptable or if any updates are needed.
>>>>>>>>>>>>=20
>>>>>>>>>>>> This is acceptable.  We use this for function names and HTTP fi=
eld names, which are generally able to be distinguished based on context and=
 the use of CapTaliZaTiOn.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> b) Should any of the following terms be formatted with <tt>
>>>>>>>>>>>>> for consistency?
>>>>>>>>>>>>> c) We notice that the "Date" and "Vary" header fields are encl=
osed
>>>>>>>>>>>>> with <tt>.  Should any of the other header field names be encl=
osed
>>>>>>>>>>>>> with <tt> for consistency?
>>>>>>>>>>>>=20
>>>>>>>>>>>> Yes, for all of these.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> d) Is it intentional for some terms to be enclosed with both <=
tt>
>>>>>>>>>>>>> and quotation marks? For example: "message/ohttp-req" and
>>>>>>>>>>>>> "message/ohttp-res". Please let us know if any updates are nee=
ded.
>>>>>>>>>>>>=20
>>>>>>>>>>>> This was deliberate.  Quotes are safe to use with media types a=
nd it is my belief that these require this additional marking for documents i=
n text format as they lack the case distinctions of the former.  I'm not fir=
m on this though, the quotes could probably be dropped (what I really want i=
s something to stop these from wrapping unnecessarily).
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 5) <!-- [rfced] Please review the "type" attribute of each sou=
rcecode
>>>>>>>>>>>>> element in the XML file to ensure correctness.
>>>>>>>>>>>>=20
>>>>>>>>>>>> Verified.  I've marked some as pseudocode.  However, you note t=
wo instance of tls-syntax, where I was able to spot only one.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 6) <!--[rfced] Section 3.1. We updated the "HPKE KDF Identifie=
rs"
>>>>>>>>>>>>> registry to the "HPKE KEM Identifiers" registry since it appli=
es
>>>>>>>>>>>>> to the "HPKE KEM ID". Please let us know if this is not correc=
t.
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> Original:
>>>>>>>>>>>>> HPKE KEM ID:
>>>>>>>>>>>>> A 16 bit value that identifies the Key Encapsulation Method
>>>>>>>>>>>>> (KEM) used for the identified key as defined in Section 7.1
>>>>>>>>>>>>> of [HPKE] or the HPKE KDF IANA registry.
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> Current:
>>>>>>>>>>>>> HPKE KEM ID:
>>>>>>>>>>>>> A 16-bit value that identifies the KEM used for the identified=
 key
>>>>>>>>>>>>> as defined in Section 7.1 of [HPKE] or the "HPKE KEM Identifie=
rs"
>>>>>>>>>>>>> IANA registry <https://www.iana.org/assignments/hpke>.
>>>>>>>>>>>>> -->
>>>>>>>>>>>>=20
>>>>>>>>>>>> I have this using <eref, which renders using parentheses rather=
 than angle brackets.  Otherwise, I think we're good.  I think that this is a=
 change that was made in our repository that didn't make it into -10.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 7) <!--[rfced] Section 4.3. May we add parentheses to this bul=
let point
>>>>>>>>>>>>> as follows for easier readability? Please let us know your
>>>>>>>>>>>>> preference.
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> Original:
>>>>>>>>>>>>> *  a combination of KDF, identified by kdf_id, and AEAD, ident=
ified
>>>>>>>>>>>>> by aead_id, that the Client selects from those in the key
>>>>>>>>>>>>> configuration.
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> Perhaps:
>>>>>>>>>>>>> *  a combination of KDF (identified by kdf_id) and AEAD (ident=
ified
>>>>>>>>>>>>> by aead_id) that the Client selects from those in the key
>>>>>>>>>>>>> configuration.
>>>>>>>>>>>>> -->
>>>>>>>>>>>>=20
>>>>>>>>>>>> There is a consistency issue here.  Other bullets used commas. =
 I think that we can lean on parentheses more if we're careful.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 8) <!-- [rfced] Please review whether any of the notes in this=
 document
>>>>>>>>>>>>> should be in the <aside> element.
>>>>>>>>>>>>=20
>>>>>>>>>>>> It's hard to answer this question without an example.  I could f=
ind a couple of places where it might work, but those were in lists, where I=
'm less confident about what that might render as.  I don't see any places w=
here this would help.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 9)
>>>>>>>>>>>>> Perhaps:
>>>>>>>>>>>>> 2.  Builds info by concatenating the ASCII-encoded string "mes=
sage/
>>>>>>>>>>>>> bhttp request"; a zero-byte; key_id as an 8-bit integer; and
>>>>>>>>>>>>> kem_id, kdf_id, and aead_id as three 16-bit integers.
>>>>>>>>>>>>> -->
>>>>>>>>>>>>=20
>>>>>>>>>>>> Semi-colons can act as comma's big sister here, sure.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 10)
>>>>>>>>>>>>> Perhaps:
>>>>>>>>>>>>> 6.  Encrypt response, passing the AEAD function Seal with the v=
alues
>>>>>>>>>>>>> of aead_key, aead_nonce, an empty aad, and a pt input of respo=
nse,
>>>>>>>>>>>>> which yields ct.
>>>>>>>>>>>>=20
>>>>>>>>>>>> Maybe instead:
>>>>>>>>>>>>=20
>>>>>>>>>>>> Encrypt `response` by passing the AEAD function Seal the values=
 of
>>>>>>>>>>>> `aead_key`, `aead_nonce`, an empty `aad`, and a `pt` input of
>>>>>>>>>>>> `response`. This yields `ct`.
>>>>>>>>>>>>=20
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 11)
>>>>>>>>>>>>> Current:
>>>>>>>>>>>>> The request, which the Clients make to the Target Resource,
>>>>>>>>>>>>> diverges from typical HTTP assumptions about the use of a
>>>>>>>>>>>>> connection (see Section 3.3 of [HTTP]) in that the request
>>>>>>>>>>>>> and response are encrypted rather than sent over a connection.=

>>>>>>>>>>>>> -->
>>>>>>>>>>>>=20
>>>>>>>>>>>> I've gone with:
>>>>>>>>>>>> The request, which the Client makes to the Target Resource, div=
erges
>>>>>>>>>>>>=20
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 12)
>>>>>>>>>>>>> Current:
>>>>>>>>>>>>> The problem type [PROBLEM] of "https://iana.org/assignments/ht=
tp-
>>>>>>>>>>>>> problem-types#ohttp-key" is defined in this section.
>>>>>>>>>>>>=20
>>>>>>>>>>>> Sure.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 13)
>>>>>>>>>>>>> Perhaps:
>>>>>>>>>>>>> This ensures that Oblivious Gateway Resources are not
>>>>>>>>>>>>> misused to forward traffic to arbitrary Target
>>>>>>>>>>>>> Resources.
>>>>>>>>>>>>=20
>>>>>>>>>>>> Yes, good.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 14)
>>>>>>>>>>>>> Perhaps:
>>>>>>>>>>>>> While TLS might be
>>>>>>>>>>>>> intercepted successfully, intercepted middlebox devices might n=
ot
>>>>>>>>>>>>> receive updates that would allow Oblivious HTTP to be correctl=
y
>>>>>>>>>>>>> identified using the media types defined in Sections 9.2 and 9=
.3.
>>>>>>>>>>>>=20
>>>>>>>>>>>> This is a middlebox that exist to intercept, so I believe "inte=
rception middlebox devices" is correct.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 15) <!-- [rfced] Some author comments are present in the XML.
>>>>>>>>>>>>=20
>>>>>>>>>>>> Yes, this exist to aid us in drafting, specifically to help reg=
enerate examples when things change.  We don't need (or want) those to be pu=
blished.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 16) <!-- [rfced] Terminology
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> a) Throughout the text, the following terminology appears to b=
e capitalized
>>>>>>>>>>>>> inconsistently. Please review these occurrences and let us kno=
w if/how they
>>>>>>>>>>>>> may be made consistent. =20
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> client vs. Client:
>>>>>>>>>>>>> Client
>>>>>>>>>>>>> client
>>>>>>>>>>>>> HTTP client
>>>>>>>>>>>>> Oblivious HTTP Client
>>>>>>>>>>>>> per-Client
>>>>>>>>>>>>=20
>>>>>>>>>>>> This is tricky, but here are the rules we're following:
>>>>>>>>>>>>=20
>>>>>>>>>>>> 1. HTTP uses "client", we use "HTTP client" when we refer speci=
fically to something that is exclusively performing HTTP functions.  This wa=
s consistent.
>>>>>>>>>>>>=20
>>>>>>>>>>>> 2. Oblivious HTTP uses "Client" when referring to the rule it d=
efines (which is mostly just an HTTP client) and so that is capitalized ever=
ywhere.  (That is the first, fourth, and fifth items on this list.)
>>>>>>>>>>>>=20
>>>>>>>>>>>> 3. Some of the introductory text talks generically about client=
s, which are things that make requests of servers.  There, because it is tal=
king about a generic concept, these are just "client" without qualification.=
.
>>>>>>>>>>>>=20
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> key identifier vs. Key Identifier vs. key ID
>>>>>>>>>>>>> key identifier (9)
>>>>>>>>>>>>> Key Identifier (5)
>>>>>>>>>>>>> key ID (1)
>>>>>>>>>>>>=20
>>>>>>>>>>>> The capitalized form refers exclusively to a field as encoded. =
 Otherwise, we're using lowercase.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> nonce vs. Nonce vs. Nonce field
>>>>>>>>>>>>> Nonce (3)
>>>>>>>>>>>>> nonce (29)
>>>>>>>>>>>>> Nonce field (1)
>>>>>>>>>>>>=20
>>>>>>>>>>>> Again, the capitalized form refers exclusively to the field in t=
he message.  I've tweaked the text to make this clearer.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> plaintext Request (1) vs.
>>>>>>>>>>>>> plaintext request (1) vs.
>>>>>>>>>>>>> plaintext Response (1) vs.
>>>>>>>>>>>>> plaintext request and response (1)
>>>>>>>>>>>>=20
>>>>>>>>>>>> This was indeed correct, because the odd capitalization was ref=
erring to structures in messages as shown in diagrams, with case that matche=
d.  I've tweaked this a little to make that clearer by re-captioning the mes=
sage and using matching words to highlight the parallelism.
>>>>>>>>>>>>=20
>>>>>>>>>>>>=20
>>>>>>>>>>>>> b) We updated the following terms to the latter forms shown be=
low for
>>>>>>>>>>>>> consistency. Please let us know of any concerns.
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> encapsulated KEM shared secret -> Encapsulated KEM Shared Secr=
et (1)
>>>>>>>>>>>>=20
>>>>>>>>>>>> Please revert, RFC 9180 uses "enc is an encapsulated KEM shared=
 secret".
>>>>>>>>>>>>=20
>>>>>>>>>>>>> encapsulated request -> Encapsulated Request (2)
>>>>>>>>>>>>=20
>>>>>>>>>>>> Great.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> encapsulated response -> Encapsulated Response (5)
>>>>>>>>>>>>> Encapsulated Requests and responses -> Encapsulated Requests a=
nd Responses (1)
>>>>>>>>>>>>=20
>>>>>>>>>>>> Also good.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> b) Please confirm if the case for these terms is okay as is
>>>>>>>>>>>>> or if you would like to make any changes.
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> Client request (both words are lowercase in RFC 9110)
>>>>>>>>>>>>=20
>>>>>>>>>>>> The cases I see are specific on the first (this is an OHTTP Cli=
ent) and non-specific on the second (this is just a request in the abstract)=
.  That's probably sloppy, but I see no need to fix that.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> encrypted request (lowercase in all RFCs)
>>>>>>>>>>>>> encrypted requests and responses
>>>>>>>>>>>>=20
>>>>>>>>>>>> In some cases, those needed to be Encapsulated Request(s), whic=
h I've corrected.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> HTTP request (lowercase in RFC 9110)
>>>>>>>>>>>>> HTTP requests and responses
>>>>>>>>>>>>> HTTP request-response
>>>>>>>>>>>>=20
>>>>>>>>>>>> This is correct.  When talking about HTTP, we use HTTP lowercas=
ing.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> 17) <!-- [rfced] Please review the "Inclusive Language" portio=
n of the online
>>>>>>>>>>>>> Style Guide <https://www.rfc-editor.org/styleguide/part2/#incl=
usive_language>
>>>>>>>>>>>>> and let us know if any changes are needed.
>>>>>>>>>>>>=20
>>>>>>>>>>>> Acknowledged and validated.  I couldn't see anything either.
>>>>>>>>>>>>=20
>>>>>>>>>>>>> The files are available here:
>>>>>>>>>>>>> https://www.rfc-editor.org/authors/rfc9458.xml
>>>>>>>>>>>>> https://www.rfc-editor.org/authors/rfc9458.html
>>>>>>>>>>>>> https://www.rfc-editor.org/authors/rfc9458.pdf
>>>>>>>>>>>>> https://www.rfc-editor.org/authors/rfc9458.txt
>>>>>>>>>>>> <draft-ietf-ohai-ohttp.xml>
>>>>>>=20
>>>>>=20
>>>=20
>>=20
>=20

