Re: [AVTCORE] Comments on the draft-ietf-avtcore-srtp-aes-gcm-06

"Igoe, Kevin M." <kmigoe@nsa.gov> Thu, 11 July 2013 12:46 UTC

Return-Path: <kmigoe@nsa.gov>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E97F21F9A50 for <avt@ietfa.amsl.com>; Thu, 11 Jul 2013 05:46:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.598
X-Spam-Level:
X-Spam-Status: No, score=-10.598 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IH+6Gk+0LciN for <avt@ietfa.amsl.com>; Thu, 11 Jul 2013 05:46:39 -0700 (PDT)
Received: from nsa.gov (emvm-gh1-uea09.nsa.gov [63.239.67.10]) by ietfa.amsl.com (Postfix) with ESMTP id 86D5B11E811A for <avt@ietf.org>; Thu, 11 Jul 2013 05:46:35 -0700 (PDT)
X-TM-IMSS-Message-ID: <2d31e497000ca4c8@nsa.gov>
Received: from MSHT-GH1-UEA02.corp.nsa.gov ([10.215.227.181]) by nsa.gov ([63.239.67.10]) with ESMTP (TREND IMSS SMTP Service 7.1; TLSv1/SSLv3 AES128-SHA (128/128)) id 2d31e497000ca4c8 ; Thu, 11 Jul 2013 08:51:27 -0400
Received: from MSMR-GH1-UEA01.corp.nsa.gov (10.215.225.4) by MSHT-GH1-UEA02.corp.nsa.gov (10.215.227.181) with Microsoft SMTP Server (TLS) id 14.2.342.3; Thu, 11 Jul 2013 08:46:22 -0400
Received: from MSMR-GH1-UEA03.corp.nsa.gov ([10.215.224.3]) by MSMR-GH1-UEA01.corp.nsa.gov ([10.215.225.4]) with mapi id 14.02.0342.003; Thu, 11 Jul 2013 08:46:22 -0400
From: "Igoe, Kevin M." <kmigoe@nsa.gov>
To: 'Woo-Hwan Kim' <whkim5@ensec.re.kr>, "avt@ietf.org" <avt@ietf.org>, "draft-ietf-avtcore-srtp-aes-gcm@tools.ietf.org" <draft-ietf-avtcore-srtp-aes-gcm@tools.ietf.org>
Thread-Topic: [AVTCORE] Comments on the draft-ietf-avtcore-srtp-aes-gcm-06
Thread-Index: AQHOcvZdyF8XiGfZnU6WzSL8YTGH5plfgpCw
Date: Thu, 11 Jul 2013 12:46:21 +0000
Message-ID: <3C4AAD4B5304AB44A6BA85173B4675CAB243CD51@MSMR-GH1-UEA03.corp.nsa.gov>
References: <CAMRi9Ccc9qFYok8tAooPfPWMBxqBuhgnPaAv18bZ9ieaBezrkw@mail.gmail.com>
In-Reply-To: <CAMRi9Ccc9qFYok8tAooPfPWMBxqBuhgnPaAv18bZ9ieaBezrkw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.215.224.46]
Content-Type: multipart/alternative; boundary="_000_3C4AAD4B5304AB44A6BA85173B4675CAB243CD51MSMRGH1UEA03cor_"
MIME-Version: 1.0
Cc: Magnus Westerlund <magnus.westerlund@ericsson.com>, Daesung Kwon <ds_kwon@ensec.re.kr>, Je Hong Park <jhpark@ensec.re.kr>
Subject: Re: [AVTCORE] Comments on the draft-ietf-avtcore-srtp-aes-gcm-06
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/avt>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jul 2013 12:46:44 -0000

Many thanks for the observations.  I think draft -07 (which I put out
before I saw your note) caught most of the errors you point out.
Your time and effort in reviewing the draft are greatly appreciated.

From: woohwankim@gmail.com [mailto:woohwankim@gmail.com] On Behalf Of Woo-Hwan Kim
Sent: Thursday, June 27, 2013 1:23 AM
To: avt@ietf.org; draft-ietf-avtcore-srtp-aes-gcm@tools.ietf.org
Cc: Je Hong Park; Daesung Kwon; Magnus Westerlund
Subject: [AVTCORE] Comments on the draft-ietf-avtcore-srtp-aes-gcm-06

Hi.

Here are some comments on the draft-ietf-avtcore-srtp-aes-gcm-06.

1. In section 5.2, Tag_Size_Flag is used for CCM mode input and it is written that the tag size for GCM mode is determined by the algorithm choice.
There is no difference between CCM and GCM from the point of view that the ciphersuite can determine the tag length.
CCM needs tag length in the input formatting function while GCM does not.
But I think it does not imply that the inputs of GCM and CCM differ and it is better to be consistent.

2. AES-CCM ciphersuites is defined for each tag length except but Section 14.1.
I think it is better to add the following ciphersuites in Section 14.1 as well as other parts of the draft.
- AEAD_AES_128_CCM_8
- AEAD_AES_256_CCM_8
- AEAD_AES_128_CCM_12
- AEAD_AES_256_CCM_12



3. Section 6, Section 11.1
 (2^24)-16 octets => (2^28)-16 octets

Regards, Woo-Hwan Kim