Re: [AVTCORE] [MMUSIC] Confirmation call on draft-ietf-avtcore-rfc5764-mux-fixes-09

Marc Petit-Huguenin <marc@petit-huguenin.org> Tue, 05 July 2016 16:27 UTC

Return-Path: <marc@petit-huguenin.org>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB96F12D635; Tue, 5 Jul 2016 09:27:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SXP8wdB6a9VF; Tue, 5 Jul 2016 09:27:56 -0700 (PDT)
Received: from implementers.org (implementers.org [IPv6:2604:3400:dc1:41:216:3eff:fe5b:8240]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AC31C12D640; Tue, 5 Jul 2016 09:27:49 -0700 (PDT)
Received: from [IPv6:2601:648:8380:d0:b000:c523:5e3:37d3] (unknown [IPv6:2601:648:8380:d0:b000:c523:5e3:37d3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "Marc Petit-Huguenin", Issuer "implementers.org" (verified OK)) by implementers.org (Postfix) with ESMTPS id 57672207C7; Tue, 5 Jul 2016 18:27:47 +0200 (CEST)
To: Magnus Westerlund <magnus.westerlund@ericsson.com>, IETF AVTCore WG <avt@ietf.org>, "tram@ietf.org" <tram@ietf.org>, ice@ietf.org, "tls@ietf.org" <tls@ietf.org>, "mmusic (E-mail)" <mmusic@ietf.org>, "draft-ietf-avtcore-rfc5764-mux-fixes@ietf.org" <draft-ietf-avtcore-rfc5764-mux-fixes@ietf.org>
References: <edd5512f-57c7-25e1-0f19-19bba38968a2@ericsson.com> <10a73efe-2e50-77ed-e78f-298d388efb47@ericsson.com>
From: Marc Petit-Huguenin <marc@petit-huguenin.org>
Message-ID: <4da07aaf-6340-e866-801e-1c6bd78d0d2e@petit-huguenin.org>
Date: Tue, 5 Jul 2016 09:27:38 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0
MIME-Version: 1.0
In-Reply-To: <10a73efe-2e50-77ed-e78f-298d388efb47@ericsson.com>
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OEdkAEJ0HRTBEXDrfGK5H20FvaBIE4dwd"
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/7fR8e6jaa4f8p7Dw16kPtse3zSM>
Subject: Re: [AVTCORE] [MMUSIC] Confirmation call on draft-ietf-avtcore-rfc5764-mux-fixes-09
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2016 16:27:58 -0000

Hi Magnus,

We just published version -10.  See below for some comments.

On 06/28/2016 07:35 AM, Magnus Westerlund wrote:
> Authors and WGs,
> 
> In my review for the publication writeup I did spot some issues in the draft. Please consider the following issues:
> 
> 1. Abstract: With the addition of the ZRTP the abstract should benefit from being updated. The ZRTP protocol being possible to multiplex is missing as well as that there are now 4 issues.

Fixed.

> 
> 2. Abstract contains [ref] to RFC 5764. This is an ID nit.

Fixed.

> 
> 3. Section 1. The introduction is not explicitly saying that it updates RFC 5764. I think that can be put as a sentence after:
> 
>    This is achieved by
>    modifying the IANA registries with instructions for coordination
>    between the protocols at risk.

We incorporated this in that sentence and also added it into the abstract.

> 
> 4. Reference ID-nits:
> 
>   == Outdated reference: A later version (-31) exists of
>      draft-ietf-mmusic-sdp-bundle-negotiation-23

Fixed.

> 
> 5. Section 2:
> 
> ID-nits complains about the modified boilerplate for the RFC2119 text. First of all one usually don't cut down the list to only the used ones. The requirement on all caps ones I am very divided about. I do have a preference for unmodified boilerplate, this as I otherwise have to explain in the write-up the ID-nit.

Fixed.

> 
> 6. Section 6:
> 
>    In order to prevent future documents from assigning values from the
>    unused range to a new protocol, this document modifies the RFC 5764
>    demultiplexing algorithm to properly account for TURN channels by
>    allocating the values from 64 to 79 for this purpose.
> 
> I think this text fails to be explicit about that this restricts the TURN Channel space to a more limited set of possible channels when the TURN client does the channel binding request. Thus affecting the TURN channel allocation algorithm in the client implementations, at least when used in combination of muxing.

Fixed.

> 
> Based on this and the fact that this specification changes the IANA registrations performed by RFC5766, I think this document to have "Updates" for RFC5766 also. So please add that in header, abstract and introduction.

Based on our understanding and looking at other RFCs, just updating an IANA registry does not imply a update to the core specification, so we did not made that change.

> 
> 7. Updates RFC5389:
> 
> Looking at the impact also on the STUN protocol I would also think that this requires and "Updates" also for RFC 5389.
> 

Based on the argument above, we do not think that this warrants an "Updates" status.

> 
> 8. Section 10.3:
> 
> The IANA registry name is not the correct one. The IANA page says that the registry name is:
> 
> Traversal Using Relays around NAT (TURN) Channel Numbers
> http://www.iana.org/assignments/stun-parameters/stun-parameters.xhtml#turn-channel
> 
> Please update.

Fixed.

> 
> 9. Section 12.2:
> 
> The reference to ZRTP [RFC6189] is likely in the wrong category, at the same time moving this to a normative one creates a downref. I guess it one that has to be accepted in this case. I suggest that you move it to the normative references.

We are keeping it informative for now, but we will forward the discussion with the AD to the mailing-list as requested.

-- 
Marc Petit-Huguenin
Email: marc@petit-huguenin.org
Blog: http://blog.marc.petit-huguenin.org
Profile: http://www.linkedin.com/in/petithug