Re: [AVTCORE] Francesca Palombini's No Objection on draft-ietf-payload-vp9-13: (with COMMENT)

Jonathan Lennox <jonathan.lennox@8x8.com> Thu, 03 June 2021 21:35 UTC

Return-Path: <jonathan.lennox@8x8.com>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 482D13A1C1E for <avt@ietfa.amsl.com>; Thu, 3 Jun 2021 14:35:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=8x8.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KqDvnwUc0Dao for <avt@ietfa.amsl.com>; Thu, 3 Jun 2021 14:35:51 -0700 (PDT)
Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 69E713A1BEC for <avt@ietf.org>; Thu, 3 Jun 2021 14:35:43 -0700 (PDT)
Received: by mail-qv1-xf35.google.com with SMTP id a7so3962852qvf.11 for <avt@ietf.org>; Thu, 03 Jun 2021 14:35:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=8x8.com; s=googlemail; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=qB8slUQYbLqfluKsrXgtaorUOi1sbVKIXvHW1AqLcSE=; b=pLnbAJT9B2c3mcV2lkPYofqRqaTHfHW2NnYyQ4KKBi7nXVB29b98eHa649ffxiirUS p7/ZdPbpQJnlw6OEu9Z4s75uQCjPMzyuba44nRXL0TJpAd1S3anroyjK/xtmrPB8cnMt NuHRoCAYt9ZUF1E85kNOgs5oQ9Fllz3iPAO+Y=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=qB8slUQYbLqfluKsrXgtaorUOi1sbVKIXvHW1AqLcSE=; b=rQYEuqlcjm79uxR+ZK/uDBwbTnNEWd/5iRbkNVDLuXen5ip5gHFqpydBIxTSW5J4Ir riOnrX/BY5UzvJPIbqMH6SAGU3PTDHN5xvnKDgmYGZ1oOdAYo+EwHnC8ZY826LrD2jpI uKKC8AQijs0ksLDgrO1PLPGVtT1XyR71CenKSY1ZOFnmDXWjy70F172ClFX0BngV8wbv z2AAyh6pi75em+tzW+lPiD+Z96ZvkWeakKFpXVWF1K9FCtPBrvAAYkVg3PxYJSw7Ih2V FHDAdArjgONMIj3EVMdvUE6LsoZ6huN3ZPhKIL6heFRXkAMaAhvLq5EEvp0E+qMap6Tc +uzg==
X-Gm-Message-State: AOAM531If8lFKgsiCgy0/eFtc0XSLGe1kMEhT7u63juF2BtjqQAakuBW 4PsTmCNEepQ6CHcRt2c5Iaozlw==
X-Google-Smtp-Source: ABdhPJy6uh5IoZF5eWAQhs20ExgD7YPaWT7ejKzHlIK6bbv0Au57sN2GbuC6p7NFLk/xFUZ1qBRSSw==
X-Received: by 2002:a0c:b30f:: with SMTP id s15mr1663626qve.34.1622756141458; Thu, 03 Jun 2021 14:35:41 -0700 (PDT)
Received: from smtpclient.apple (c-24-0-149-15.hsd1.nj.comcast.net. [24.0.149.15]) by smtp.gmail.com with ESMTPSA id c20sm2484177qtm.52.2021.06.03.14.35.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Jun 2021 14:35:41 -0700 (PDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\))
From: Jonathan Lennox <jonathan.lennox@8x8.com>
In-Reply-To: <162258327985.8847.198932314624656592@ietfa.amsl.com>
Date: Thu, 3 Jun 2021 17:35:40 -0400
Cc: The IESG <iesg@ietf.org>, draft-ietf-payload-vp9@ietf.org, avtcore-chairs@ietf.org, avt@ietf.org, bernard.aboba@gmail.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <AC637E4E-8BFC-4DBA-BDA4-E3B82899156C@8x8.com>
References: <162258327985.8847.198932314624656592@ietfa.amsl.com>
To: Francesca Palombini <francesca.palombini@ericsson.com>
X-Mailer: Apple Mail (2.3654.80.0.2.43)
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/8DTBzGUDp-BCQTV-mM3wTLQkAng>
Subject: Re: [AVTCORE] Francesca Palombini's No Objection on draft-ietf-payload-vp9-13: (with COMMENT)
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jun 2021 21:36:07 -0000


> On Jun 1, 2021, at 5:34 PM, Francesca Palombini via Datatracker <noreply@ietf.org> wrote:
> 
> Francesca Palombini has entered the following ballot position for
> draft-ietf-payload-vp9-13: No Objection
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thank you for the work on this document.
> 
> I have some non blocking questions and comments, which I hope will help improve
> the document.
> 
> Francesca
> 
> 1. -----
> 
>   Timestamp:  The RTP timestamp indicates the time when the input frame
>      was sampled, at a clock rate of 90 kHz.  If the input picture is
>      encoded with multiple layer frames, all of the frames of the
>      picture MUST have the same timestamp.
> 
> FP: I think it would be useful to add a reference to RFC 3550, regarding "RTP
> timestamp". Also, I find it curious that RFC 3550 is not mentioned up to the
> end of section 4.1 (I would think a reference to it would be present in the
> introduction)

Added to both places, thanks.

> 2. -----
> 
>      Otherwise, PID MUST NOT be present.  If the SS field was present
>      in the stream's most recent start of a keyframe (i.e., non-
>      flexible scalability mode is in use), then the PID MUST also be
>      present in every packet.
> 
> FP: Is there any reason why this is not formulated in terms of V bit being set?
> (I believe the rest of the text is consistently talking about bit being set)

No, fixed.

> 
> 3. -----
> 
>      described by "Reference indices" below.  This MUST only be set to
>      1 if the I bit is also set to one; if the I bit is set to zero,
>      then this MUST also be set to zero and ignored by receivers.  The
> 
> FP: Why is that the it MUST only be set to 1 if I is also set to 1? I was
> looking for the motivation, but could not find it. Some more text would have
> been helpful to me.

The Reference indices are defined as offsets from the Picture ID, so without I, there’s nothing for them to reference.  I’ve added a parenthetical to clarify this.

> 4. -----
> 
>   Z:  Not a reference frame for upper spatial layers.  If set to 1,
>      indicates that frames with higher spatial layers SID+1 of the
>      current and following pictures do not depend on the current
> 
> FP: I am not sure if the text it meant to say higher spatial layers than SID+1
> (inclusive?)

Yes, 

> 5. -----
> 
>     The field MUST be present if the I bit is equal to one.  If set,
>      the PID field MUST contain 15 bits; otherwise, it MUST contain 7
> 
> FP: "If set" - I understand by the context this should be "If M is set" (how
> it's written now it could be interpreted by "if the PID field is set", which
> does not make sense, but better be clear)

Ok.

> 
> 6. -----
> 
>      or 15-bit index.  The PID SHOULD start on a random number, and
>      MUST wrap after reaching the maximum ID (0x7f or 0x7fff depending
>      on the index size chosen).  The receiver MUST NOT assume that the
> 
> FP: So is the intention that the PID is increased by one for each picture? Does
> the order matter? The way the text is written "reaching the maximum ID" would
> suggest so, but I could not find any text about that, if I have missed it
> please let me know.

Yes, I’ve clarified this.

> 
> 7. -----
> 
>       SID-1 frame of the same picture, otherwise MUST set to zero.
> 
> FP: s/MUST set/MUST be set

Ok.

> 
> 8. -----
> 
>         depends on.  TL0PICIDX MUST be incremented when TID is equal to
>         0.  The index SHOULD start on a random number, and MUST restart
> 
> FP: Does it matter by how much? If so, it should be stated.

By 1, thanks, clarified.

> 
> 9. -----
> 
>      temporal layer ID (TID), switch up point (U), and the R reference
>      indices (P_DIFFs) are specified.
> 
> FP: I couldn't find the R bit defined anywhere. I assume its meaning is "if
> set, P_DIFF is present" but this should be clearly stated in the text.

I think that was just a typo for “Reference indices”, fixed.

> 
> 10. -----
> 
> FP: Please expand MCU, LRR on first use

Expanded LRR; changed MCU to selective forwarding middlebox with a reference to RFC 7667.

> 11. -----
> 
> Section 7. IANA
> 
> FP: I checked the mailarchive for the subtype registration and could not find
> it. I leave it to Murray to let me know if we are more lenient about subtype
> requests, but I would have appreciated the registration being posted to the
> media-types mailing list.

Sorry about that; with my AVTCore chair hat on we’ve probably been sloppy about sending RTP-only subtypes to the media-types mailing list.