[AVT] Comments on draft-ietf-avt-rfc2793bis-03.txt

Magnus Westerlund <magnus.westerlund@ericsson.com> Wed, 24 March 2004 16:25 UTC

Received: from optimus.ietf.org (optimus.ietf.org [132.151.1.19]) by ietf.org (8.9.1a/8.9.1a) with ESMTP id LAA04327 for <avt-archive@odin.ietf.org>; Wed, 24 Mar 2004 11:25:43 -0500 (EST)
Received: from localhost.localdomain ([127.0.0.1] helo=www1.ietf.org) by optimus.ietf.org with esmtp (Exim 4.20) id 1B6BBo-0002CT-HQ for avt-archive@odin.ietf.org; Wed, 24 Mar 2004 11:25:15 -0500
Received: (from exim@localhost) by www1.ietf.org (8.12.8/8.12.8/Submit) id i2OGPCEB008456 for avt-archive@odin.ietf.org; Wed, 24 Mar 2004 11:25:12 -0500
Received: from localhost.localdomain ([127.0.0.1] helo=www1.ietf.org) by optimus.ietf.org with esmtp (Exim 4.20) id 1B6BBg-0002B1-PR; Wed, 24 Mar 2004 11:25:04 -0500
Received: from odin.ietf.org ([132.151.1.176] helo=ietf.org) by optimus.ietf.org with esmtp (Exim 4.20) id 1B6BB1-00025k-J7 for avt@optimus.ietf.org; Wed, 24 Mar 2004 11:24:24 -0500
Received: from ietf-mx (ietf-mx.ietf.org [132.151.6.1]) by ietf.org (8.9.1a/8.9.1a) with ESMTP id LAA04288 for <avt@ietf.org>; Wed, 24 Mar 2004 11:24:21 -0500 (EST)
Received: from ietf-mx ([132.151.6.1]) by ietf-mx with esmtp (Exim 4.12) id 1B6BB0-0000fe-00 for avt@ietf.org; Wed, 24 Mar 2004 11:24:22 -0500
Received: from exim by ietf-mx with spam-scanned (Exim 4.12) id 1B6BA6-0000d8-00 for avt@ietf.org; Wed, 24 Mar 2004 11:23:27 -0500
Received: from albatross-ext.wise.edt.ericsson.se ([193.180.251.49]) by ietf-mx with esmtp (Exim 4.12) id 1B6B9Z-0000ZM-00 for avt@ietf.org; Wed, 24 Mar 2004 11:22:53 -0500
Received: from esealmw140.al.sw.ericsson.se ([153.88.254.121]) by albatross-ext.wise.edt.ericsson.se (8.12.10/8.12.10/WIREfire-1.8b) with ESMTP id i2OGMqqY017752 for <avt@ietf.org>; Wed, 24 Mar 2004 17:22:52 +0100 (MET)
Received: from esealnt613.al.sw.ericsson.se ([153.88.254.125]) by esealmw140.al.sw.ericsson.se with Microsoft SMTPSVC(6.0.3790.0); Wed, 24 Mar 2004 17:22:51 +0100
Received: from ericsson.com (research-1fd0e1.ki.sw.ericsson.se [147.214.34.102]) by esealnt613.al.sw.ericsson.se with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2657.72) id HJS1DJZ6; Wed, 24 Mar 2004 17:22:51 +0100
Message-ID: <4061B5DB.9020705@ericsson.com>
Date: Wed, 24 Mar 2004 17:22:51 +0100
X-Sybari-Trust: 24962acb 2c4885b5 63750edc 00000138
From: Magnus Westerlund <magnus.westerlund@ericsson.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 (ax)
X-Accept-Language: sv, en-us, en
MIME-Version: 1.0
To: Gunnar Hellstrom <gunnar.hellstrom@omnitor.se>, "Paul E. Jones" <paulej@packetizer.com>
CC: IETF AVT WG <avt@ietf.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 24 Mar 2004 16:22:51.0501 (UTC) FILETIME=[40FC31D0:01C411BC]
X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on ietf-mx.ietf.org
X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.60
Content-Transfer-Encoding: 7bit
Subject: [AVT] Comments on draft-ietf-avt-rfc2793bis-03.txt
Sender: avt-admin@ietf.org
Errors-To: avt-admin@ietf.org
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.0.12
Precedence: bulk
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Id: Audio/Video Transport Working Group <avt.ietf.org>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
Content-Transfer-Encoding: 7bit

Hi,

Here is my comments from a review of this draft. As this draft was 
intended I will be extra hard on the ID nits, see link on:
http://www.ietf.org/ID.html

1. The whole draft has 15 extra left columns. This can't be there, there 
is a strict requirement on maximum of 72 columns of text.

2. The correct page breaks are missing.

3. The author list contains a blank line.

4. The first line in the left column of the header says AVT Working 
Group. Of historic reasons it should say "Network Working Group"

5. The updated boiler plate according to RFC 3667 and RFC 3668 must be 
used.

6. The RFC editor notes on the first page, are to early. Please move 
them back, at least to after the TOC. But this is also commonly a 
section at the end of the draft.

7. Section 3. I think this section is mixing to many things into one 
brew. I have previously complained on the structure. I think that a 
simple restructuring of the draft would help immensely. I would propose 
the following:
In section 3 define the RTP payload format, RTP header fields, and other 
things directly related to the payload.

Create a new section for on usage of RFC 2198 redundancy. This would 
basically be moving section, 3.4, 3.5, 3.8, 3.9 and parts of 4.3 into 
this new section.

8. Section 3.1: I think this section need to be a bit clearer on what it 
defines. Currently it says:

   "A text conversation RTP packet as specified by the text/t140 payload
    format consists of an RTP header as defined in RFC 3550 [2] followed
    immediately by a block of T.140 data, referred to as a "T140block"
    (see section 3.3).  There are no additional headers specific to this
    payload format."

I would suggest that this is reformulated to:

The text/t140 conversation RTP payload format consists of one and only 
one block of T.140 data, referred to as a "T140block" (see section 3.3). 
There are no additional headers specific to this payload format. The 
fields in the RTP header is set as defined in section 3.7.

The problem with the old text is that it doesn't clearly define what the 
RTP payload was. Instead it defined an RTP packet, which when combined 
with RFC 2198 never exist in the described form. Because then the RTP 
header has its field defined per RFC 2198, and also the payload is per 
RFC 2198. Also due to text later in the discussion on usage of the 
redundancy there is need for a clear understanding of what the RTP 
payload is.

9. Same as 8 but for section 3.2.

10. Section 3.4: "The T140blocks MAY be transmitted redundantly 
according to the payload format defined in RFC 2198 [3]." Please replace 
  "T140blocks" with the "t140 RTP payloads". Reason is that RFC 2198 
sends RTP payloads redundantly.

11. Section 3.6: "Association of RTP streams is dependent on the 
particular session application and is outside the scope of this 
document." Please remove "session".

12. Section 4.2: "With both text/t140 and audio/t140, the loss of the 
last packet of a sequence of packets cannot be detected until the next 
text packet is transmitted." Please replace transmitted, with received. 
The receiver needs to get a new sequence number or T140 block counter to 
be able to determine if things has become lost.

13. Section 4.3:
   "As an alternative (or in addition) to redundancy, Forward Error
    Correction mechanisms MAY be used when transmitting text, as per RFC
    2733 [8] or any other mechanism with the purpose of increasing the
    reliability of text transmission."

This text is redundant with section 3.5. Please gather things in one place.

14. Section 5.
   "To control the character transmission rate, the MIME parameter "cps="
    in the "fmtp" attribute [7] is defined (see section 8 ). It is used
    in SDP with the following syntax: "

The parameter is named "cps" not "cps=" The equal sign is a result of 
the name value pair that is used in fmtp lines.

15. Section 5, last paragraph. The network is another reason why a 
receiver may receive higher character rates. For example buffering that 
is more quickly sent than gathered could give this behaviour.

16. Section 6.3:
   "Below is an example of SDP similar to the above example, but also
    utilizing RFC 2198 to provide redundancy for the text packets:

        m=text 11000 RTP/AVP 98 100
        a=rtpmap:98 t140/1000
        a=rtpmap:100 red/1000
        a=fmtp:100 98/98 "

I think one should point out in this text that one signals only that one 
will use on layer of text redundancy. IF one would use three levels of 
redundancy then the fmtp line would read:
    a=fmtp:100 98/98/98/98

17. Section 11, The SRTP reference is only informative. A normative 
reference is something that one has a normative dependency of in this 
specification.

18. Don't forget to update section 13, and 14.

And please go through the ID-Nits list. I have not checked everything on 
this list, but I expect you to do it.

Cheers



-- 

Magnus Westerlund

Multimedia Technologies, Ericsson Research EAB/TVA/A
----------------------------------------------------------------------
Ericsson AB                | Phone +46 8 4048287
Torshamsgatan 23           | Fax   +46 8 7575550
S-164 80 Stockholm, Sweden | mailto: magnus.westerlund@ericsson.com



This communication is confidential and intended solely for the addressee(s). Any unauthorized review, use, disclosure or distribution is prohibited. If you believe this message has been sent to you in error, please notify the sender by replying to this transmission and delete the message without disclosing it. Thank you.

E-mail including attachments is susceptible to data corruption, interruption, unauthorized amendment, tampering and viruses, and we only send and receive e-mails on the basis that we are not liable for any such corruption, interception, amendment, tampering or viruses or any consequences thereof.


_______________________________________________
Audio/Video Transport Working Group
avt@ietf.org
https://www1.ietf.org/mailman/listinfo/avt