Re: [AVTCORE] draft-ietf-avtcore-multi-party-rtt-mix-08.txt - please review

Gunnar Hellström <gunnar.hellstrom@ghaccess.se> Mon, 12 October 2020 14:35 UTC

Return-Path: <gunnar.hellstrom@ghaccess.se>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E79F43A152C for <avt@ietfa.amsl.com>; Mon, 12 Oct 2020 07:35:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.112
X-Spam-Level:
X-Spam-Status: No, score=-2.112 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, NICE_REPLY_A=-0.213, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=egensajt.se
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CjedThx1BIk1 for <avt@ietfa.amsl.com>; Mon, 12 Oct 2020 07:35:07 -0700 (PDT)
Received: from smtp.egensajt.se (smtp.egensajt.se [193.42.159.246]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6B3673A1525 for <avt@ietf.org>; Mon, 12 Oct 2020 07:35:05 -0700 (PDT)
Received: from [192.168.2.137] (h77-53-37-134.cust.a3fiber.se [77.53.37.134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: gunnar.hellstrom@ghaccess.se) by smtp.egensajt.se (Postfix) with ESMTPSA id 3F50F201DE; Mon, 12 Oct 2020 16:35:03 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=egensajt.se; s=dkim; t=1602513303; bh=+FB2d9xnHCr/DWGERGFyQl0HujhslcuORxTlOCKWx7E=; h=Subject:To:References:From:Date:In-Reply-To:From; b=hFo1NZBIQxjZXgfdXJXGQnlKmP1AbOaFHUUsDyF2FPxZlCzwj64DQ1EnsxCOITv4/ w0zmdIFNwJ7hNKj9qKMsjf6P+6dPjHy819ZbOSRKRDpqhZuUf/dcL2b6cxumENNXaF VMgnv4ouPNNHKtF1N/dGDctxZZvAyrF4FXf1XkXA=
To: Paul Kyzivat <pkyzivat@alum.mit.edu>, avt@ietf.org
References: <159725784100.26501.7801603611291404620@ietfa.amsl.com> <cea92434-e74b-2fba-dc29-f1b29f5e22d9@ghaccess.se> <7c6ab084-95b6-1c07-fa78-c280a7a0ca6b@ghaccess.se> <7f90dd6d-8a66-bc7c-0865-d1ce566c2306@alum.mit.edu>
From: =?UTF-8?Q?Gunnar_Hellstr=c3=b6m?= <gunnar.hellstrom@ghaccess.se>
Message-ID: <62ab2139-6a5b-7116-a54a-abbb6ea95b69@ghaccess.se>
Date: Mon, 12 Oct 2020 16:35:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <7f90dd6d-8a66-bc7c-0865-d1ce566c2306@alum.mit.edu>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: sv
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/ICBVcuEMKtzhcc8oLRkCvqaom0A>
Subject: Re: [AVTCORE] draft-ietf-avtcore-multi-party-rtt-mix-08.txt - please review
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Oct 2020 14:35:12 -0000

Paul, thanks for the review,

I have accepted all your proposals and done the easy ones in my draft.

Will continue with the proposed restructuring of section 2.1.

See a few comments below.

Thanks,

Gunnar

Den 2020-10-10 kl. 20:50, skrev Paul Kyzivat:
> Gunnar,
>
> I haven't commented on this for some time because it seemed to be 
> progressing well and those contributing know more about RTP and RTT 
> than I do. Now that it seems to be approaching technical completeness 
> (and because I was asked) I have reviewed it again. Here are my thoughts:
>
> * Section 1:
>
> s/by shorting the/by shortening the/
Accepted and Done
>
>
> * Section 2.1:
>
> Why was "rtt-mix-rtp-mixer" chosen as the name of the attribute? It 
> seems cumbersome and redundant. Wouldn't "rtt-mixer" be sufficient?
Yes, a better name may be needed.
draft-hellstrom-avtcore-multi-party-rtt-solutions has in sections 6.3 
and 6.4 a discussion on the sdp attribute. I agree that the name is long 
and maybe confusing. The thought is that the first part, "rtt-mix", 
indicates the purpose: to indicate support for a type of mixer for 
real-time text. The second part, "rtp-mixer", indicates what type of 
mixer that is supported. It is the rtp-mixer style as described in RFC 
3550.

There is no plan right now, but it would be possible that later work 
specifies another mixer type as an alternative. It could be a 
multi-stream mixer using the rtp-translator style from RFC 3550. That 
work could then register another attribute, e.g. called 
"rtt-mix-rtp-translator". That is not sufficiently likely to motivate 
the effort to now create an attribute with values, but the reasoning 
motivated a name that indicates both the purpose and the solution.

That said, looking at your name proposal "rtt-mixer", I find that it can 
meet the criteria. "rtt-" indicates that it is about real-time text, and 
"mixer" can be taken to mean the "rtp-mixer" style. It was also used as 
the name in early versions of this draft.

So, the simple conclusion is: Yes, accepted and done.

>
> * Section 2.1.18.3:
>
> There are two instances of "deduct" here that I think should be "deduce".
Accepted and done
>
> * Section 2.1.20:
>
> In the first and second paragraphs the reference to "this section" is 
> unclear. I presume it means section 2.1 rather than section 2.1.20 or 
> section 2.
Yes, done.
>
> In the second paragraph:  s/the the/the/
Accepted and done
>
> The third paragraph seems inappropriate for this section of the 
> document, since this section is intended to apply only in cases where 
> "rtt-mix-rtp-mixer" *has* been negotiated.
>
Accepted -  will do together with next.
> * Section 2.2:
>
> The document specifies two alternative mechanisms, one in 2.1 and the 
> other in 2.2. But the formatting is very weird because section 2.1 is 
> long and detailed while section 2.2 is very short and delegates 
> everything to section 3.2.
>
> I suggest reorganizing the document to make this cleaner. E.g., move 
> most of the content of content of section 2.1 (all the 2.1.x sections) 
> to a new top level section. Then replace that with a small high level 
> discussion of the alternative and a delegation to the new section for 
> the details.
Accepted - will do
>
> * Section 3.1:
>
> You talk about "When text is received from multiple original sources 
> simultaneously". The meaning of "simultaneously" is pretty fuzzy here. 
> Do you think this is sufficient for implementors? You may want to say 
> more.

It is intended to say that each source has its own insertion point in 
the presentation areas and that text can be added to any of these 
insertion points in real time. That is approximately what is said in the 
paragraph above the sentence.

So maybe the sentence is not needed.

I suggest to change it to:

"When text is received from multiple original sources, the presentation 
SHOULD provide a view where text is added in multiple presentation fields."

>
> * Section 8.1:
>
> Please just omit "Attribute syntax:  a=rtt-mix-rtp-mixer". It is only 
> for attributes that have values.
Accepted and done.
>
> That's all. Generally looking good.
>
>     Thanks,
>     Paul
>
> On 10/9/20 3:36 PM, Gunnar Hellström wrote:
>> I would like to get review comments on 
>> draft-ietf-avtcore-multi-party-rtt-mix-08.txt.
>>
>> There are three small changes pending:
>>
>> 1. The reference to the WebRTC transport of T.140 real-time text is 
>> about to be changed from 
>> draft-ietf-mmusic-t140-usage-data-channel-14.txt to RFC 8865, but 
>> even if RFC 8865 is ready, it is awaiting common publication of a 
>> cluster of WebRTC related drafts.
>>
>> 2. A bit more detail in section 2.1.23 about the recovery situations 
>> in case of packet loss.
>>
>> 3. Correction of a minor error  in 2.1.23, where "A1" in the text 
>> under packet 6 should be "A3".
>>
>> Any further comments would be appreciated so that the draft can be 
>> progressed.
>>
>> /Gunnar
>>
>>
>> Den 2020-08-12 kl. 20:52, skrev Gunnar Hellström:
>>> A new version of the "RTP-mixer formatting of multi-party Real-time 
>>> text" is available.
>>>
>>> This version moves forward with only two methods for multi-party 
>>> mixing of RTP transported real-time text.
>>>
>>> The major one is RFC 4103 with transmission interval of 100 ms when 
>>> there is text from more than one source to transmit, and source 
>>> indicated in the CSRC list.
>>>
>>> The second one is the fallback for the situation that the endpoint 
>>> does not have multi-party capability.
>>>
>>> Regards
>>>
>>> Gunnar
>>>
>>> Den 2020-08-12 kl. 20:44, skrev internet-drafts@ietf.org:
>>>> A New Internet-Draft is available from the on-line Internet-Drafts 
>>>> directories.
>>>> This draft is a work item of the Audio/Video Transport Core 
>>>> Maintenance WG of the IETF.
>>>>
>>>>          Title           : RTP-mixer formatting of multi-party 
>>>> Real-time text
>>>>          Author          : Gunnar Hellstrom
>>>>     Filename        : draft-ietf-avtcore-multi-party-rtt-mix-08.txt
>>>>     Pages           : 36
>>>>     Date            : 2020-08-12
>>>>
>>>> Abstract:
>>>>     Real-time text mixers for multi-party sessions need to identify 
>>>> the
>>>>     source of each transmitted group of text so that the text can be
>>>>     presented by endpoints in suitable grouping with other text 
>>>> from the
>>>>     same source.
>>>>
>>>>     Regional regulatory requirements specify provision of real-time 
>>>> text
>>>>     in multi-party calls.  RFC 4103 mixer implementations can use
>>>>     traditional RTP functions for source identification, but the mixer
>>>>     source switching performance is limited when using the default
>>>>     transmission characteristics with redundancy.
>>>>
>>>>     Enhancements for RFC 4103 real-time text mixing is provided in 
>>>> this
>>>>     document, suitable for a centralized conference model that enables
>>>>     source identification and source switching.  The intended use 
>>>> is for
>>>>     real-time text mixers and multi-party-aware participant endpoints.
>>>>     The specified mechanism build on the standard use of the CSRC 
>>>> list in
>>>>     the RTP packet for source identification.  The method makes use of
>>>>     the same "text/red" format as for two-party sessions.
>>>>
>>>>     A capability exchange is specified so that it can be verified 
>>>> that a
>>>>     participant can handle the multi-party coded real-time text 
>>>> stream.
>>>>     The capability is indicated by use of a media attribute 
>>>> "rtt-mix-rtp-
>>>>     mixer".
>>>>
>>>>     The document updates RFC 4103[RFC4103]
>>>>
>>>>     A specifications of how a mixer can format text for the case 
>>>> when the
>>>>     endpoint is not multi-party aware is also provided.
>>>>
>>>>
>>>> The IETF datatracker status page for this draft is:
>>>> https://datatracker.ietf.org/doc/draft-ietf-avtcore-multi-party-rtt-mix/ 
>>>>
>>>>
>>>> There are also htmlized versions available at:
>>>> https://tools.ietf.org/html/draft-ietf-avtcore-multi-party-rtt-mix-08
>>>> https://datatracker.ietf.org/doc/html/draft-ietf-avtcore-multi-party-rtt-mix-08 
>>>>
>>>>
>>>> A diff from the previous version is available at:
>>>> https://www.ietf.org/rfcdiff?url2=draft-ietf-avtcore-multi-party-rtt-mix-08 
>>>>
>>>>
>>>>
>>>> Please note that it may take a couple of minutes from the time of 
>>>> submission
>>>> until the htmlized version and diff are available at tools.ietf.org.
>>>>
>>>> Internet-Drafts are also available by anonymous FTP at:
>>>> ftp://ftp.ietf.org/internet-drafts/
>>>>
>>>>
>>>> _______________________________________________
>>>> Audio/Video Transport Core Maintenance
>>>> avt@ietf.org
>>>> https://www.ietf.org/mailman/listinfo/avt
>>>
>
> _______________________________________________
> Audio/Video Transport Core Maintenance
> avt@ietf.org
> https://www.ietf.org/mailman/listinfo/avt

-- 
Gunnar Hellström
GHAccess
gunnar.hellstrom@ghaccess.se