Re: [AVTCORE] WG last call on draft-ietf-avtcore-aria-srtp-04

Colin Perkins <csp@csperkins.org> Mon, 26 August 2013 12:31 UTC

Return-Path: <csp@csperkins.org>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2398D11E818D for <avt@ietfa.amsl.com>; Mon, 26 Aug 2013 05:31:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -106.599
X-Spam-Level:
X-Spam-Status: No, score=-106.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XqjQsvIEl5X2 for <avt@ietfa.amsl.com>; Mon, 26 Aug 2013 05:30:55 -0700 (PDT)
Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [93.93.130.6]) by ietfa.amsl.com (Postfix) with ESMTP id F2C1711E8186 for <avt@ietf.org>; Mon, 26 Aug 2013 05:30:54 -0700 (PDT)
Received: from [130.209.247.112] (port=52405 helo=mangole.dcs.gla.ac.uk) by balrog.mythic-beasts.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from <csp@csperkins.org>) id 1VDvwb-0007xk-5S; Mon, 26 Aug 2013 13:30:53 +0100
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
From: Colin Perkins <csp@csperkins.org>
In-Reply-To: <521B211E.4010707@ericsson.com>
Date: Mon, 26 Aug 2013 13:30:52 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <6CE7FA92-8D33-4B4A-A7CF-C4D4E2FD8CA6@csperkins.org>
References: <521B211E.4010707@ericsson.com>
To: Magnus Westerlund <magnus.westerlund@ericsson.com>
X-Mailer: Apple Mail (2.1508)
X-BlackCat-Spam-Score: -28
X-Mythic-Debug: Threshold = On =
Cc: IETF AVTCore WG <avt@ietf.org>
Subject: Re: [AVTCORE] WG last call on draft-ietf-avtcore-aria-srtp-04
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/avt>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Aug 2013 12:31:00 -0000

On 26 Aug 2013, at 10:34, Magnus Westerlund <magnus.westerlund@ericsson.com> wrote:
> WG,
> 
> This starts the WG last call on draft-ietf-avtcore-aria-srtp-04 to be
> published as proposed standard. Please provide any feedback or review
> comments by September 16. Even if you have just read it and found no
> issue, please state so.

From a quick look, this looks okay to me. Some nits:

The acronym RTCP is expanded incorrectly in the abstract and Introduction (should be "RTP Control Protocol" to match RFC3550). 

Appendix A: what is the byte order for the test vectors? (especially for fields like the seqnum and SSRC, which are commonly represented by ints in code)

Cheers,
Colin


-- 
Colin Perkins
http://csperkins.org/