Re: [AVTCORE] Benjamin Kaduk's No Objection on draft-ietf-payload-vp9-14: (with COMMENT)

Jonathan Lennox <jonathan.lennox@8x8.com> Fri, 04 June 2021 20:09 UTC

Return-Path: <jonathan.lennox@8x8.com>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA53E3A1F4F for <avt@ietfa.amsl.com>; Fri, 4 Jun 2021 13:09:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=8x8.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WOprcueIPQSn for <avt@ietfa.amsl.com>; Fri, 4 Jun 2021 13:09:30 -0700 (PDT)
Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5B6E33A1F54 for <avt@ietf.org>; Fri, 4 Jun 2021 13:09:30 -0700 (PDT)
Received: by mail-qv1-xf2a.google.com with SMTP id w9so5565072qvi.13 for <avt@ietf.org>; Fri, 04 Jun 2021 13:09:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=8x8.com; s=googlemail; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=pf7qVv1eH1+5+h4Ft36pY4cBKZNnx9312mbc0TDIa4A=; b=ch75sm+tjLXT56UUrrpM/3iFdLE3ghFIjtSmrIkE9W99DJRzzb7irOdf6fsjhvngH0 MCFHlIYBpejWwHaHat7m8ulRJv3m0WoJTFz3NiKa8dE4S/coZUthyqoqzH8/xewYQzms 7NOeBb4U8QLDSEZbD3Vw9NFh1wvfeEgsUlbaE=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=pf7qVv1eH1+5+h4Ft36pY4cBKZNnx9312mbc0TDIa4A=; b=qtaINTTcDkHVi5A+uRd5a5B+trJuCeDh0rh1QlS5BQ0Tc/qFuRCdrLh3+Am/pVNr3z 3muvhSSWJ1ex7aS8tBzfEZzEcN9eLar+hq2KpoxrloIhuSRBIkM6reIDRK1I/NExXFPb vS79cL2iXEm2mKV+4jtFWlmFmKqMYEj1FO2lSApgmEsEfpkZlCy/nqSePiiJHj7yrdiO LP1Up8Wz3qDT8zglVT629SElh9BhTWyJosbSv8ANY1m2d5kC9x8D97x+rbY/s+kF5mH7 V6yyM3zj6VeebD3YfSWUr1sR37iFgroxVbjukuQX+XnjJp2YK+7NaBf3M023xLSH0YxS VLiA==
X-Gm-Message-State: AOAM531KvX+stMuMty1BVEuhMN7kDsmr/laKD79CD7KErvNF3RMtpfph W166OUTQ79WoCatsra5ubXLPcQ==
X-Google-Smtp-Source: ABdhPJymg/U6lz5rA+zItMDLxEqhXKFzWBNW0VXFtsmr6HVwE2iI6dszT3XZnGWF9O7IKT6nOSoJwQ==
X-Received: by 2002:a0c:c481:: with SMTP id u1mr6241718qvi.48.1622837367951; Fri, 04 Jun 2021 13:09:27 -0700 (PDT)
Received: from smtpclient.apple (c-24-0-149-15.hsd1.nj.comcast.net. [24.0.149.15]) by smtp.gmail.com with ESMTPSA id 7sm4773946qkb.86.2021.06.04.13.09.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Jun 2021 13:09:27 -0700 (PDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\))
From: Jonathan Lennox <jonathan.lennox@8x8.com>
In-Reply-To: <162275798049.24886.18301371405247750024@ietfa.amsl.com>
Date: Fri, 4 Jun 2021 16:09:26 -0400
Cc: The IESG <iesg@ietf.org>, draft-ietf-payload-vp9@ietf.org, avtcore-chairs@ietf.org, IETF AVTCore WG <avt@ietf.org>, bernard.aboba@gmail.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <F4BAED8C-F0A9-4E27-AD5D-7AB39A7FAF5C@8x8.com>
References: <162275798049.24886.18301371405247750024@ietfa.amsl.com>
To: Benjamin Kaduk <kaduk@mit.edu>
X-Mailer: Apple Mail (2.3654.80.0.2.43)
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/M0MFIjBrxsQ4ZZ4p-cMzPeLW9yw>
Subject: Re: [AVTCORE] Benjamin Kaduk's No Objection on draft-ietf-payload-vp9-14: (with COMMENT)
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jun 2021 20:09:36 -0000


> On Jun 3, 2021, at 6:06 PM, Benjamin Kaduk via Datatracker <noreply@ietf.org> wrote:
> 
> Benjamin Kaduk has entered the following ballot position for
> draft-ietf-payload-vp9-14: No Objection
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thanks for addressing my Discuss point, and comments!
> I spotted a few maybe nits in the -14 while reviewing the diff.

Thanks, all of these are correct, I’ve published a -15.

> Section 3
> 
>   A Picture Group is a recurring pattern of spatial and temporal
>   dependencies which In this mode, each packet has an index to refer to
> 
> Looks like an editing remnant up to "In this mode".
> 
> Section 4.2
> 
>   I:  Picture ID (PID) present.  When set to one, the OPTIONAL PID MUST
>      be present after the mandatory first octet and specified as below.
>      Otherwise, PID MUST NOT be present.  If the V bit was set in the
>      stream's most recent start of a keyframe (i.e. the SS field was
>      present, and non-flexible scalability mode is in use), then this
>      bit MUST be set on every packet.
> 
> I may (still?) be confused, but I think the "non-flexible scalability mode is
> in use" belongs outside the parentheses, as it's an additional separate
> precondition from "V bit is set" for "this bit MUST be set".  That is, IIUC,
> non-flexible scalability mode requires SS and requires PIDs in every packet,
> but it's permitted to send SS in flexible scalability mode, and in the latter
> case it's permitted (but unexpected?) to omit PIDs from (some) packets.
> 
> Section 4.2.1
> 
>   In a scalable stream sent with a fixed pattern, the SS data SHOULD be
>   included in the first packet of every key frame.  This is a packet
>   with P bit equal to zero, SID or Lis not the bit equal to zero, and B
>   bit equal to 1.  [...]
> 
> I think there's some editing churn here as well, at least a space in "L is"
> but possibly more qualifiers about SID being zero vs L being the bit equal to
> zero.
> 
> 
>