Re: [AVTCORE] AD Evaluation draft-ietf-avtcore-rfc5285-bis-08

Roni Even <roni.even@huawei.com> Sun, 26 March 2017 19:08 UTC

Return-Path: <roni.even@huawei.com>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D41B0129686; Sun, 26 Mar 2017 12:08:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.222
X-Spam-Level:
X-Spam-Status: No, score=-4.222 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e3T5B70En2bz; Sun, 26 Mar 2017 12:08:11 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D3EA12968B; Sun, 26 Mar 2017 12:08:09 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml707-cah.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DJR41134; Sun, 26 Mar 2017 19:08:07 +0000 (GMT)
Received: from DGGEMM406-HUB.china.huawei.com (10.3.20.214) by lhreml707-cah.china.huawei.com (10.201.108.48) with Microsoft SMTP Server (TLS) id 14.3.301.0; Sun, 26 Mar 2017 20:08:06 +0100
Received: from DGGEMM506-MBS.china.huawei.com ([169.254.4.150]) by DGGEMM406-HUB.china.huawei.com ([10.3.20.214]) with mapi id 14.03.0301.000; Mon, 27 Mar 2017 03:07:58 +0800
From: Roni Even <roni.even@huawei.com>
To: Ben Campbell <ben@nostrum.com>, "draft-ietf-avtcore-rfc5285-bis.all@ietf.org" <draft-ietf-avtcore-rfc5285-bis.all@ietf.org>, IETF AVTCore WG <avt@ietf.org>
Thread-Topic: AD Evaluation draft-ietf-avtcore-rfc5285-bis-08
Thread-Index: AQHSpYjIrzbm/+bE9kuAVWaLOEoGPqGnc4ew
Date: Sun, 26 Mar 2017 19:07:58 +0000
Message-ID: <6E58094ECC8D8344914996DAD28F1CCD7A636B@DGGEMM506-MBS.china.huawei.com>
References: <F86E2466-D71E-404B-AC27-AC0865BFDE6B@nostrum.com>
In-Reply-To: <F86E2466-D71E-404B-AC27-AC0865BFDE6B@nostrum.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.47.146.130]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.58D81197.00E2, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.4.150, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 7b7ec5e889d82e18c4763e5a07e9f8e0
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/VjN0SQ8ZapfzU8Uklarje7pKORA>
Subject: Re: [AVTCORE] AD Evaluation draft-ietf-avtcore-rfc5285-bis-08
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Mar 2017 19:08:14 -0000

Ben,
See inline
Roni
> 
> 
> Hi,
> 
> This is my AD evaluation of draft-ietf-avtcore-rfc5285-bis-08. These are
> mostly editorial, but I'd like to resolve at least the substantive
> comments prior to IETF last call.
> 
> Thanks!
> 
> Ben.
> 
> - Substantive:
> 
> -- 6, paragraph 3, "... unless the
>     transmitter has some (out of band) knowledge..."
> Why bother with that exception? It seems like the negotiation is easy
> enough. If people write code assuming that out-of-band knowledge will be
> available, interoperability will suffer.
[Roni Even] We need it since RFC3264 is not the only usage. For example for declarative SDP there is no negotiation
> 
> -- 9, 2nd paragraph:
> 
> 3264 does not require integrity protection to be _used_, just _provided_
> (read: MUST implement). Does this mean to promote that to "MUST use"? If
> so, please be clear that this is a new requirement.
> 
> But from a practical perspective, do you believe people will really
> follow a "MUST use"? Is it a MUST (BUT WE KNOW YOU WON”T) [RFC6919] ?
[Roni Even] I am OK with changing it to" MUST be implemented"
> 
> 
> - Editorial:
> 
> -- 3, third paragraph:
> 
> This changes the "... mechanism may be available..." from the original
> to "... mechanism can be available...". I think "may be" is more correct
> here.
[Roni Even] OK
> 
> -- 4.1.1, first paragraph, first sentence:
> This is a statement of principle, and as such shouldn't use 2119
> keywords.
[Roni Even] OK, is changing to lower case enough? I can add a sentence to section 2 that normative language is written in capital letters in the document.
> 
> -- 4.1.2, 2nd paragraph: s/len/length  ; or "len field"  (2 occurances)
> 
[Roni Even] OK
> -- 4.1.2, 3rd paragraph, sentence starting with "Only the extension..."
> 
> “Only…MUST” constructs are ambiguous. The can be interpreted to
> say the MUST only applies to the matching set, and the rest are
> undefined. Please recast as “MUST NOT ”. (Note that this construct
> appears elsewhere in the draft, but I think the other occurrences are in
> the original text. I don't expect this update to fix those.)
[Roni Even] The text says that only one byte or two byte rtp header extensions MUST be used in an RTP packet. I am not sure what is confusing here?
> 
> --- "A transmitter MAY be aware...": That's a statement of fact; the MAY
> should not be capitalized.
[Roni Even]OK
> 
> -- 4.2, first sentence, first paragraph: The REQUIRED seems to be
> talking about an external requirement from RTP. If so, it should not be
> normative here.
[Roni Even]OK
> 
> -- 7, 11th paragraph, "Local identifiers in the valid range inclusive in
> an offer or answer
>     MUST NOT be used more than once per media section"
> 
> The MUST NOT was not capitalized in 5285, probably because it was the
> 4th time the requirement was mentioned :-). I don't think it needs to be
> promoted here.
[Roni Even]OK
> 
> -- 9, 1st paragraph: I don’t think this is an appropriate use of a
> 2119 MUST. (It wasn’t capitalized in the original.)
> 
[Roni Even]OK
> 
>