Re: [AVTCORE] draft-ietf-avtcore-multi-party-rtt-mix-08.txt - please review

Paul Kyzivat <pkyzivat@alum.mit.edu> Sat, 10 October 2020 18:50 UTC

Return-Path: <pkyzivat@alum.mit.edu>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 84EE33A168C for <avt@ietfa.amsl.com>; Sat, 10 Oct 2020 11:50:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.914
X-Spam-Level:
X-Spam-Status: No, score=-1.914 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, NICE_REPLY_A=-0.213, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=alum.mit.edu
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k23fYHE1EpMY for <avt@ietfa.amsl.com>; Sat, 10 Oct 2020 11:50:28 -0700 (PDT)
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2080.outbound.protection.outlook.com [40.107.236.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6D1373A1689 for <avt@ietf.org>; Sat, 10 Oct 2020 11:50:28 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dYlWDfXt1N1wfJedeK/gfnakmiuBVj76XlkyasTDoNKGGbiJ3a7+6qXdMk2wB5GzxXKnIvQ5JWsPC+mW0sbpBe8Q5XioEwCbOaJRD6CjloiZQnLet5hW4s4kDGFLHz1xc8AbtaSSIiQP+2XbAqGoaquy8jLxDhAUqoNU04aqfjjTcqigl0b7WiSuK0PCUhnEbvnjnqWAS+l51NdzCfx0r3b6+uBLk9UgCwi+TnpjK+wIXbU7Q0Sks3eja3+Ww9G6w2D6gv25Dyvy8beTTKRDeJ6zlZ1S7PpNaaPlbUoJvkmcYiOK5Jdfq4RHnvXm1dEUmIHUVLBoqqZZNXPooBonHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qVAqoUB6C5FjJga0NHxWMdDTW9bsKVHBVhoxsk0V/YE=; b=ZPi6wmiyIThuxSR88TZXZb6UB7M1ACuZg93e3rtsAK9HPesaefYe7e70mj7eeoYKLrmzkrPuu+VguWPdo6vFwfY49AIMK3QjbtLldRVWQazamJXYLqA4GIpAlLvEyyG+QzsNCxpmAIrXmDvL+Ja7rJWyRjLI792Kna4RS3DRtA0kYvdOJ1UhpLmi24HRGRUIB1BoznFYEHG+fL0KVb+PIMAxJtnZPZ8hZpXBQQqKL2LCnuiwomseJThLJyMVKF42PFYHaJPnMQE8o8PXsPu0l7udRcAIPMD4VBp6QWNPX+LU05GljqrEsr9WFgOzVlBYf4SrqFJb0u7ujZnUSPIF/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 18.7.68.33) smtp.rcpttodomain=ietf.org smtp.mailfrom=alum.mit.edu; dmarc=bestguesspass action=none header.from=alum.mit.edu; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alum.mit.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qVAqoUB6C5FjJga0NHxWMdDTW9bsKVHBVhoxsk0V/YE=; b=J5iDHqRKlQUd/xXZK3N1MoqRxEYkW9gZsOKlugZ9A89H08n6xgvQRnHGAFeBzayzxD6JkoHjUzj9amIVq5OWryHJiQ8tkwpxtW9BXj4U7aHeMTk2mkm/7HvyyhfTr3VeAXMcEEvxv4UEnEX2N7fHubtHQFDHb49jMtLvXdKQSEU=
Received: from MN2PR16CA0022.namprd16.prod.outlook.com (2603:10b6:208:134::35) by BN6PR1201MB0164.namprd12.prod.outlook.com (2603:10b6:405:4e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Sat, 10 Oct 2020 18:50:23 +0000
Received: from BL2NAM02FT048.eop-nam02.prod.protection.outlook.com (2603:10b6:208:134:cafe::4c) by MN2PR16CA0022.outlook.office365.com (2603:10b6:208:134::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.22 via Frontend Transport; Sat, 10 Oct 2020 18:50:23 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 18.7.68.33) smtp.mailfrom=alum.mit.edu; ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=bestguesspass action=none header.from=alum.mit.edu;
Received-SPF: Pass (protection.outlook.com: domain of alum.mit.edu designates 18.7.68.33 as permitted sender) receiver=protection.outlook.com; client-ip=18.7.68.33; helo=outgoing-alum.mit.edu;
Received: from outgoing-alum.mit.edu (18.7.68.33) by BL2NAM02FT048.mail.protection.outlook.com (10.152.76.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.25 via Frontend Transport; Sat, 10 Oct 2020 18:50:22 +0000
Received: from Kokiri.localdomain (c-24-62-227-142.hsd1.ma.comcast.net [24.62.227.142]) (authenticated bits=0) (User authenticated as pkyzivat@ALUM.MIT.EDU) by outgoing-alum.mit.edu (8.14.7/8.12.4) with ESMTP id 09AIoLNL007988 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT) for <avt@ietf.org>; Sat, 10 Oct 2020 14:50:21 -0400
To: avt@ietf.org
References: <159725784100.26501.7801603611291404620@ietfa.amsl.com> <cea92434-e74b-2fba-dc29-f1b29f5e22d9@ghaccess.se> <7c6ab084-95b6-1c07-fa78-c280a7a0ca6b@ghaccess.se>
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
Message-ID: <7f90dd6d-8a66-bc7c-0865-d1ce566c2306@alum.mit.edu>
Date: Sat, 10 Oct 2020 14:50:20 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:78.0) Gecko/20100101 Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <7c6ab084-95b6-1c07-fa78-c280a7a0ca6b@ghaccess.se>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 39f7234d-7309-405c-f355-08d86d4d57c5
X-MS-TrafficTypeDiagnostic: BN6PR1201MB0164:
X-Microsoft-Antispam-PRVS: <BN6PR1201MB0164509C71DA6F6B5CBDCABEF9090@BN6PR1201MB0164.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: NsIYJI+CsoBbxHwtGQ8v75YJ2WkAY49XhGjAWdDIih/+eU6tvMiqZaQJfH9tvsn620OkSnz9NHu4CIvSoyPCIiv3ZLYVUSTU3xMBTcd/9NRCOh3VFCy7XSob1Tn2oqF8dYSurjYFqNSlj1NKcjcU6KdWyDDDfNhlMLTzHdOgCywbagmUyTTNdAAgXiiStZfHTMsDCmpYx/HGj76UU5GdZ+Bzdqtm0leadAcYW92oAoURgUDjm49pqO7OkkWnCLzJJmcG7D9f55jZRYJR+jyO4wQiPfMYAg1MjFCv6D7PH+7gSyGE9mnVn7q2e3q8b+UQbRlK3FdMKEWlx1Wbe07JBT9mfQTjk3m2VJlzsWAPlvKLIxwxDYS3/Py0MrL7I9BiVumd3x39Qf/E+y4hoBBR3ZHrwYxy2s1CIyHps3z1o514UEa+8zwlnEcVJBYvIDV70YHYjql+r0QLEguO0msgTOT4KZJUophrGeo+Vh7YblguEsJ7pnv3D/yg2piPDsHB
X-Forefront-Antispam-Report: CIP:18.7.68.33; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:outgoing-alum.mit.edu; PTR:outgoing-alum.mit.edu; CAT:NONE; SFS:(396003)(39860400002)(376002)(346002)(136003)(46966005)(966005)(5660300002)(478600001)(186003)(75432002)(66574015)(70206006)(70586007)(36906005)(47076004)(786003)(336012)(2616005)(82740400003)(956004)(82310400003)(316002)(356005)(7596003)(31686004)(6916009)(86362001)(31696002)(26005)(8676002)(53546011)(83380400001)(8936002)(83080400001)(2906002)(43740500002); DIR:OUT; SFP:1101;
X-OriginatorOrg: alum.mit.edu
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2020 18:50:22.4835 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 39f7234d-7309-405c-f355-08d86d4d57c5
X-MS-Exchange-CrossTenant-Id: 3326b102-c043-408b-a990-b89e477d582f
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3326b102-c043-408b-a990-b89e477d582f; Ip=[18.7.68.33]; Helo=[outgoing-alum.mit.edu]
X-MS-Exchange-CrossTenant-AuthSource: BL2NAM02FT048.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0164
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/ZWXL7aLOmr0WPwm9CrGto9wii3o>
Subject: Re: [AVTCORE] draft-ietf-avtcore-multi-party-rtt-mix-08.txt - please review
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Oct 2020 18:50:31 -0000

Gunnar,

I haven't commented on this for some time because it seemed to be 
progressing well and those contributing know more about RTP and RTT than 
I do. Now that it seems to be approaching technical completeness (and 
because I was asked) I have reviewed it again. Here are my thoughts:

* Section 1:

s/by shorting the/by shortening the/

* Section 2.1:

Why was "rtt-mix-rtp-mixer" chosen as the name of the attribute? It 
seems cumbersome and redundant. Wouldn't "rtt-mixer" be sufficient?

* Section 2.1.18.3:

There are two instances of "deduct" here that I think should be "deduce".

* Section 2.1.20:

In the first and second paragraphs the reference to "this section" is 
unclear. I presume it means section 2.1 rather than section 2.1.20 or 
section 2.

In the second paragraph:  s/the the/the/

The third paragraph seems inappropriate for this section of the 
document, since this section is intended to apply only in cases where 
"rtt-mix-rtp-mixer" *has* been negotiated.

* Section 2.2:

The document specifies two alternative mechanisms, one in 2.1 and the 
other in 2.2. But the formatting is very weird because section 2.1 is 
long and detailed while section 2.2 is very short and delegates 
everything to section 3.2.

I suggest reorganizing the document to make this cleaner. E.g., move 
most of the content of content of section 2.1 (all the 2.1.x sections) 
to a new top level section. Then replace that with a small high level 
discussion of the alternative and a delegation to the new section for 
the details.

* Section 3.1:

You talk about "When text is received from multiple original sources 
simultaneously". The meaning of "simultaneously" is pretty fuzzy here. 
Do you think this is sufficient for implementors? You may want to say more.

* Section 8.1:

Please just omit "Attribute syntax:  a=rtt-mix-rtp-mixer". It is only 
for attributes that have values.

That's all. Generally looking good.

	Thanks,
	Paul

On 10/9/20 3:36 PM, Gunnar Hellström wrote:
> I would like to get review comments on 
> draft-ietf-avtcore-multi-party-rtt-mix-08.txt.
> 
> There are three small changes pending:
> 
> 1. The reference to the WebRTC transport of T.140 real-time text is 
> about to be changed from 
> draft-ietf-mmusic-t140-usage-data-channel-14.txt to RFC 8865, but even 
> if RFC 8865 is ready, it is awaiting common publication of a cluster of 
> WebRTC related drafts.
> 
> 2. A bit more detail in section 2.1.23 about the recovery situations in 
> case of packet loss.
> 
> 3. Correction of a minor error  in 2.1.23, where "A1" in the text under 
> packet 6 should be "A3".
> 
> Any further comments would be appreciated so that the draft can be 
> progressed.
> 
> /Gunnar
> 
> 
> Den 2020-08-12 kl. 20:52, skrev Gunnar Hellström:
>> A new version of the "RTP-mixer formatting of multi-party Real-time 
>> text" is available.
>>
>> This version moves forward with only two methods for multi-party 
>> mixing of RTP transported real-time text.
>>
>> The major one is RFC 4103 with transmission interval of 100 ms when 
>> there is text from more than one source to transmit, and source 
>> indicated in the CSRC list.
>>
>> The second one is the fallback for the situation that the endpoint 
>> does not have multi-party capability.
>>
>> Regards
>>
>> Gunnar
>>
>> Den 2020-08-12 kl. 20:44, skrev internet-drafts@ietf.org:
>>> A New Internet-Draft is available from the on-line Internet-Drafts 
>>> directories.
>>> This draft is a work item of the Audio/Video Transport Core 
>>> Maintenance WG of the IETF.
>>>
>>>          Title           : RTP-mixer formatting of multi-party 
>>> Real-time text
>>>          Author          : Gunnar Hellstrom
>>>     Filename        : draft-ietf-avtcore-multi-party-rtt-mix-08.txt
>>>     Pages           : 36
>>>     Date            : 2020-08-12
>>>
>>> Abstract:
>>>     Real-time text mixers for multi-party sessions need to identify the
>>>     source of each transmitted group of text so that the text can be
>>>     presented by endpoints in suitable grouping with other text from the
>>>     same source.
>>>
>>>     Regional regulatory requirements specify provision of real-time text
>>>     in multi-party calls.  RFC 4103 mixer implementations can use
>>>     traditional RTP functions for source identification, but the mixer
>>>     source switching performance is limited when using the default
>>>     transmission characteristics with redundancy.
>>>
>>>     Enhancements for RFC 4103 real-time text mixing is provided in this
>>>     document, suitable for a centralized conference model that enables
>>>     source identification and source switching.  The intended use is for
>>>     real-time text mixers and multi-party-aware participant endpoints.
>>>     The specified mechanism build on the standard use of the CSRC 
>>> list in
>>>     the RTP packet for source identification.  The method makes use of
>>>     the same "text/red" format as for two-party sessions.
>>>
>>>     A capability exchange is specified so that it can be verified that a
>>>     participant can handle the multi-party coded real-time text stream.
>>>     The capability is indicated by use of a media attribute 
>>> "rtt-mix-rtp-
>>>     mixer".
>>>
>>>     The document updates RFC 4103[RFC4103]
>>>
>>>     A specifications of how a mixer can format text for the case when 
>>> the
>>>     endpoint is not multi-party aware is also provided.
>>>
>>>
>>> The IETF datatracker status page for this draft is:
>>> https://datatracker.ietf.org/doc/draft-ietf-avtcore-multi-party-rtt-mix/
>>>
>>> There are also htmlized versions available at:
>>> https://tools.ietf.org/html/draft-ietf-avtcore-multi-party-rtt-mix-08
>>> https://datatracker.ietf.org/doc/html/draft-ietf-avtcore-multi-party-rtt-mix-08 
>>>
>>>
>>> A diff from the previous version is available at:
>>> https://www.ietf.org/rfcdiff?url2=draft-ietf-avtcore-multi-party-rtt-mix-08 
>>>
>>>
>>>
>>> Please note that it may take a couple of minutes from the time of 
>>> submission
>>> until the htmlized version and diff are available at tools.ietf.org.
>>>
>>> Internet-Drafts are also available by anonymous FTP at:
>>> ftp://ftp.ietf.org/internet-drafts/
>>>
>>>
>>> _______________________________________________
>>> Audio/Video Transport Core Maintenance
>>> avt@ietf.org
>>> https://www.ietf.org/mailman/listinfo/avt
>>