Re: [AVTCORE] AD Review of draft-ietf-avtcore-rtp-vvc-14
"Murray S. Kucherawy" <superuser@gmail.com> Tue, 12 April 2022 01:24 UTC
Return-Path: <superuser@gmail.com>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79EE73A0EE9 for <avt@ietfa.amsl.com>; Mon, 11 Apr 2022 18:24:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.107
X-Spam-Level:
X-Spam-Status: No, score=-7.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pg93rS-doewt for <avt@ietfa.amsl.com>; Mon, 11 Apr 2022 18:24:17 -0700 (PDT)
Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2A9773A0EE8 for <avt@ietf.org>; Mon, 11 Apr 2022 18:24:17 -0700 (PDT)
Received: by mail-vk1-xa2a.google.com with SMTP id n5so3231788vkq.10 for <avt@ietf.org>; Mon, 11 Apr 2022 18:24:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pHWQqQJzQMmzUKN4pGMMfg596gNoD9Fap51I3QB0Rmw=; b=m6QXBLXYyLeHWaziOwsJ9z5AT333MBqAFuRIgyVAzaCaodkeC00GSNRNrkn4t7Tf3K OGaBbBOdOPfSBlpygFCadNvnAhthshmQJ3J2wN79HSnFQAiJpMVrtcgDYuANJj1N19M2 b+VuUkXL8Xh4mwbsEraBCrw9r+FrJVVw0m24j69dXeFaEaBHLZZVjcRAl0UqqClUXsz1 BsFcIjwwOpiU0y6E/Lf7XOt9M79CpftXuyi2sCom6jNFOyTbi/aho5+rw1n/bvn/hRlm 7EuR/1XTRnjn2eAjMamwpTn9fzEdvlpn9YGS3kfq5Eyk+eaxFZfylfdidtnCOuZZyxPq p5NQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pHWQqQJzQMmzUKN4pGMMfg596gNoD9Fap51I3QB0Rmw=; b=l+zmUPA9arz7bH4JajH3S93UZYaFqp5Rtn5dZs7dnD+/9UdCg8a6sMGsVtnX0LuSv2 9mABZZz7bVDSXRn5p4XrrVJiY5/G/T3vCpwsQET40qPgxjQVzn7gqRHoIMYznjkmqw/8 QSiV+xDQSOuTNqN0leXSaiVh3QXyWcTTdlQ1kGZsLmbKNhnFD+GNI/ehN6kSGq4ItekL UV6wcynqykFNygOrP+VeONxIKl+0nRO1lJBoPAd9TboloudEhcekv0pArbzG8S0dyl6m qD7FjPq+HR16u3kFr7bgxdLJpCGtVtAK8SGYo/tisMSLA0V2PG7i+mUQL1UbSl77ebvu tJYg==
X-Gm-Message-State: AOAM530GHo4SO5+e/iy55yVAobiL+JgyGtuZddFnj69Jjp+A+lBmGbKj SLZgx3Trf59E3LT9Kw/+9s6nF/pkGD3qprAT/LI=
X-Google-Smtp-Source: ABdhPJysrzBnTUvHq4G5JgP29XHD2ScLRNDCC9M40YFcJbOroEkxneARAbUoY0uN3iUpuBDYfrGOfwSG5mBPt41MtH8=
X-Received: by 2002:a05:6122:209e:b0:345:aa34:7cb3 with SMTP id i30-20020a056122209e00b00345aa347cb3mr2012761vkd.34.1649726655545; Mon, 11 Apr 2022 18:24:15 -0700 (PDT)
MIME-Version: 1.0
References: <CAL0qLwaU=3D4y_Y8U-DrY__HmhSLeMJ64UFiJYkd=psMxMNfbA@mail.gmail.com> <8D0DE05D-9AD1-40D8-AD3B-3486C42D0964@stewe.org>
In-Reply-To: <8D0DE05D-9AD1-40D8-AD3B-3486C42D0964@stewe.org>
From: "Murray S. Kucherawy" <superuser@gmail.com>
Date: Mon, 11 Apr 2022 18:24:04 -0700
Message-ID: <CAL0qLwac1AYfPdwmcNODVPqCR6S_qmg7m989NA36M9cYXGjH9A@mail.gmail.com>
To: Stephan Wenger <stewe@stewe.org>
Cc: Bernard Aboba <bernard.aboba@gmail.com>, Jonathan Lennox <jonathan.lennox@8x8.com>, IETF AVTCore WG <avt@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000047c35c05dc6aeb08"
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/hN0Xpk7q8WdjVBq-P22F4VykHTo>
Subject: Re: [AVTCORE] AD Review of draft-ietf-avtcore-rtp-vvc-14
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Apr 2022 01:24:22 -0000
I didn't request them because only WGLC has been done. SECDIR will be automatically requested once this enters IETF LC; we can add a TSVDIR review too. If the chairs want to request early reviews before we start IETF LC, that's totally fine with me. -MSK On Mon, Apr 11, 2022 at 11:37 AM Stephan Wenger <stewe@stewe.org> wrote: > Hi Murray, > > Thanks for the review. One question to you, and to the chairs, before we > start editing: should we wait for sec-dir and transport-dir reviews? Are > there any of those requested? Should there be? (For previous video > payload formats, sec-dir wanted to weigh in on the security section and > transport on the congestion control.) > > Stephan > > > > *From: *avt <avt-bounces@ietf.org> on behalf of "Murray S. Kucherawy" < > superuser@gmail.com> > *Date: *Monday, April 11, 2022 at 10:55 > *To: *IETF AVTCore WG <avt@ietf.org> > *Subject: *[AVTCORE] AD Review of draft-ietf-avtcore-rtp-vvc-14 > > > > Hi all, > > > > Comments on this draft before we move it forward. I bounced around the > document as I went through this, checking references and whatnot, so this > is not in any particular order. > > > > Generally, this seems to be in good shape. Structurally, the major thing > that needs attention is the IANA stuff. A pet peeve of mine in documents > these days is abuse of SHOULD, but this seems to have used it properly for > the most part (I raised a couple of them below) so kudos there. > > > > This is an area of ART in which I'm not particularly strong, so it's > possible there are technical issues I've missed. I'm trusting that the WG > and other reviewers are comfortable with how solid this is in that regard. > > > > As a reminder, I will be around for the rest of this week and then on > vacation from IETF work until May. > > > > -MSK > > > > INTERESTING STUFF > > SECTION 1 > > > > The first sentence of the first paragraph appears to be incomplete. > > > > SECTION 7.1 > > > > This media type registration form is not complete. Several sections are > missing. Please use the template found in Section 5.6 of RFC 6838. Also, > "Required Parameters" should be "N/A", not "None". > > > > I suggest you include the completed template in Section 11. It can refer > to Section 7.1 for all the details about the optional parameters, etc. > > > > The general format of this section is also confusing. For instance, it > gradually goes through all of the optional parameters, but then just after > "interop-constraints", which is an optional parameter, it gets into > "sprop-sublayer-id" which is not in the list at the top of the template. I > can't tell if there should be a section break here, or if the list of > optional parameters is incomplete, or something else. > > > > SECTION 3.2 > > > > This section lists "RPS" as an acronym used in this document, but it isn't. > > > > SECTION 4.3.2 > > > > When would an implementation legitimately not do what the SHOULD says here? > > > > SECTION 7.2.2.3 > > I don't understand the SHOULD here. Can this work if an implementation > doesn't understand all of the media type parameters? When might one > legitimately continue without that being the case? > > > > APPENDIX A > > > > Please add a note to the RFC Editor to delete this section prior to > publication (which I assume is the intent). > > > > NITS > > SECTION 1.1.1 > > > > "... the maximum size of coding tree unit ..." -- missing "a" or "the"? > > > > s/signalling/signaling/ > > > > SECTION 1.1.2 > > > > s/labelled/labeled/ > > > > s/labelling/labeling/ (2x) > > > > s/signalling/signaling/ (2x) > > > > s/MPGEG/MPEG/ > > > > SECTION 1.1.3 > > > > s/signalling/signaling/ (3x) > > > > SECTION 5 > > > > "... aggregation packet together one or more NAL units ..." -- missing a > "with"? > > > > SECTION 6 > > > > "... RTP sequences number ..." -- s/sequences/sequence/ > > > > SECTION 7.1 > > > > s/signalling/signaling/ > > > > s/signalled/signaled/ (3x) > > > > SECTION 10 > > > > s/achieving/achieved/ > > > > >
- [AVTCORE] AD Review of draft-ietf-avtcore-rtp-vvc… Murray S. Kucherawy
- Re: [AVTCORE] AD Review of draft-ietf-avtcore-rtp… Stephan Wenger
- Re: [AVTCORE] AD Review of draft-ietf-avtcore-rtp… Murray S. Kucherawy
- Re: [AVTCORE] AD Review of draft-ietf-avtcore-rtp… Stephan Wenger
- Re: [AVTCORE] AD Review of draft-ietf-avtcore-rtp… Stephan Wenger
- Re: [AVTCORE] AD Review of draft-ietf-avtcore-rtp… Bernard Aboba
- Re: [AVTCORE] AD Review of draft-ietf-avtcore-rtp… Stephan Wenger