[AVTCORE] AD Review of draft-ietf-avtcore-rtp-vvc-14

"Murray S. Kucherawy" <superuser@gmail.com> Mon, 11 April 2022 17:55 UTC

Return-Path: <superuser@gmail.com>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 150073A159E for <avt@ietfa.amsl.com>; Mon, 11 Apr 2022 10:55:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id etaG8MX9-J6x for <avt@ietfa.amsl.com>; Mon, 11 Apr 2022 10:55:20 -0700 (PDT)
Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2FC4C3A159C for <avt@ietf.org>; Mon, 11 Apr 2022 10:55:20 -0700 (PDT)
Received: by mail-vs1-xe33.google.com with SMTP id r1so13948751vsi.12 for <avt@ietf.org>; Mon, 11 Apr 2022 10:55:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=jxkZ4YnUuNTuk2nG7hYezX4HrlTeHkxSw4jR9FrRIss=; b=igh3+v8huIDlQi4b6Z/OaQdkw8nh32R09KdGAMON67yfOv5/GBEaDmcqxDOvoFE8Jo Bmmq/1psqDFe69ZH9aHamm98sos/3JQ3RXqNYECI7Tt9ghLj7Doy7ORUihYwBEDFuVIq qR3bP/HcorpHroQzio6VpNqh0V65zNS20CX6ML/p+nByHwko1+UTl6E/BIRQFKHHnyO6 oSfkcg3iCsPUXx0ouWng/sWxr5Kt42Lgn/8b8pWAkgOKI12mKzh8yuuQvAVTE18+ADSS VP8SfJ9/IyKX3ZRUQRClDnIJE26EFAPjTD6lJ7qlj0Uxw02mUINMC+mLaVSpgx5X0Uet V04w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=jxkZ4YnUuNTuk2nG7hYezX4HrlTeHkxSw4jR9FrRIss=; b=l+QaygyTAQzpcWtau03pTN5Nb7lRfqmkPQF7udBt2cviH3YO12bZd6oZPk7cVm5NQh xKPJ6g4X8BF8UosYiK9OihWRofKIlv3ElLhir50O3Nl857DJjz8VwasDsO1sFd7vwk+o m4lz+Ran5xYi/yFMius9UsAsDkLgjCIRR12ITANFK3tv5OcUDjXTvxYySi1l0RTzs/0W w9GicNeSJxC2iDg/DCRuYSDiuljtPdyPDo1l7JFs/JjpPlWyDuB+C2jVdGtlcKXMVVSE eml0Tqyd69uWO4TXeN9dxNxugP8rlzUseUDqzEihlgRLA1yPx+h/dV6McpBwVcyM2NBj ZccQ==
X-Gm-Message-State: AOAM530xIF6l+/w6QKtAi4ykaQUq6hAmMlFr1guiCkfTASM/ooWZzDXI c4GHAZ0uVlcLI4RHV2TdCVu+r8CDlrxLlHtpS8dHbCwrN6k=
X-Google-Smtp-Source: ABdhPJwytgnDJjTRCszglCMMSAEGexiu2rSHekF4kuJiyQPnbCdIKI7mDrPEJsp9tIriLTmutQWasCufv6McXkvzAsY=
X-Received: by 2002:a67:c80a:0:b0:328:1b0c:ca07 with SMTP id u10-20020a67c80a000000b003281b0cca07mr5928879vsk.0.1649699718667; Mon, 11 Apr 2022 10:55:18 -0700 (PDT)
MIME-Version: 1.0
From: "Murray S. Kucherawy" <superuser@gmail.com>
Date: Mon, 11 Apr 2022 10:55:07 -0700
Message-ID: <CAL0qLwaU=3D4y_Y8U-DrY__HmhSLeMJ64UFiJYkd=psMxMNfbA@mail.gmail.com>
To: IETF AVTCore WG <avt@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000b7a29205dc64a577"
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/pkBRqYzRGW8q7Q7bea82Q2wfvJA>
Subject: [AVTCORE] AD Review of draft-ietf-avtcore-rtp-vvc-14
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Apr 2022 17:55:22 -0000

Hi all,

Comments on this draft before we move it forward.  I bounced around the
document as I went through this, checking references and whatnot, so this
is not in any particular order.

Generally, this seems to be in good shape.  Structurally, the major thing
that needs attention is the IANA stuff.  A pet peeve of mine in documents
these days is abuse of SHOULD, but this seems to have used it properly for
the most part (I raised a couple of them below) so kudos there.

This is an area of ART in which I'm not particularly strong, so it's
possible there are technical issues I've missed.  I'm trusting that the WG
and other reviewers are comfortable with how solid this is in that regard.

As a reminder, I will be around for the rest of this week and then on
vacation from IETF work until May.

-MSK

INTERESTING STUFF

SECTION 1

The first sentence of the first paragraph appears to be incomplete.

SECTION 7.1

This media type registration form is not complete.  Several sections are
missing.  Please use the template found in Section 5.6 of RFC 6838.  Also,
"Required Parameters" should be "N/A", not "None".

I suggest you include the completed template in Section 11.  It can refer
to Section 7.1 for all the details about the optional parameters, etc.

The general format of this section is also confusing.  For instance, it
gradually goes through all of the optional parameters, but then just after
"interop-constraints", which is an optional parameter, it gets into
"sprop-sublayer-id" which is not in the list at the top of the template.  I
can't tell if there should be a section break here, or if the list of
optional parameters is incomplete, or something else.

SECTION 3.2

This section lists "RPS" as an acronym used in this document, but it isn't.

SECTION 4.3.2

When would an implementation legitimately not do what the SHOULD says here?

SECTION 7.2.2.3

I don't understand the SHOULD here.  Can this work if an implementation
doesn't understand all of the media type parameters?  When might one
legitimately continue without that being the case?

APPENDIX A

Please add a note to the RFC Editor to delete this section prior to
publication (which I assume is the intent).

NITS

SECTION 1.1.1

"... the maximum size of coding tree unit ..." -- missing "a" or "the"?

s/signalling/signaling/

SECTION 1.1.2

s/labelled/labeled/

s/labelling/labeling/ (2x)

s/signalling/signaling/ (2x)

s/MPGEG/MPEG/

SECTION 1.1.3

s/signalling/signaling/ (3x)

SECTION 5

"... aggregation packet together one or more NAL units ..." -- missing a
"with"?

SECTION 6

"... RTP sequences number ..." -- s/sequences/sequence/

SECTION 7.1

s/signalling/signaling/

s/signalled/signaled/ (3x)

SECTION 10

s/achieving/achieved/