Re: [avtext] Warren Kumari's No Objection on draft-ietf-avtext-lrr-06: (with COMMENT)

Jonathan Lennox <jonathan@vidyo.com> Thu, 29 June 2017 23:13 UTC

Return-Path: <prvs=3353466a72=jonathan@vidyo.com>
X-Original-To: avtext@ietfa.amsl.com
Delivered-To: avtext@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 121EF12EB0D; Thu, 29 Jun 2017 16:13:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.1
X-Spam-Level:
X-Spam-Status: No, score=-1.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_SORBS_WEB=1.5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JFaO5-8rHb5O; Thu, 29 Jun 2017 16:13:26 -0700 (PDT)
Received: from mx0b-00198e01.pphosted.com (mx0b-00198e01.pphosted.com [67.231.157.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6474C12EAF2; Thu, 29 Jun 2017 16:13:23 -0700 (PDT)
Received: from pps.filterd (m0073110.ppops.net [127.0.0.1]) by mx0b-00198e01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5TNAJSC020193; Thu, 29 Jun 2017 19:13:17 -0400
Received: from mail.vidyo.com (mail2.vidyo.com [162.209.16.214]) by mx0b-00198e01.pphosted.com with ESMTP id 2b9ju3ugre-1 (version=TLSv1 cipher=AES128-SHA bits=128 verify=NOT); Thu, 29 Jun 2017 19:13:17 -0400
Received: from 492132-EXCH1.vidyo.com ([fe80::50:56ff:fe85:4f77]) by 492133-EXCH2.vidyo.com ([fe80::50:56ff:fe85:6b62%13]) with mapi id 14.03.0195.001; Thu, 29 Jun 2017 18:13:17 -0500
From: Jonathan Lennox <jonathan@vidyo.com>
To: Warren Kumari <warren@kumari.net>
CC: The The IESG <iesg@ietf.org>, "draft-ietf-avtext-lrr@ietf.org" <draft-ietf-avtext-lrr@ietf.org>, Rachel Huang <rachel.huang@huawei.com>, "avtext-chairs@ietf.org" <avtext-chairs@ietf.org>, "avtext@ietf.org" <avtext@ietf.org>
Thread-Topic: Warren Kumari's No Objection on draft-ietf-avtext-lrr-06: (with COMMENT)
Thread-Index: AQHS6RsNMw3gg5j+tEOCw43y2a8UAaI83C2A
Date: Thu, 29 Jun 2017 23:13:16 +0000
Message-ID: <1339D3E6-7F6D-44E0-855F-B68E53515FE5@vidyo.com>
References: <149789055182.10693.14113388808017091940.idtracker@ietfa.amsl.com>
In-Reply-To: <149789055182.10693.14113388808017091940.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [160.79.219.114]
Content-Type: text/plain; charset="utf-8"
Content-ID: <D22C65BCA814AC4B844F76464C0A1223@vidyo.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-06-29_16:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706290369
Archived-At: <https://mailarchive.ietf.org/arch/msg/avtext/4D8Lyx7xCJ18q3hyLRHxpD-YtAE>
Subject: Re: [avtext] Warren Kumari's No Objection on draft-ietf-avtext-lrr-06: (with COMMENT)
X-BeenThere: avtext@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Audio/Video Transport Extensions working group discussion list <avtext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avtext>, <mailto:avtext-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avtext/>
List-Post: <mailto:avtext@ietf.org>
List-Help: <mailto:avtext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avtext>, <mailto:avtext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jun 2017 23:13:28 -0000

Hi, sorry for the delay in responding.  Responses inline.

> On Jun 19, 2017, at 12:42 PM, Warren Kumari <warren@kumari.net> wrote:
> 
> Warren Kumari has entered the following ballot position for
> draft-ietf-avtext-lrr-06: No Objection
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Firstly, thank you for addressing Fred Baker's OpsDir comments -
> https://datatracker.ietf.org/doc/review-ietf-avtext-lrr-05-opsdir-lc-baker-2017-06-07/
> -- this change "fixes" the document for me.
> 
> I found this document easy to read, and a useful introduction to the topic;
> this is in spite of my knowing basically nothing about codecs and RTCP.
> 
> I did have some nits and a larger question:
> Question:
> 1: 3.1.  Message Format (and others)
> The document says things like: " When C is 1, TTID MUST NOT be less than CTID,
> and TLID MUST NOT be less than CLID;" -- cool, no worries... But, what do I do
> if I receive an LRR feedback message where e.g: the TTID *is* less than CTID?
> Do I just ignore the message? Do I self destruct? (Basically, what does
> error-handling look like?)

My inclination had been to leave it up to implementor discretion, as with most malformed messages, but on reflection that possibly wouldn't be great for future extensibility.    I’ll say it MUST be discarded.  This is then the same as the requirement if you get a message with an invalid layer ID.

> Nits:
> 1: 2.1.  Terminology
> "In a layer refresh, however, other layers than the ones requested for refresh
> may still..." To me the "other layers" bit sounds clumsy - "In a layer refresh,
> however, layers other than the ones requested for refresh may still..." reads
> much better - this construct is in a few other places too. I don't think that
> this changes the meaning at all; tis just a nit, feel free to ignore.

That’s fine, you’re right, it reads better.

> 2: The "numbers" in the figures feel like they are going backwards (or I've
> completely misunderstood the document :-)) -- I would expect the frame numbered
> '1' to be the first frame, and the second to be numbered 2. So, the number in
> the diagrams would go " 4  3  2  1 "; otherwise, you are counting "down"
> towards frame 0. It feels weird (and is somewhat confusing) for e.g frame 2 to
> be based on frame 3 (and not frame 1). I have no idea if this is the convention
> for frame numbering - if so, feel free to ignore.

‘1’ is indeed intended to be the first frame in all the cases; and frame 2 is indeed dependent on frame 1.  So clearly my diagram is confusing.

But I can’t see how you’re interpreting it that way.  What about the diagram made you think frame 2 is dependent on frame 3?

> 3: The convention is Security Considerations go just before IANA Considerations
> -- swap S6 and 7? (Hey, I did say these are nits!)

No problem.