Re: [avtext] Genart last call review of draft-ietf-avtext-lrr-05

Jonathan Lennox <jonathan@vidyo.com> Tue, 06 June 2017 21:29 UTC

Return-Path: <prvs=2330dcf6e2=jonathan@vidyo.com>
X-Original-To: avtext@ietfa.amsl.com
Delivered-To: avtext@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A0E7128BB6; Tue, 6 Jun 2017 14:29:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.101
X-Spam-Level:
X-Spam-Status: No, score=-1.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_SORBS_WEB=1.5, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zZIKklfqlck1; Tue, 6 Jun 2017 14:29:51 -0700 (PDT)
Received: from mx0b-00198e01.pphosted.com (mx0b-00198e01.pphosted.com [67.231.157.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4C46F1286AB; Tue, 6 Jun 2017 14:29:51 -0700 (PDT)
Received: from pps.filterd (m0073110.ppops.net [127.0.0.1]) by mx0b-00198e01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v56LOVoc021442; Tue, 6 Jun 2017 17:29:47 -0400
Received: from mail.vidyo.com (mail2.vidyo.com [162.209.16.214]) by mx0b-00198e01.pphosted.com with ESMTP id 2auqv5hw5d-1 (version=TLSv1 cipher=AES128-SHA bits=128 verify=NOT); Tue, 06 Jun 2017 17:29:47 -0400
Received: from 492132-EXCH1.vidyo.com ([fe80::50:56ff:fe85:4f77]) by 492133-EXCH2.vidyo.com ([fe80::50:56ff:fe85:6b62%13]) with mapi id 14.03.0195.001; Tue, 6 Jun 2017 16:29:46 -0500
From: Jonathan Lennox <jonathan@vidyo.com>
To: Roni Even <ron.even.tlv@gmail.com>
CC: General Area Review Team <gen-art@ietf.org>, "avtext@ietf.org" <avtext@ietf.org>, "draft-ietf-avtext-lrr.all@ietf.org" <draft-ietf-avtext-lrr.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-avtext-lrr-05
Thread-Index: AQHS2qO4IAQ0EK1qvUeY+IF4GawhgaIYtpMA
Date: Tue, 06 Jun 2017 21:29:46 +0000
Message-ID: <BAFC5C7C-466C-4756-9AF1-A803196E7D25@vidyo.com>
References: <149629998360.19813.14889515687249184753@ietfa.amsl.com>
In-Reply-To: <149629998360.19813.14889515687249184753@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [160.79.219.114]
Content-Type: text/plain; charset="utf-8"
Content-ID: <5924C4BD17D7B24286A72B3867D63104@vidyo.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-06-06_14:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706060372
Archived-At: <https://mailarchive.ietf.org/arch/msg/avtext/GQEeIxJ1Pe8fmy9Ddkl_-cuaZMQ>
Subject: Re: [avtext] Genart last call review of draft-ietf-avtext-lrr-05
X-BeenThere: avtext@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Audio/Video Transport Extensions working group discussion list <avtext.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avtext>, <mailto:avtext-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avtext/>
List-Post: <mailto:avtext@ietf.org>
List-Help: <mailto:avtext-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avtext>, <mailto:avtext-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jun 2017 21:29:53 -0000

Hi, Roni — thanks for your review.  Responses inline.

> On Jun 1, 2017, at 2:53 AM, Roni Even <ron.even.tlv@gmail.com> wrote:
> 
> Reviewer: Roni Even
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-avtext-lrr-??
> Reviewer: Roni Even
> Review Date: 2017-05-31
> IETF LC End Date: 2017-06-08
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> The document is ready with issues for a standard track RFC
> Major issues:
> 
> Minor issues:
> 
> 1. Can you specify both TTID and TLID in the same FCI.

Syntactically, they must both occur.

If you mean can you request an upgrade in both at once, yes; I’ve added text to clarify this.

> 2. What is the meaning of value 0 for TTID and TLID - TID or LID =0 in
> frame marking draft means base layer if there is scalability.
>     This relates to the previous question. 

I’m not sure I understand this question.

I’ve added text that if C=1, at least one of <TTID, TLID> MUST be greater than <CTID, CLID>, and both MUST be greater than or equal to their counterpart, so the LRR is actually requesting a layer upgrade.  Is that what you were asking about?

> 3.  What would an FCI with both TTID and TLID equal 0 mean.

It means you want a refresh of the base temporal/spatial layer, only.

> Nits/editorial comments: 
> 
> 1. Section 3 "an Real-Time Transport Control Protocol" should be "a
> Real…".

Colin pointed out that it should say “an RTP Control Protocol” anyway.

> 2. In section 3 " [RFC5104](Section 3.5.1)" there is a link to section
> 3.5.1 but it does not work.

xml2rfc doesn’t have any way to link to sections of other documents, so the “(Section 3.5.1)” part is just a comment.

I think the internet-draft tooling may have thought I was trying to link to a non-existent section 3.5.1 of this document, but that’s outside my control.

> 3. In section 3.2 "(see section Section 2.1)" section appears twice.

Fixed.