Re: [babel] I-D Action: draft-ietf-babel-mac-relaxed-01.txt

David Schinazi <dschinazi.ietf@gmail.com> Tue, 14 June 2022 22:55 UTC

Return-Path: <dschinazi.ietf@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 24423C15AADE for <babel@ietfa.amsl.com>; Tue, 14 Jun 2022 15:55:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gLGASAnfzVIK for <babel@ietfa.amsl.com>; Tue, 14 Jun 2022 15:55:55 -0700 (PDT)
Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 60BC9C15AADD for <babel@ietf.org>; Tue, 14 Jun 2022 15:55:55 -0700 (PDT)
Received: by mail-pj1-x102e.google.com with SMTP id e9so9689843pju.5 for <babel@ietf.org>; Tue, 14 Jun 2022 15:55:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1JCYvsk0JLjxVreab9iQbr472B7f1YPZvd+A88HeKho=; b=PfXMgsTY0Rh/9cdrGMc/TIeqcZc7MKej4x6i2R4D4+toz7YBIeskkpcY9UKp8TOXp3 fPNc7ZkCxTvCyCDTapcqhdGpsnEkN8dUAC8CwM3UeruLcXETQhceul7OJpTMMslgaDfG 2VFYE3KsoCr5gPeVV9BfOBY/MrU+9DdJ8KmRUjKmA1pPmmHnHqFKFDfoQhdM0u+NxIsH 14b9+6J5ndbY1doRBavKRSnvUXAASRkgikl1wNGGyn7NL2D6NgOZrY7wP8nWM7lmNpBX tPlKnSAwPcOvpdsTtO8TI3DIBhd8/D9zHzC+bKNpnTdsT1Hy7EBwbQzA5wlNlXiUZo8/ 0/qQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1JCYvsk0JLjxVreab9iQbr472B7f1YPZvd+A88HeKho=; b=FihYOsBzZKI/FrK0h3DiG5RmbU8pRPxSaUX/PUdDHHswsnBiqvmdu3VTZxLwR9RcVR GVY6fZhRCAxlIKkKauGhxF2RVKI0iWWJa0tzNAiPRKjYeX/eZcr1klFdA8QWKy+MNjSA Ft7ki1AqAJKzoEUMt7+yy1s3dJOZm7BTG6QCIhSig0krCvHn2Ia0X3xbJyv3NJu1mYyu kfs3mYj5CgQyifKcudurqrzLeDLcX8FHvKHW7xXSKItVjUsC5tkFN6PUe7S9ox5bx9dV U7kSEpD02Ndh7mEodHR71dk7a4FK5DvnL1o1tRGC1OAKcbPdX+rO2BNdf447hJ6zmLfj Ienw==
X-Gm-Message-State: AJIora8aFOA3NgejP9Uf/I0OF8ER17OcYTvk9b5bKLsaZ1S1JV2uzWwj v52liaKdcoi6m/BZBCT4vPEDQOQyCJ4b5qQXSpr/c8yQSrs=
X-Google-Smtp-Source: AGRyM1tQ/P1EDMHTp2QAtOqNMzjNYS/dglzZvDXBoe0uoAqvm5x6LIL+8pOMloBefsYMTUZU9K5qvJhw8iUj1+YVaSw=
X-Received: by 2002:a17:90a:8592:b0:1dd:bab:d286 with SMTP id m18-20020a17090a859200b001dd0babd286mr6852595pjn.143.1655247354816; Tue, 14 Jun 2022 15:55:54 -0700 (PDT)
MIME-Version: 1.0
References: <165497641116.1810.2867115989502325783@ietfa.amsl.com> <87a6ajj63q.wl-jch@irif.fr>
In-Reply-To: <87a6ajj63q.wl-jch@irif.fr>
From: David Schinazi <dschinazi.ietf@gmail.com>
Date: Tue, 14 Jun 2022 15:55:43 -0700
Message-ID: <CAPDSy+4ZW_YFCnMp9ZL4411P7=oKZ7HkxhZjOgdWS4ngovoqLQ@mail.gmail.com>
To: Juliusz Chroboczek <jch@irif.fr>
Cc: Babel at IETF <babel@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000996b7705e1704e51"
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/01Tn1HDSgkym0EeoOARH4GNBkkk>
Subject: Re: [babel] I-D Action: draft-ietf-babel-mac-relaxed-01.txt
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jun 2022 22:55:57 -0000

I have reviewed this document and believe that the protocol itself is solid
and ready for advancement but the doc needs just a little bit of editorial
work: I found section 3.2 a little bit hard to follow. I would suggest
giving variable names to the numbers at play and using those instead of
"right edge" and "left edge" because it took me a second to deduce that the
highest seen packet number was equal to the left edge and not the right
edge of the window. I personally like pseudo-code for this purpose but
prose also works if we can define the terms a little better. Maybe adding
some prose to the definition of right edge and left edge would be enough to
make this fine though.

I unfortunately no longer have access to a Babel implementation to actually
implement this, but I imagined I had one when I read the draft and it was
straightforward to add this feature to my imaginary implementation. Now I
just need to write an imaginary compiler.

nits/typos:
s/WiFi/Wi-Fi/
s/porte/port/
s/complementar/complementary/

David

On Sat, Jun 11, 2022 at 1:30 PM Juliusz Chroboczek <jch@irif.fr> wrote:

> >       Filename        : draft-ietf-babel-mac-relaxed-01.txt
>
> I feel that this version is complete.  There are two independent
> implementations (babeld and BIRD).  Please review.
>
> Thanks,
>
> -- Juliusz
>
> _______________________________________________
> babel mailing list
> babel@ietf.org
> https://www.ietf.org/mailman/listinfo/babel
>